[GitHub] activemq-artemis issue #845: ARTEMIS-801 Decode URL paths

2016-10-18 Thread dudaerich
Github user dudaerich commented on the issue:

https://github.com/apache/activemq-artemis/pull/845
  
Hi @clebertsuconic
my intention here was to fix tests which fail in our CI. The path to 
project directory contains '&' characters. Example of path:
```
.../jdk/java18_default/label/RHEL6&_64/...
```
I didn't realize that this could cause problems at more places in the code. 
Using URI to open a file is much better solution than decoding the URL :). 
Thanks for the proper fix, it looks good. I executed the tests with your fix 
and they passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis issue #845: ARTEMIS-801 Decode URL paths

2016-10-17 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/845
  
@dudaerich I have committed a fix with this PR. Please take a look, it is a 
more complete fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis issue #845: ARTEMIS-801 Decode URL paths

2016-10-17 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/845
  
@dudaerich can you close your PR?

You hit an issue, but you are fixing the test, not the issue... I mean.. 
this will hide the issue not fix it.


I will provide a proper fix using everything you found here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] activemq-artemis issue #845: ARTEMIS-801 Decode URL paths

2016-10-17 Thread clebertsuconic
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/845
  
do you have an example of such path?

I suggest you also look at 
artemis-distribution/src/test/scripts/validate-spaces.sh


I always run validate-spaces.sh.. I even have a little script on my dev 
environemnt to always run it. so maybe we could expand validate-spaces to also 
validate such thing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---