[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...
Github user dejanb commented on the issue: https://github.com/apache/activemq-artemis/pull/964 Great. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...
Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/964 @dejanb I've rebased and pushed another PR (so we get the PR checks) at #1021. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/964 Looks like you may need to rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/964 @dejanb, where are you on the test effort? Also, can you amend your commit message to follow the 50/72 format discussed in the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/code.md#commitMessageDetails)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...
Github user dejanb commented on the issue: https://github.com/apache/activemq-artemis/pull/964 @clebertsuconic It's not a new functionality, it's just adjusting mqtt layer code, which used hard-coded wildcard characters. I'll add a test to verify wildcard syntax of ActiveMQ 5, works fine and that we can exchange messages between mqtt and JMS clients. That should help with future migrations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/964 @dejanb I am confused.. is this new functionality, or this is just a refactoring of an existing one (on which case you wouldn't need tests). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #964: https://issues.apache.org/jira/browse/ARTEMIS-8...
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/964 A test would be nice --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
