[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/788 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/788#discussion_r79900443
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
fi
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+ LIBRARY_PATH=""
--- End diff --
Actually no, the ./artemis create will use the libaio to determine the
journal type (if it can't load libaio, it won't use it).. and it will also
perform a sync on the system to calculate the timed-buffer values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/788#discussion_r79900532
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
fi
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+ LIBRARY_PATH=""
--- End diff --
if ./create can't find libaio, the configuration will be set to NIO and aio
won't be used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/788#discussion_r79899679
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
fi
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+ LIBRARY_PATH=""
--- End diff --
We only need to set the library path for the actual broker instance, right?
We don't need to set it for the other CLI commands.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/788#discussion_r79899253
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
fi
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+ LIBRARY_PATH=""
--- End diff --
If the user is on a Linux system then I would expect `uname -a` to return
`x86_64` or `i686`. My thought here was to avoid setting the library path for
systems where `uname -a` returned something other than what we support
out-of-the-box.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/788#discussion_r79898185
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
fi
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+ LIBRARY_PATH=""
--- End diff --
There are two artemis I think.. one for the distribution, one for the
instance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/788#discussion_r79898051
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis
---
@@ -105,6 +105,16 @@ if [ -z "$LOG_MANAGER" ] ; then
LOG_MANAGER="$ARTEMIS_HOME/lib/${logmanager}"
fi
+# determine which native library version to load
+LIBRARY_PATH="-Djava.library.path=\"$ARTEMIS_HOME/bin/lib"
+if [ "$(uname -m)" = "x86_64" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-x86_64\""
+elif [ "$(uname -m)" = "i686" ]; then
+ LIBRARY_PATH="$LIBRARY_PATH/linux-i686\""
+else
+ LIBRARY_PATH=""
--- End diff --
We need something here in case of else.
Say you are on a Linux for a new System, and the user compiled the library
himself. on that case you need something on the LD_LIBRARY_PATH to work.
Maybe we could have the x86_64 here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #788: ARTEMIS-732 loading wrong arch lib
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/788 ARTEMIS-732 loading wrong arch lib You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-732 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/788.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #788 commit 1f4a768b1bf58c1e5fd1b9e1df85ac94ae533037 Author: jbertram Date: 2016-09-21T17:41:22Z ARTEMIS-732 loading wrong arch lib --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
