[GitHub] [airflow-client-go] houqp opened a new pull request #1: Add generated go client

2020-06-30 Thread GitBox
houqp opened a new pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow-client-go] mik-laj commented on a change in pull request #1: Add generated go client

2020-06-30 Thread GitBox
mik-laj commented on a change in pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#discussion_r447492769 ## File path: airflow/.travis.yml ## @@ -0,0 +1,8 @@ +language: go Review comment: This is automatic generated configuration. As far as we

[GitHub] [airflow-client-go] turbaszek commented on a change in pull request #1: Add generated go client

2020-06-30 Thread GitBox
turbaszek commented on a change in pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#discussion_r447491415 ## File path: airflow/.travis.yml ## @@ -0,0 +1,8 @@ +language: go Review comment: I would suggest to use Github Actions as we do in

[GitHub] [airflow-client-go] mik-laj commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox
mik-laj commented on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651638355 @gerardo We're already working to fix it. This is an automated message from the Apache Git Service. To

[GitHub] [airflow-client-go] turbaszek commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox
turbaszek commented on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651624991 Also most of the files miss ASF license so I think it would be nice to bring some Airflow pre-commits to this repo? We can also add compilation step to be sure the

[GitHub] [airflow-client-go] potiuk commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox
potiuk commented on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651624109 > Do we plan to have E2E tests? I think the plan is just to make PR out of the generated code here but the tests will be executed still in the main airflow repo. That

[GitHub] [airflow-client-go] mik-laj commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox
mik-laj commented on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651634016 > I think the plan is just to make PR out of the generated code here but the tests will be executed still in the main airflow repo. That seems like most sensible thing to

Re: [GitHub] [airflow-client-go] mik-laj commented on pull request #1: Add generated go client

2020-06-30 Thread Jarek Potiuk
Sorry for the spam again. It should all be fixed now! On Tue, Jun 30, 2020 at 10:24 AM Jarek Potiuk wrote: > Just for everyone - by gitbox "suggestion" when creating the new "client" > repo I set "dev@" as commit notification. I am asking ingra to fix it. > Sorry for the spam! > > On Tue, Jun

[GitHub] [airflow-client-go] mik-laj commented on a change in pull request #1: Add generated go client

2020-06-30 Thread GitBox
mik-laj commented on a change in pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#discussion_r447490387 ## File path: airflow/.travis.yml ## @@ -0,0 +1,8 @@ +language: go Review comment: Should this file be in the root directory?

[GitHub] [airflow-client-go] mik-laj commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox
mik-laj commented on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651636094 > I couldn't find an option to include license header in all generated files in openapi-generator. You need to generate a client and then run another tool that will

[GitHub] [airflow-client-go] gerardo commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox
gerardo commented on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651636800 This PR started polluting the dev@airflow.apache.org list. Was this intended? This is an automated message

[GitHub] [airflow-client-go] houqp commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox
houqp commented on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651632819 I couldn't find an option to include license header in all generated files in openapi-generator. This is an

[GitHub] [airflow-client-go] houqp commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox
houqp commented on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651622366 @turbaszek i think that would be something useful to add, but would be better added as a separate PR to reduce scope of this current since it's already a pretty big change :P

[GitHub] [airflow-client-go] houqp edited a comment on pull request #1: Add generated go client

2020-06-30 Thread GitBox
houqp edited a comment on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651622366 @turbaszek i think that would be something useful to add, but would be better added as a follow up PR to reduce scope of this current since it's already a pretty big

Problem With backport cncf.kubernetes

2020-06-30 Thread JOAQUIM, Kevin
Hi Team, I want to used the backport for Kubernetes_pod_operator, but when i try pip install apache-airflow-backport-providers-google[cncf.kubernetes], I have this Error : ERROR: Could not find a version that satisfies the requirement apache-airflow-backport-providers-cncf-kubernetes; extra

[GitHub] [airflow-client-go] turbaszek commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox
turbaszek commented on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651616314 Do we plan to have E2E tests? This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow-client-go] mik-laj commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox
mik-laj commented on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651631792 I am wondering about the lack of license headers, but I think we can do them later. The main thing is to do it before the release of the first version.

[GitHub] [airflow-client-go] houqp commented on a change in pull request #1: Add generated go client

2020-06-30 Thread GitBox
houqp commented on a change in pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#discussion_r447496649 ## File path: airflow/.travis.yml ## @@ -0,0 +1,8 @@ +language: go Review comment: this is generated by openapi-spec, which is not useful for

Re: [GitHub] [airflow-client-go] mik-laj commented on pull request #1: Add generated go client

2020-06-30 Thread Jarek Potiuk
Just for everyone - by gitbox "suggestion" when creating the new "client" repo I set "dev@" as commit notification. I am asking ingra to fix it. Sorry for the spam! On Tue, Jun 30, 2020 at 10:20 AM GitBox wrote: > > mik-laj commented on pull request #1: > URL: >

[GitHub] [airflow-client-go] mik-laj edited a comment on pull request #1: Add generated go client

2020-06-30 Thread GitBox
mik-laj edited a comment on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651636094 > I couldn't find an option to include license header in all generated files in openapi-generator. You need to generate a client and then run another tool that

[GitHub] [airflow-client-go] mik-laj commented on a change in pull request #1: Add generated go client

2020-06-30 Thread GitBox
mik-laj commented on a change in pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#discussion_r447504501 ## File path: airflow/.travis.yml ## @@ -0,0 +1,8 @@ +language: go Review comment: You will still be able to do this if you use -