Thanks Kaxil.
Both ideas (having separate repos and having separate voting) sounds sensible
to me. Cannot really think of significant drawbacks.
XD
> On 1 Jul 2020, at 9:35 PM, Kaxil Naik wrote:
>
> Forgot to mention, having them in separate repo also helps in better
> managing each
I do not think it's only the question of Mono/Multi repos. While I clearly
see the benefit of separate repos I also see some drawbacks.
And if it bothers others, I am happy to follow the majority. If we think
that a bit more complexity in testing justifies separating those three
completely and
Hi all,
What do you all think about having Dockerfile and Helm chart in the same
"Airflow" Repo vs separate?
I feel having a separate repo for Airflow Dockerfile and Helm chart have
more benefits like easy to track changes (via Changelog), easy for new
contributors, separate release cadence.
Forgot to mention, having them in separate repo also helps in better
managing each individual artifacts.
Each repo would have a separate Github Issue where we can track the issue
specific to Helm chart or Dockerfile.
Regards,
Kaxil
On Wed, Jul 1, 2020 at 8:30 PM Kaxil Naik wrote:
> The PMC
Hello,
I would also prefer to make this change after the release of Airflow 2.0.
I would like to suggest that we use black without normalizing strings. In
my opinion, using two apostrophes in one file style does not affect the
readability of the code. On other hand, this can drastically reduce
Sure. We can work with such an approach. There will be some dependencies
that we might find are problematic, but If we all see that it's
worth trying, there is a clear benefit that it makes for a "clean"
split between those different "entities". And possibly once we release
first versions of both
I think that once we add integration tests (which I’ll do now that we have helm
for k8s) and we no longer have to back port this is a great idea.
via Newton Mail
[https://cloudmagic.com/k/d/mailapp?ct=dx=10.0.50=10.14.6=email_footer_2]
On Wed, Jul 1, 2020 at 4:17 PM, Kaxil Naik wrote:
That
+1 no string normalization
On Wed, Jul 1, 2020 at 3:20 PM Kamil Breguła
wrote:
> Hello,
>
> I would also prefer to make this change after the release of Airflow 2.0.
>
> I would like to suggest that we use black without normalizing strings. In
> my opinion, using two apostrophes in one file
That sounds good. I will turn off String Normalization.
On Thu, Jul 2, 2020 at 12:11 AM Daniel Standish
wrote:
> +1 no string normalization
>
> On Wed, Jul 1, 2020 at 3:20 PM Kamil Breguła
> wrote:
>
> > Hello,
> >
> > I would also prefer to make this change after the release of Airflow 2.0.
>
I’m fine with keeping it as three separate repos but merging testing somehow
(e.g. the source code chart would pull the helm/docker chart into .build) but
we need to do it in a way that doesn’t make testing too difficult.
So for example: How do I test/integration test a change that involves a
The PMC also needs to agree if we want separate VOTING for Docker Image and
Helm chart, I think we do.
Regards,
Kaxil
On Wed, Jul 1, 2020 at 8:06 PM Kaxil Naik wrote:
> Hi all,
>
> What do you all think about having Dockerfile and Helm chart in the same
> "Airflow" Repo vs separate?
>
> I feel
11 matches
Mail list logo
