Re: [GitHub] [airflow-client-go] mik-laj commented on pull request #1: Add generated go client

2020-06-30 Thread Jarek Potiuk
Sorry for the spam again. It should all be fixed now!

On Tue, Jun 30, 2020 at 10:24 AM Jarek Potiuk 
wrote:

> Just for everyone - by gitbox "suggestion" when creating the new "client"
> repo I set "dev@" as commit notification. I am asking ingra to fix it.
> Sorry for the spam!
>
> On Tue, Jun 30, 2020 at 10:20 AM GitBox  wrote:
>
>>
>> mik-laj commented on pull request #1:
>> URL:
>> https://github.com/apache/airflow-client-go/pull/1#issuecomment-651636094
>>
>>
>>> I couldn't find an option to include license header in all generated
>> files in openapi-generator.
>>
>>You need to generate a client and then run another tool that will add
>> the missing licenses. We use pre-commit to automatically add licenses in
>> apache/airflow, but you can think of another alternative.  An alternative
>> tool can be written in Python, Bash or be a completely external binary.
>>
>> https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml#L29-L129
>>
>>
>> 
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> For queries about this service, please contact Infrastructure at:
>> us...@infra.apache.org
>>
>>
>>
>
> --
>
> Jarek Potiuk
> Polidea  | Principal Software Engineer
>
> M: +48 660 796 129 <+48660796129>
> [image: Polidea] 
>
>

-- 

Jarek Potiuk
Polidea  | Principal Software Engineer

M: +48 660 796 129 <+48660796129>
[image: Polidea] 


Re: [GitHub] [airflow-client-go] mik-laj commented on pull request #1: Add generated go client

2020-06-30 Thread Jarek Potiuk
Just for everyone - by gitbox "suggestion" when creating the new "client"
repo I set "dev@" as commit notification. I am asking ingra to fix it.
Sorry for the spam!

On Tue, Jun 30, 2020 at 10:20 AM GitBox  wrote:

>
> mik-laj commented on pull request #1:
> URL:
> https://github.com/apache/airflow-client-go/pull/1#issuecomment-651636094
>
>
>> I couldn't find an option to include license header in all generated
> files in openapi-generator.
>
>You need to generate a client and then run another tool that will add
> the missing licenses. We use pre-commit to automatically add licenses in
> apache/airflow, but you can think of another alternative.  An alternative
> tool can be written in Python, Bash or be a completely external binary.
>
> https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml#L29-L129
>
>
> 
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>
>

-- 

Jarek Potiuk
Polidea  | Principal Software Engineer

M: +48 660 796 129 <+48660796129>
[image: Polidea] 


[GitHub] [airflow-client-go] mik-laj commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox


mik-laj commented on pull request #1:
URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651638355


   @gerardo  We're already working to fix it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [airflow-client-go] mik-laj commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox


mik-laj commented on pull request #1:
URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651636094


   > I couldn't find an option to include license header in all generated files 
in openapi-generator.
   
   You need to generate a client and then run another tool that will add the 
missing licenses. We use pre-commit to automatically add licenses in 
apache/airflow, but you can think of another alternative.  An alternative tool 
can be written in Python, Bash or be a completely external binary.
   
https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml#L29-L129



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [airflow-client-go] mik-laj commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox


mik-laj commented on pull request #1:
URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651634016


   > I think the plan is just to make PR out of the generated code here but the 
tests will be executed still in the main airflow repo. That seems like most 
sensible thing to do IMHO - here we only publish changes that we test in 
Airflow during regular CI builds.
   
   I agree, but I'm afraid we may encounter a chicken and egg problem. CI may 
have problems generating differences between releases if we don't have the 
created first commit.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [airflow-client-go] mik-laj commented on pull request #1: Add generated go client

2020-06-30 Thread GitBox


mik-laj commented on pull request #1:
URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-651631792


   I am wondering about the lack of license headers, but I think we can do them 
later. The main thing is to do it before the release of the first version.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org