Re: [VOTE CANCELED] Airflow 1.10.1rc1

2018-11-14 Thread Beau Barker
+1 for putting the pre-releases on pypi, likely to get more testers this way. > On 15 Nov 2018, at 4:37 am, Ash Berlin-Taylor wrote: > > We've had two regressions against this release reported in Slack so I'm > cancelling this vote, to re-open a new one once these two PRs are merged: > >

[VOTE] Airflow 1.10.1 RC2

2018-11-14 Thread Ash Berlin-Taylor
Hey all, I have cut Airflow 1.10.1 RC2. This email is calling a vote on the release, which will last for 72 hours. Consider this my (binding) +1. Airflow 1.10.1 RC2 is available at: https://dist.apache.org/repos/dist/dev/incubator/airflow/1.10.1rc2/

Re: Customised alerts/notifications and enhancements to alerting/notifications on Airflow

2018-11-14 Thread Sai Phanindhra
Above mentioned PR address issues/bugs in current functionality. I want to add more mediums of alerting which includes SLA. On Wed, 14 Nov 2018 at 20:51, airflowuser wrote: > There is a pending PR to refactor the SLA: > https://github.com/apache/incubator-airflow/pull/3584 > > But it requires

Customised alerts/notifications and enhancements to alerting/notifications on Airflow

2018-11-14 Thread Sai Phanindhra
Hello airflow committers and maintainers, I came across sla in airflow. It's a very good feature to begin with. I feel like few enhancements can be done. These enhancements are not limited to just sla, they basically are voids i felt when im using airflow. Im listing few of them here.

Re: Customised alerts/notifications and enhancements to alerting/notifications on Airflow

2018-11-14 Thread airflowuser
There is a pending PR to refactor the SLA: https://github.com/apache/incubator-airflow/pull/3584 But it requires more reviews from committers. Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Wednesday, November 14, 2018 5:11 PM, Sai Phanindhra wrote: > Hello airflow

Re: [VOTE CANCELED] Airflow 1.10.1rc1

2018-11-14 Thread Ash Berlin-Taylor
We've had two regressions against this release reported in Slack so I'm cancelling this vote, to re-open a new one once these two PRs are merged: https://github.com/apache/incubator-airflow/pull/4186 https://github.com/apache/incubator-airflow/pull/4187 Committeers: if you could look at the PRs

Re: Customised alerts/notifications and enhancements to alerting/notifications on Airflow

2018-11-14 Thread James Meickle
FYI I am on the Airflow Slack but only check it on weekends mostly. Here is a gist with my implementation of a Slack callback, which attaches icons/buttons/emoji/etc.: https://gist.github.com/Eronarn/99408c0e5b0dd964487a5eea64b34f6d On Wed, Nov 14, 2018 at 1:54 PM Sai Phanindhra wrote: >

Re: Customised alerts/notifications and enhancements to alerting/notifications on Airflow

2018-11-14 Thread James Meickle
As the author of the first linked PR, I think your points are good. Here is my attempt to address them: 1: It is possible to do this today if you write a Slack callback. I would be happy to share my code for this if you're having trouble integrating Slack. That being said, it would be great if

Re: Customised alerts/notifications and enhancements to alerting/notifications on Airflow

2018-11-14 Thread Niels Zeilemaker
I had a go once to introduce something similar, but never got it merged. Maybe you can use it as an inspiration. https://github.com/apache/incubator-airflow/pull/2412 Niels Op wo 14 nov. 2018 16:43 schreef Sai Phanindhra Above mentioned PR address issues/bugs in current functionality. I want

Re: [VOTE CANCELED] Airflow 1.10.1rc1

2018-11-14 Thread Bolke de Bruin
You need to wait 72h and until you have 3+ votes. Satisfy both conditions :-) On putting things on pypi I'm personally in favor. It's not an Apache channel thus not official. On the other hand Apache is Java focused and only understands SNAPSHOTS but that's essentially the same as this. B.

Re: Customised alerts/notifications and enhancements to alerting/notifications on Airflow

2018-11-14 Thread Sai Phanindhra
Thanks James for the input. For the problems i specified above, i build hacky solutions like adding one `*slack_start_notification_operation*` in beginning, ` *slack_end_notification_operator*` in the end and ` *slack_failed_notification_operation*` when upstream fails. This addresses first 3

Fusing operators together

2018-11-14 Thread Shubham Gupta
*[Please let me know if this is NOT the correct place for such a query]* Hello maintainers and committers, I've stumbled upon this design decision for my Airflow project. Any pointers would be helpful. Overview - I'm in the process of deploying Airflow and I've felt the need to merge