- **status**: review --> closed
---
** [tickets:#8117] Implement core 2FA**
**Status:** closed
**Milestone:** unreleased
**Labels:** security
**Created:** Mon Aug 15, 2016 03:54 PM UTC by Dave Brondsema
**Last Updated:** Thu Sep 01, 2016 07:44 PM UTC
**Owner:** Dave Brondsema
This ticket
Visual polish, notifications, test coverage, and general improvements all look
good. Clear to merge IMO.
---
** [tickets:#8117] Implement core 2FA**
**Status:** review
**Milestone:** unreleased
**Labels:** security
**Created:** Mon Aug 15, 2016 03:54 PM UTC by Dave Brondsema
**Last
Thanks, Kenton.
I have pushed several more commits just now that include email notifications,
and visual cleanup. That covers everything I was planning on for this ticket.
---
** [tickets:#8117] Implement core 2FA**
**Status:** review
**Milestone:** unreleased
**Labels:** security
As a first rev, this is looking solid in my view.
---
** [tickets:#8117] Implement core 2FA**
**Status:** review
**Milestone:** unreleased
**Labels:** security
**Created:** Mon Aug 15, 2016 03:54 PM UTC by Dave Brondsema
**Last Updated:** Wed Aug 31, 2016 07:06 PM UTC
**Owner:** Dave
- **status**: in-progress --> review
- **Comment**:
First pass of this is available in branch `db/8117`. There is some polish and
email notifications I want to do for sure, and possibly some logic changes.
* you'll need to run `pip install -r requirements.txt` to get new packages (do
this
Some nuances to consider:
Bitbucket requires 2FA resubmission to view/update settings, not just password
reconfirmation.
Reconfiguration vs (re)adding a phone with the same key as before.
* GitHub says "You’re about to change your two-factor authentication device.
This will invalidate your
