[allura:tickets] #8214 Compute merge request commits in background
- **status**: review --> closed - **Comment**: Merged. --- ** [tickets:#8214] Compute merge request commits in background** **Status:** closed **Milestone:** unreleased **Labels:** performance **Created:** Fri Jun 29, 2018 08:56 PM UTC by Dave Brondsema **Last Updated:** Mon Jul 02, 2018 06:03 PM UTC **Owner:** Dave Brondsema We added caching to merge requests' list of commits previously (`allura.model.repository.MergeRequest#commits`). But it still can sometimes be slow the very first time. This is particularly a problem when creating the merge request and there's been no chance for it to get cached. * if 'commits' are available (cached), show them on the page just like we do now * if they aren't, return the page without them. * start a background task to get them * use ajax to fetch the bg tasks results when complete, and insert them into the page There is a similar pattern in place already for seeing if the commits are cleanly mergeable (see "merge_task_status") --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8214 Compute merge request commits in background
- **status**: in-progress --> review - **Comment**: Done on db/8214 Note: when logged in as an admin, you'll see one-click merge button and the bg checks happening for that too. Doing a merge-request as a non-admin user will be a more common scenario. To simulate a very slow task, you can stop `taskd` processes before submitting the merge request, and then start them again a bit later. --- ** [tickets:#8214] Compute merge request commits in background** **Status:** review **Milestone:** unreleased **Labels:** performance **Created:** Fri Jun 29, 2018 08:56 PM UTC by Dave Brondsema **Last Updated:** Fri Jun 29, 2018 08:56 PM UTC **Owner:** Dave Brondsema We added caching to merge requests' list of commits previously (`allura.model.repository.MergeRequest#commits`). But it still can sometimes be slow the very first time. This is particularly a problem when creating the merge request and there's been no chance for it to get cached. * if 'commits' are available (cached), show them on the page just like we do now * if they aren't, return the page without them. * start a background task to get them * use ajax to fetch the bg tasks results when complete, and insert them into the page There is a similar pattern in place already for seeing if the commits are cleanly mergeable (see "merge_task_status") --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8214 Compute merge request commits in background
--- ** [tickets:#8214] Compute merge request commits in background** **Status:** in-progress **Milestone:** unreleased **Labels:** performance **Created:** Fri Jun 29, 2018 08:56 PM UTC by Dave Brondsema **Last Updated:** Fri Jun 29, 2018 08:56 PM UTC **Owner:** Dave Brondsema We added caching to merge requests' list of commits previously (`allura.model.repository.MergeRequest#commits`). But it still can sometimes be slow the very first time. This is particularly a problem when creating the merge request and there's been no chance for it to get cached. * if 'commits' are available (cached), show them on the page just like we do now * if they aren't, return the page without them. * start a background task to get them * use ajax to fetch the bg tasks results when complete, and insert them into the page There is a similar pattern in place already for seeing if the commits are cleanly mergeable (see "merge_task_status") --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
