Re: [PR] AMBARI-26591: Pin form2js to v2.0 to fix WF Manager build failure caused by wildcard dependency resolution [ambari]
dilrajsourabh commented on PR #4116: URL: https://github.com/apache/ambari/pull/4116#issuecomment-5384231019 Hi @maxatwork ,thanks for the clarification, and for checking the codebase. You're right — form2js was only listed in bower.json and imported in ember-cli-build.js, with no actual usage anywhere in the WF Manager UI. I've updated the PR accordingly: - Removed the form2js dependency from bower.json - Removed the unused import from ember-cli-build.js This should fully address the build failure without depending on the upstream repo at all. The change is pushed in commit 8c31f68c70. Could you please merge this when you get a chance? Thanks again for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] AMBARI-26591: Pin form2js to v2.0 to fix WF Manager build failure caused by wildcard dependency resolution [ambari]
maxatwork commented on PR #4116: URL: https://github.com/apache/ambari/pull/4116#issuecomment-5382464855 Oh, my bad. I revived it around February and moved the old version to the 'legacy' branch. I honestly didn't expect anyone to still depend on the repo like that. I checked the Ambari codebase though, and it looks like form2js isn't actually used anywhere besides being imported. So rather than pinning it to v2.0, I think the better fix would be to remove the dependency and the import entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] AMBARI-26591: Pin form2js to v2.0 to fix WF Manager build failure caused by wildcard dependency resolution [ambari]
Sourabh-Dilraj commented on PR #4116: URL: https://github.com/apache/ambari/pull/4116#issuecomment-4913923349 @iRakson , can you please help in reviewing and merging this changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] AMBARI-26591: Pin form2js to v2.0 to fix WF Manager build failure caused by wildcard dependency resolution [ambari]
dilrajsourabh opened a new pull request, #4116: URL: https://github.com/apache/ambari/pull/4116 ## What changes were proposed in this pull request? This PR pins the form2js dependency to a fixed version (maxatwork/form2js#v2.0) in contrib/views/wfmanager/src/main/resources/ui/bower.json. Previously, "form2js": "*" resolved to the latest tag, which recently changed and no longer contains the expected src/form2js.js structure required by Ambari. Pinning the version restores the expected folder layout and prevents the ENOENT build failure. ## How was this patch tested? (Please explain how this patch was tested. Ex: unit tests, manual tests) (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this) Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
