Re: [VOTE] add FreeBuilder to Ambari

2018-03-21 Thread Jonathan Hurley
I agree - you can move mine to a -1 ... I'm having plenty of problems with FreeBuilder in Eclipse. > On Mar 20, 2018, at 8:20 PM, Doroszlai, Attila wrote: > > Let's close this vote: > > +1: Balazs Bence Sari, Attila Doroszlai > 0: Nate Cole, Jonathan Hurley > -1: Attila

Re: [VOTE] add FreeBuilder to Ambari

2018-03-20 Thread Doroszlai, Attila
Let's close this vote: +1: Balazs Bence Sari, Attila Doroszlai 0: Nate Cole, Jonathan Hurley -1: Attila Magyar, Robert Levas Since most developers didn't express any opinion, but would be affected by the change, I take your silence as a "no". I'll go ahead and remove the library from the

Re: [VOTE] add FreeBuilder to Ambari

2018-03-06 Thread Robert Levas
-1. I hate to squash other engineers ideas, but it seems that the advantages this package brings to the table does not outweigh the disadvantages. I agree with others that posts to this thread about requiring an IDE to rely on a third-party tool to generate code. If something breaks, we are

Re: [VOTE] add FreeBuilder to Ambari

2018-03-06 Thread Attila Magyar
I lean towards -1 a bit. It looks to me that this tool solves a not too difficult problem but solves it in a not too ideal way. And it’s hard to predict what will be the implications of using this in the long run. Builders can be generated by IntelliJ or written by hand quite easily. Although

Re: [VOTE] add FreeBuilder to Ambari

2018-03-06 Thread Jonathan Hurley
0 - I am indifferent as well, but I remain cautious about integrating 3rd party build assistants into our ecosystem. Unlike using a library, this is something that is required for our IDEs to be compatible with. A change to an IDE or even JDK version could potentially cause the JAR to no longer

Re: [VOTE] add FreeBuilder to Ambari

2018-03-06 Thread Nate Cole
0 - I’m indifferent to this, but would like to understand the need. Is this to gain convenience for equals(), hashCode(), toString() and the like or does Ambari face a real problem that this is addressing? On 3/3/18, 7:17 AM, "Balazs Bence Sari" wrote: +1

Re: [VOTE] add FreeBuilder to Ambari

2018-03-03 Thread Balazs Bence Sari
+1 On 3/2/18, 17:57, "Doroszlai, Attila" wrote: >Hi all, > >I'd like to start a vote on adding the FreeBuilder library to Ambari. > >FreeBuilder is an annotation processor that generates (at compile >time) immutable value objects and their builders from interfaces or