AW: [VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-05 Thread jhm
+1 Jan > -Ursprüngliche Nachricht- > Von: Stefan Bodewig [mailto:bode...@apache.org] > Gesendet: Samstag, 3. Februar 2018 18:07 > An: dev@ant.apache.org > Betreff: [VOTE] Release Apache Ant 1.10.2 based on RC1 > > Hi all > > I've created a release candidate for 1.10.2: > > git tag:

AW: [VOTE] Release Ant 1.9.10 based on RC1

2018-02-05 Thread jhm
estMagicPropertyIso Expected property 'DSTAMP' to have value '19720417' but was '20180205' tstamp-test_xml:testMagicPropertyBoth Expected property 'DSTAMP' to have value '19720417' but was '19700102' ownedby-test_xml:testRequiresOwner Expect

Re: [VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-05 Thread Gintautas Grigelionis
1.10.2 must contain the corrected fetch.xml Now that we take Java 9 into account, should we add Automatic-Module-Name to all manifests? Gintas 2018-02-05 11:38 GMT+01:00 Jan Matèrne (jhm) : > +1 > Jan > > > -Ursprüngliche Nachricht- > > Von: Stefan Bodewig

Re: [VOTE] Release Ant 1.9.10 based on RC1

2018-02-05 Thread Gintautas Grigelionis
trequired=true" with Java8 on Win7 > -- 4 AntUnit tests are failing > setpermissions-test_xml:testRequiresNestedResources > Expected build failure with message 'At least one > resource-collection is required' > but was 'Problem: failed to cre

Re: [VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-05 Thread Jaikiran Pai
+1. - Downloaded the .tar.gz and installed locally. Setup ANT_HOME to this new version. - Ran some existing projects against this new version - Checked some documentation in the manual. Tested the projects using this version of Ant against both Java 8 and Java 9. -Jaikiran On 03/02/18

[GitHub] ant-ivy issue #62: IVY-1572 - Check for Thread interruption while resolving ...

2018-02-05 Thread apupier
Github user apupier commented on the issue: https://github.com/apache/ant-ivy/pull/62 Seems that there was an issue with the Jenkins webhook. Jan Matèrne mentioned that the build was in success

Re: [VOTE] Release Ant 1.9.10 based on RC1

2018-02-05 Thread Maarten Coene
+1 We did test this version in our environment, no issues were found. Maarten Van: Stefan Bodewig Aan: dev@ant.apache.org Verzonden: zaterdag 3 februari 17:32 2018 Onderwerp: [VOTE] Release Ant 1.9.10 based on RC1 Hi all I've created a release candidate for

[GitHub] ant issue #58: Use StringBuilder instead of StringBuffer as it offers high p...

2018-02-05 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/58 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...

2018-02-05 Thread reudismam
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/58 Use StringBuilder instead of StringBuffer as it offers high performan… …ce in single thread places as it is generally the case. You can merge this pull request into a Git repository by running:

[GitHub] ant issue #58: Use StringBuilder instead of StringBuffer as it offers high p...

2018-02-05 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/58 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

Re: [VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-05 Thread Gintautas Grigelionis
Houston, we have a problem: JPMS explicitly forbids broken packages. Currently: - apache-oro.jar and apache-regexp.jar are in the same package (org.apache.tools.ant.util.regexp) which is also present in ant.jar and ant-testutil.jar - ant-commons-logging.jar and ant-apache-log4j.jar

Re: [VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-05 Thread Stefan Bodewig
On 2018-02-05, Gintautas Grigelionis wrote: > Houston, we have a problem: JPMS explicitly forbids broken packages. I was about to answer this to your Automatic-Module-Name question. Ant's jar can never be Java9 modules. If we wanted them to be modules, we'd have to move classes and seriously

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-05 Thread Jaikiran Pai
I agree. -1. On a related note, I don't think we should be doing any of these commits especially when there's a RC out which we plan to release. IMO, only blocker issues need to be addressed when the RC is out. -Jaikiran On 06/02/18 1:41 AM, Stefan Bodewig wrote: Generate manifest files

[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...

2018-02-05 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/58#discussion_r166183671 --- Diff: src/main/org/apache/tools/ant/taskdefs/Parallel.java --- @@ -377,7 +377,7 @@ public synchronized void run() { } // now

[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...

2018-02-05 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/58#discussion_r166183611 --- Diff: src/main/org/apache/tools/ant/listener/MailLogger.java --- @@ -102,7 +102,7 @@ private static final String DEFAULT_MIME_TYPE = "text/plain";

[GitHub] ant issue #58: Use StringBuilder instead of StringBuffer as it offers high p...

2018-02-05 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/58 Overall, IMO, this can't be a general find/replace change and instead needs to be checked for individuals places where the `StringBuffer` is used and whether the change to `StringBuilder` will impact

[GitHub] ant issue #57: Make junitreport with Saxon

2018-02-05 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/57 @adamretter The test failure https://builds.apache.org/job/Ant%20Github-PR-Windows/37/testReport/junit/org.apache.tools.ant.taskdefs.optional.junit/XMLResultAggregatorTest/testFrames/ looks related to

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-05 Thread Stefan Bodewig
> Generate manifest files and add automatic module names for JPMS -1 please remove the Automatic-Module-Name attributes as our jars are no proper JPMS modules. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-05 Thread Gintautas Grigelionis
Besides, we can move classes and build an apache-bwc.jar that contains placeholders and/or deprecated classes. ScriptRunner is a good example of that. Gintas 2018-02-05 21:38 GMT+01:00 Gintautas Grigelionis : > I adjusted the proposal and I hope that I addressed your

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-05 Thread Gintautas Grigelionis
I adjusted the proposal and I hope that I addressed your criticism. Most of the non-JPMS stuff is deprecated anyway, we need maybe decide what to do with BCEL support. Gintas 2018-02-05 21:11 GMT+01:00 Stefan Bodewig : > > > Generate manifest files and add automatic module

Re: [VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-05 Thread Gintautas Grigelionis
2018-02-05 21:02 GMT+01:00 Stefan Bodewig : > On 2018-02-05, Gintautas Grigelionis wrote: > > > Houston, we have a problem: JPMS explicitly forbids broken packages. > > Ant's jar can never be Java9 modules. If we wanted them to be modules, > we'd have to move classes and