Re: ant git commit: Yet more isEmpty()

2018-04-15 Thread Stefan Bodewig
On 2018-04-15, wrote: > @@ -275,10 +270,7 @@ public class DefaultLogger implements BuildLogger { > new BufferedReader(new > StringReader(event.getMessage( { > message.append(r.lines().map(line -> prefix + line) > -

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-15 Thread Gintautas Grigelionis
2018-04-15 9:59 GMT+00:00 Stefan Bodewig : > On 2018-04-15, Gintautas Grigelionis wrote: > > > Could you please explain what alternative approach does the "root" > > property support > > It has been added with >

Bug report for Ant [2018/04/15]

2018-04-15 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

[GitHub] ant pull request #:

2018-04-15 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28586872 In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java: In

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-15 Thread Gintautas Grigelionis
2018-04-14 16:23 GMT+00:00 Stefan Bodewig : > On 2018-04-13, Gintautas Grigelionis wrote: > > > 2018-04-13 5:33 GMT+00:00 Stefan Bodewig : > > >> Ant test cases are not designed to be run from an IDE, this has never > >> been a goal. I'm surprised this

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-15 Thread Stefan Bodewig
On 2018-04-15, Gintautas Grigelionis wrote: > Could you please explain what alternative approach does the "root" > property support It has been added with https://github.com/apache/ant/commit/71333195c9d57d80d1a44cd8362a641c62d5e214 and the commit message states the main use case "running tests

Re: [VOTE] Ivy 2.5.0-rc1 Release

2018-04-15 Thread Nicolas Lalevée
> Le 14 avr. 2018 à 19:02, Stefan Bodewig a écrit : > > On 2018-04-12, Nicolas Lalevée wrote: > >> I have built a release candidate for Ivy 2.5.0-rc1. > >> The git tag of this release is: >>

[GitHub] ant pull request #:

2018-04-15 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28589786 In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java: In

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-15 Thread Stefan Bodewig
On 2018-04-15, Gintautas Grigelionis wrote: > Moreover, the refactoring of tests is not about extracting repetitive > code into "smart" methods; it's about parameterizing -- which is > another nice thing about JUnit 4 -- and we'll be getting to that. If we could get there with diff smaller than

Re: [VOTE] Ivy 2.5.0-rc1 Release

2018-04-15 Thread Stefan Bodewig
On 2018-04-15, Nicolas Lalevée wrote: >> Le 14 avr. 2018 à 19:02, Stefan Bodewig a écrit : >>> Do you vote for the release of these binaries? >> +1 >> If you want to call them 2.5.0-rc1. If you want the release to be 2.5.0 >> then the names of the archives and the jars are

[GitHub] ant pull request #:

2018-04-15 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28590563 In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java: In

[GitHub] ant pull request #:

2018-04-15 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28590841 In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java: In

JUnit 5 tests incorrectly picked up during Ant junit tests

2018-04-15 Thread Jaikiran Pai
It indeed looks like a build exclusion that I might have missed. I will take a look at this and fix it. -Jaikiran On 15/04/18 9:35 PM, Stefan Bodewig wrote: On 2018-04-15, Gintautas Grigelionis wrote: By the looks of it, JUnit 5 runner tests need an assumption check, too. Not sure why,