GitHub user ernisv opened a pull request:
https://github.com/apache/ant-ivy/pull/4
Optimization: limit the revision numbers scanned if revision prefix is
specified
I was investigating slow performance of ivy:buildnumber task. Turned out it
was slow because descriptor was optional on resolver configurations, so in
addition to ivy descriptors, jar artifacts were being checked
(AbstractPatternsBasedResolver:175) and separate HTTP requests were being made
for every single revision to resolve the [artifact] token from the artifact
pattern
http://localhost:8081/artifactory/evrepov/[organization]/[module]/[revision]/[type]s/[artifact]-[revision].[ext].
Currently remaining tokens are unnecessarily being resolved for every
revision even when revision prefix is specified on ivy:buildnumber, although
this gives opportunity for significant optimization.
This is the patch to limit the remaining token resolutions only to
revisions matching the revision prefix specified in buildnumber.
I was having a few JUnit test failures with clean source tree from master
for some reason - this patch does not increase JUnit failure count, but this is
probably something to be checked by someone more familiar with the project.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ernisv/ant-ivy master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant-ivy/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 1689232e16ad4b3e763ae86b6af212faf1b761d3
Author: Ernestas Vaiciukevicius <ern...@gmail.com>
Date: 2014-12-26T12:22:23Z
Optimization: limit the revision numbers scanned if revision prefix is
specified
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
