GitHub user jwadamson opened a pull request:
https://github.com/apache/ant/pull/2
fix incorrect attribute in the Zip Task documentation
I copied this example to add to a build file, and it exploded. The correct
attribute is visible in the example immediately preceding this one
Github user jwadamson closed the pull request at:
https://github.com/apache/ant/pull/2
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user jwadamson opened a pull request:
https://github.com/apache/ant/pull/14
Bug 58874: Ant fails to run if ANT_HOME contains a double-quote character
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwadamson/ant-1 master
Github user jwadamson commented on the pull request:
https://github.com/apache/ant/pull/14#issuecomment-172326875
Looks likeant_exec_args would be a more complicated fix. I'll leave that
for another patch as it probably should be considered a separate issue anyway.
(to executing `ant
Github user jwadamson commented on the pull request:
https://github.com/apache/ant/pull/14#issuecomment-172286640
ant_exec_args also looks suspicious with regards to values that contain
double-quotes. Probably need to experiment with that
---
If your project is set up for it, you
Github user jwadamson commented on the issue:
https://github.com/apache/ant/pull/24
and apparently bash built-in echo also interprets sequences in arguments.
That is sort of my concern too. We may need to detect platforms and have
different expressions. Using personal mac now
Github user jwadamson commented on the issue:
https://github.com/apache/ant/pull/24
I see a couple options:
1) we can continue playing with sed, but probably should use `printf '%s'
"$X"` instead of echo to pipe the input to avoid issues with trailing newlines
Github user jwadamson commented on the issue:
https://github.com/apache/ant/pull/24
playing with this alternate impl for now. So far works with dash and ksh
and a torture parameter:
$ ./bin/ant --execdebug run
"-Dfoo=dollar\$backtick\`single'double\"
Github user jwadamson commented on the issue:
https://github.com/apache/ant/pull/24
Solaris is not my expertise either.
The attachment
https://bz.apache.org/bugzilla/attachment.cgi?id=34221=diff looks
reasonable.
So it is wrapping each $arg with double-quotes
Github user jwadamson commented on the issue:
https://github.com/apache/ant/pull/24
I hate dealing with arbitrary arguments. Those regex expressions still
don't feel 100% comfortable to me as to even why they seem to work. Trial and
error is not a good way to figure out patterns
Github user jwadamson commented on the issue:
https://github.com/apache/ant/pull/24
I think dash may not support that substitution pattern :-( Still
investigating
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jwadamson opened a pull request:
https://github.com/apache/ant/pull/23
fix 60150 values containing backtick character cause shell error on *nix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwadamson/ant-1 fix
Github user jwadamson closed the pull request at:
https://github.com/apache/ant/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jwadamson opened a pull request:
https://github.com/apache/ant/pull/24
fix 60150 values containing backtick or $ character cause shell errorâ¦
⦠on *nix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwadamson/ant
Github user jwadamson commented on the issue:
https://github.com/apache/ant/pull/24
Thanks, will try to find the threads on mailing list. Still making
improvments, fixed an issue with mac sed that it doesn't support group-0.
Annoying. Also finally figured out why so many backslashes
Github user jwadamson commented on the issue:
https://github.com/apache/ant/pull/24
Oh, and the final two lines of ant script needed quotes to preserve
intra-argument whitespace properly
--Jeff
On Mon, Oct 10, 2016 at 3:36 PM, Jeff Adamson <jwa
Github user jwadamson commented on the issue:
https://github.com/apache/ant/pull/24
So I think I figured out some of this in terms of why escaping was so funny.
Also found an issue with sed on mac (no group-0 reference) in my earlier
fix.
The bash variable replacement
GitHub user jwadamson opened a pull request:
https://github.com/apache/ant/pull/25
fix problems with argument handling of trailing space and sed/echo quirks
So this is where I have landed through trial and error on improving the
argument handling code.
Tested
GitHub user jwadamson opened a pull request:
https://github.com/apache/ant/pull/26
corrected comments
Finally figured out why some behaviors were present. Originally thought sed
was trimming whitespace in its output.
I had not known that subshell output capture via either
Github user jwadamson commented on the issue:
https://github.com/apache/ant/pull/24
Will have another attempt at this later today. So far tested on ubunutu
ksh, bash, dash as the bin/sh.
Will try to get a true solarus and mac platforms to test since this is what
led to back
GitHub user jwadamson opened a pull request:
https://github.com/apache/ant/pull/29
detect solaris 10 to avoid certain POSIX expressions
Another attempt at fixing for solaris without regressing POSIX platforms.
1) use `uname` to detect solaris 10 platform. Could not figure
Github user jwadamson commented on the issue:
https://github.com/apache/ant/pull/25
It seems not. :-(
Solaris, when matching posix spec isn't enough.
I'm going to try to get up to speed on current state if I can. This is just
maddening.
---
If your project is set up
22 matches
Mail list logo
