[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 The new method is taken from `AbstractOSGiResolver` where a corresponding method is made public. All resolvers implement only the new method and the fallback for the deprecated method is moved

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 BTW, the old method is still there, the implementation is in the abstract class, `AbstractResolver`. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-08-02 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 Thanks for clarifying. My point was that the use of the method is limited to two classes: `SearchEngine` and `ChainResolver` (because it is essentially a proxy). A quick search seems

[GitHub] ant-ivy issue #55: use vectorised logo

2017-08-01 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/55 This fixes https://issues.apache.org/jira/browse/IVY-922 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] ant-ivy issue #59: IVY-1566 - Store External form of URL in cached files

2017-08-11 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/59 If I'm not mistaken, one of the builds for #58 was aborted by @nlalevee -- something wrong with Jenkins? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] ant-ivy issue #58: IVY-1566 - Store External form of URL in cached files

2017-08-10 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/58 2.4.x branch seems not to be buildable, could you please open the PR against master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] ant-ivy issue #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/52 Thanks! I will revert the changes regarding the checked exceptions as suggested in a separate commit. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127408025 --- Diff: src/java/org/apache/ivy/tools/analyser/JarJarDependencyAnalyser.java --- @@ -39,21 +39,22 @@ public JarJarDependencyAnalyser(File jarjarjarLocation

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127474316 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination

[GitHub] ant-ivy pull request #:

2017-07-12 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/6f22f4b49c2a3a59840d28e6cbe0c37a56ab1f90#commitcomment-23069324 Neat! 👍 Perhaps it would make sense to ask asciidoctorj team to add support for inlined Ruby and ditto for asciidoctor-ant

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127480601 --- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java --- @@ -306,7 +306,7 @@ public boolean isClosedRange() { return startVersion.equals

[GitHub] ant-ivy issue #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/52 I committed proposed changes w/o contains(). Please let me know if should amend. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-18 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/53 Suppressed warnings As described in previous PR, all compiler warnings are annotated. This PR removes a few of them, along with some refactoring. Changes are grouped in separate commits which

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-09 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/52 Generics in core This is as far as I can get without significant changes to API. Any remaining points of contention are annotated by `@SuppressWarnings` (and I'm not proud of what `NoFilter

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-22 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 The code below apparently assumes that client 2.x might still be around; it is obsolete and this is a perfect opportunity to remove it ``` private HttpClientHelper getHttpClientHelper

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-21 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 VsftpRepository has DEFAULT_READ_TIMEOUT and DISCONNECT_COMMAND_TIMEOUT; would that require an additional timeout attribute? --- If your project is set up for it, you can reply to this email

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-25 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 Sorry for additions to PR. I figured out a way to remove the last inconsistencies with generics without breaking the API. This PR will not change any more. I rebased my commits; you're welcome

[GitHub] ant-ivy pull request #:

2017-07-25 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286714 In fact, there's a bunch of places where [Mm]aven2 is used... [asciidoc-maven.zip](https://github.com/apache/ant-ivy/files

[GitHub] ant-ivy pull request #:

2017-07-25 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286444 In asciidoc/tutorial/multiple.adoc, please replace Maven2 with Maven 2 for consistency 😃 --- If your project is set up

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-23 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 I'd rather have dropping support for 2.x up for vote a.s.a.p. because 3.x is [EOL](http://hc.apache.org/httpclient-3.x/) already. --- If your project is set up for it, you can reply to this email

[GitHub] ant-ivy pull request #55: use vectorised logo

2017-07-27 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/55 use vectorised logo I'd like to remove downloaded.gif, error.gif, evicted.gif and searched.gif as well. Maybe we could vote on colours for downloaded and evicted 😉 if green is too dark

[GitHub] ant-ivy pull request #:

2017-07-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23334637 Perhaps `UnsupportedOperationException` would be a useful heuristic? --- If your project is set up for it, you can reply

[GitHub] ant-ivy pull request #57: fix last inconsistencies in generics

2017-07-27 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/57 fix last inconsistencies in generics ... use collections, not arrays You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy consistent

[GitHub] ant-ivy pull request #:

2017-07-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23340291 Sorry for a terse suggestion, I meant we could provide more information to the end user about the symlink/symlinkmass now

[GitHub] ant-ivy pull request #:

2017-07-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/6607bdcb3ba69d2ab4f41be6292cc5a6df6365ba#commitcomment-23339716 In URLHandlerDispatcher, ``` @Override public void download(final URL src, final File dest, final

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-27 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 With all due respect, there are some refactorings worth attention IMHO. Besides, some deprecations need to be followed through 😉 --- If your project is set up for it, you can reply to this email

[GitHub] ant-ivy pull request #56: use “Maven 2” consistently

2017-07-27 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/56 use “Maven 2” consistently You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy maven-2-in-asciidoc Alternatively you can review

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129663139 --- Diff: src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java --- @@ -85,14 +85,12 @@ public LatestCompatibleConflictManager

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129668076 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -71,132 +71,139 @@ --- End diff -- Here's a "diff -wc&q

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129660986 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -71,132 +71,139 @@ --- End diff -- It's a change from

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 This is strange, all tests still pass for me locally -- could someone elucidate what the problem is, please? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 D'uh... getExtends() must respect insertion order -- array straitjacket 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 I'm sorry for not explaining the point with all the changes around foreach loops: they take anything that is iterable rather than an array (which Ivy is very fond of API-wise) and by doing so allow

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-21 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 The PR contains additional changes to HttpClientHandler, introducing HttpConnectionManagerParams, which is not available in Commons HTTP Client version 2 (over 10 years old and virtually gone

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-21 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 JSch Session has a single (connection) timeout. There is a GitHub project to mock ssh/sftp server based on Mina at https://github.com/shamsoftware/sham-ssh --- If your project is set up

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-06-30 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/48 Generics and Java 7 syntax in osgi and plugins packages These changes leave only core untouched. Generics are not applied where Java compiler is unhappy (arrays of generics). You can merge

[GitHub] ant-ivy pull request #50: Check spelling, fix whitespace and links

2017-06-30 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/50 Check spelling, fix whitespace and links Why can't we drop configuration* in asciidoc? You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant

[GitHub] ant-ivy issue #49: Aesthetic changes in .gitignore, build.xml and build-rele...

2017-07-01 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/49 This is a part of #50 now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] ant-ivy pull request #49: Aesthetic changes in .gitignore, build.xml and bui...

2017-07-01 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy pull request #49: Aesthetic changes in .gitignore, build.xml and bui...

2017-06-30 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/49 Aesthetic changes in .gitignore, build.xml and build-release.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy master

[GitHub] ant-ivy issue #48: Generics and Java 7 syntax in osgi and plugins packages

2017-07-03 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/48 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-03 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivyde pull request #:

2017-07-01 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivyde/commit/b048846233286ed9bb1ae7fbeab9ab3f58983189#commitcomment-22871013 Isn't Eclipse Oxygen Java 8 only? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] ant-ivy issue #45: Generics + foreach loops and Java 7 in util (except Filte...

2017-06-29 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/45 I'll put japicmp into a separate PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] ant-ivy pull request #45: Generics + foreach loops and Java 7 in util (excep...

2017-06-29 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy pull request #:

2017-08-05 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/9b2165894ef23247d658dd37e93161c1a59b1c65#commitcomment-23498086 What else must be done to remove it? Deprecate the class? Here's the [relevant discussion](http://www.mail-archive.com

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 The same applies to `ChainResolver` (which should check resolver type as suggested by @jaikiran); actually, all custom resolvers that do not extend `AbstractResolver` could be wrapped in chain

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 The methods in `AbstractResolver` must be defined the other way around: the default implementation of the method with new signature should call the method with the old signature. May I amend

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 Is this sufficient, or should I add an extra check in `ChainResolver` ``` if (resolver instanceof AbstractResolver || hasGenericMethod(resolver

[GitHub] ant-ivy issue #55: use vectorised logo

2017-08-08 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/55 This one seems to break a JIRA record for time of first response: 8+ hours 😄 Beat that! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] ant-ivy pull request #:

2017-08-08 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/a9dd1573eb0edbfa977da90dd3bcb1863451ec2a#commitcomment-23529287 Perhaps [this](https://stackoverflow.com/questions/3587071/disable-intellij-starred-package-imports) could be of use ð

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-08-07 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 @nlalevee, we already broke a few things by going Java 7 (and gained native symlinks 😉). For more examples, look at commons-lang3 breaking off commons-text and introducing escapeHtml3

[GitHub] ant-ivy pull request #:

2017-08-07 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/f4237388ea9b93278db12a43c9db9f18e51b6f7f#commitcomment-23518067 Good catch 👍 would you mind to have a look at 72b730fc, too? --- If your project is set up for it, you can reply

[GitHub] ant-ivy issue #59: IVY-1566 - Store External form of URL in cached files

2017-08-19 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/59 Please update your local repo, rebase and force push -- new commit will start a new build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-19 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/20 BasicURLHandler crashed... ":" need to be URL encoded? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-20 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/20 I can assure you that colon in version has NEVER have worked on Windows. Test case ``` import java.io.*; public class TestColonNTFS { public static void main(String[] args

[GitHub] ant-ivy pull request #32: A few loose bits in JUnit 4 migration

2017-05-26 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/32 A few loose bits in JUnit 4 migration This adds annotations that are missing, migrates example code and fixes whitespace You can merge this pull request into a Git repository by running: $ git

[GitHub] ant-ivy issue #32: A few loose bits in JUnit 4 migration

2017-05-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/32 Why is Jenkins lacking org.apache.tools.ant.util.ProcessUtil? Something wrong with Ant? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] ant-ivy issue #31: Convert tests to JUnit 4, clean up code

2017-05-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/31 I do 😃 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant-ivy issue #32: A few loose bits in JUnit 4 migration

2017-05-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/32 Jenkins build was complete an hour ago, but status on Github is still pending... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] ant-ivy issue #32: A few loose bits in JUnit 4 migration

2017-05-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/32 Unless I'm mistaken, `BuildFileRule` was available first in 1.9.5; `ProcessUtil` needs 1.9.4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-21 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/20 "Making something that worked previously on a specific platform in specific circumstances work again" is not a good argument, especially when the coverage of the test case is incomple

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-21 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/20 On the second thought, if PR changes the way to identify the system root, then the test cases should be specifically for that, not for parsing of versions with reserved/unsafe URL characters

[GitHub] ant-ivy pull request #33: More code cleanup

2017-05-27 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/33 More code cleanup Your janitor is here again 😃 This drops commons-lang as test dependency, removes unused imports, simplifies if's and corrects a bunch of misspellings. You can merge

[GitHub] ant-ivy pull request #36: Replace emma with jacoco

2017-05-29 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/36 Replace emma with jacoco This modernises the reporting of code coverage. Please try it out. NB! On macOS, it tickles https://bugs.openjdk.java.net/browse/JDK-8022291 which is harmless

[GitHub] ant-ivy issue #31: Convert tests to JUnit 4, clean up code

2017-05-25 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/31 Thanks for a nice summary and pointing out a paradigm that I did not investigate entirely. The essential work also included checking that all appropriate setUp() and tearDown() were public

[GitHub] ant-ivy pull request #31: Convert tests to JUnit 4, clean up code

2017-05-25 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/31 Convert tests to JUnit 4, clean up code JUnit 4 has primarily two benefits, clarity through annotations and more fine grained control of failures You can merge this pull request into a Git

[GitHub] ant-ivy issue #31: Convert tests to JUnit 4, clean up code

2017-05-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/31 I left a few `fail()`s where multiple assertions were made; I guess that requires a custom @Rule. Also, in `FileSystemResolverTest`, I moved `finally` blocks to `tearDown()`. Strangely

[GitHub] ant-ivy issue #36: Replace emma with jacoco

2017-05-30 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/36 JaCoCo "log" gets an extension ".data"; JaCoCo reports are generated when JUnit fails; Checkstyle rules sync'ed with Ant. Anything else? I found out tha

[GitHub] ant-ivy issue #36: Replace emma with jacoco

2017-05-30 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/36 P.S. Any suggestions about finding out which rules do not work in Checkstyle are much appreciated. I had to resort to trial and error. Also, Ant includes a [different variant](https

[GitHub] ant-ivy issue #36: Replace emma with jacoco

2017-05-30 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/36 By default, jacoco "log" gets extension ".exec"; I'd rather call it ".data". I can amend the PR later tonight. Could you please check your classpath for mul

[GitHub] ant-ivy issue #37: Don't pollute the source lib folder during ivy retrieval ...

2017-05-31 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/37 Thanks, could this PR be merged? Then I'll clean up #36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] ant-ivy issue #37: Don't pollute the source lib folder during ivy retrieval ...

2017-06-02 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/37 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant-ivy issue #36: Replace emma with jacoco

2017-06-02 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/36 There are reports about the "log" file getting corrupt when it accumulates results from multiple runs. If 'ant clean' helps, then perhaps the "log" file must be removed in test-in

[GitHub] ant-ivy issue #36: Replace emma with jacoco

2017-06-02 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/36 Thanks! BTW I had to keep the "test-coverage" target as an alias because that's what the Jenkins scripts expect. That's another adjustment for later... --- If your project is set up for i

[GitHub] ant-ivy pull request #39: first batch of SVG replacements

2017-06-02 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/39 first batch of SVG replacements Try them out and enjoy! The images have their width and height removed, scaling must be controlled by CSS. You can merge this pull request into a Git repository

[GitHub] ant-ivy pull request #41: Checkstyle

2017-06-03 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/41 Checkstyle Now that checkstyle rules are sync'ed with Ant, here come the consequences 😃 I guess the famous https://issues.apache.org/jira/browse/IVY-511 is due for an update... You can

[GitHub] ant-ivy issue #40: Fix regression in tutorials

2017-06-03 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/40 Thanks, I forgot to rebuild the snapshot before pushing the changes 😊 Perhaps it's worth mentioning in developer doc, which sorely needs revision now (another regression on my part

[GitHub] ant-ivy issue #39: first batch of SVG replacements

2017-06-03 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/39 I inlined warning icon; ideally, it should go into CSS as a data URI, but that belongs to xooki now... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] ant-ivy issue #41: Checkstyle

2017-06-03 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/41 Some of the SVGs are produced by directly by yEd. I guess they're the ones that miss "Generator". I'll check them and amend accordingly. --- If your project is set up for it, you

[GitHub] ant-ivy pull request #41: Checkstyle

2017-06-03 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy issue #41: Checkstyle

2017-06-03 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/41 Sorry about the mess, #41 got conflated with #39. It's due my inexperience, #39 is on master and #41 is on a branch of it's own in my repo. --- If your project is set up for it, you can reply

[GitHub] ant-ivy issue #39: first batch of SVG replacements

2017-06-03 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/39 Sorry about messing around, I removed execute bits on several test files and that ended up in #39, too. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] ant-ivy issue #36: Replace emma with jacoco

2017-06-01 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/36 Revised accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant-ivy pull request #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread twogee
GitHub user twogee reopened a pull request: https://github.com/apache/ant-ivy/pull/43 Generics and other fixes in tests and tutorials foreach loops are more terse than iterators, and they go well together with generic -- here's the first stab 😃 You can merge this pull request

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/43 Thank you for comments, I'll split the PR and correct according to your suggestions. Should I remove common-colections altogether and use collections with generics from Java runtime? --- If your

[GitHub] ant-ivy pull request #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy pull request #45: Generics + foreach loops and Java 7 in util (excep...

2017-06-15 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/45 Generics + foreach loops and Java 7 in util (except Filter) Sorry for another largish commit, but I don't see much sense splitting it, either. You can merge this pull request into a Git repository

[GitHub] ant-ivy pull request #43: Generics and other fixes in tests and tutorials

2017-06-10 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/43 Generics and other fixes in tests and tutorials foreach loops are more terse than iterators, and they go well together with generic -- here's the first stab 😃 You can merge this pull request

[GitHub] ant-ivy issue #43: Generics and related fixes in tests and tutorials

2017-06-14 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/43 That's exactly why I introduced assertNotNull :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] ant-ivy issue #43: Generics and related fixes in tests and tutorials

2017-06-14 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/43 Sorry for getting carried away with diamonds 😃... I put back `assertFalse(moduleId.equals(null));` but that assertion is equivalent to `assertFalse(null instanceOf ModuleId)` which

[GitHub] ant-ivy issue #45: Generics + foreach loops and Java 7 in util (except Filte...

2017-06-18 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/45 I pushed new commits which ended up in this PR 😈 This adds more generics in ant and tools, only core and plugins left 😃 To dispel all scares about generics I added a binary

[GitHub] ant-ivy issue #43: Generics and related fixes in tests and tutorials

2017-06-14 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/43 I mean, why use an NPE when one can have an assertion that fails? It's a cleaner approach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/43 Here comes a bunch of new changes: I had to go for Commons Collections 4 to use generics, and threw in Commons CLI 1.4 for a good measure. I left HTTP Client 2.0 for the future lest this PR grows

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-19 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/20 I am afraid that Ivy allows for a misfeature here. Note that you must test this on Windows because colon is not allowed in NTFS filenames: https://kb.acronis.com/content/39790 --- If your project

[GitHub] ant-ivy pull request #42: Checkstyle redux

2017-06-05 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/42 Checkstyle redux Hopefully the last batch of whitespace changes... You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy master

[GitHub] ant-ivy pull request #:

2017-09-15 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/ab8b608744500c6af9933df5977a2aa054ac3c04#commitcomment-24318098 Is this Maven 2 or [Maven 3/Aether](http://maven.apache.org/aether.html

[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...

2017-08-30 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/60 use Unicode glyphs or SVG data URLs instead of bitmaps I put this up for review in case I missed some page that used the removed icons. You can merge this pull request into a Git repository

[GitHub] ant-ivy issue #55: use the vectorised logo

2017-09-25 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/55 logo.png is for CredentialsUtil; replaced by IvyLogo CSS contains changes for `#logo` and adds `svg.icon` (somehow Firefox cannot read dimensions from embedded SVGs) XSL generates

[GitHub] ant-ivy issue #59: IVY-1566 - Store External form of URL in cached files

2017-08-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/59 This is a bit off topic, but why are Jenkins builds still failing to find JaCoCo? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

  1   2   >