[GitHub] [ant] mataha commented on pull request #205: Fix `--release` param check in bootstrap.bat
mataha commented on PR #205: URL: https://github.com/apache/ant/pull/205#issuecomment-1722502639 The pleasure is mine! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] mataha commented on pull request #205: Fix `--release` param check in bootstrap.bat
mataha commented on PR #205: URL: https://github.com/apache/ant/pull/205#issuecomment-1722284523 These, of course, can be run on all Windows versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] mataha commented on pull request #205: Fix `--release` param check in bootstrap.bat
mataha commented on PR #205: URL: https://github.com/apache/ant/pull/205#issuecomment-1722247407 > Hello @mataha, what you propose here looks OK to me. However, I haven't been able to reproduce the issue that prompted this change. Is there some specific Windows version where this can be reproduced or how did you notice this issue? Hello, Try these minimal examples: ```batchfile cmd /d /y /c "echo "public class JavacVersionCheck {}" >check.java && javac check.java" ``` ```batchfile cmd /d /y /c "if %ERRORLEVEL% equ 0 echo Success." ``` As for how I've noticed the issue: I wanted to analyze the bootstrapping code (having come here from [Bootstrappable Builds](https://bootstrappable.org/best-practices.html)); as I write a lot of Batch scripts as a result of my hobby, the quotes in `echo` struck me as a red flag immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org