[GitHub] ant-ivy pull request #61: Use japicmp to check binary compatibility

2018-08-29 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/61 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #63: IVY-1486 respect exclude regardless of order

2018-08-14 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/63 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #74: Fix IVY-982 by removing negated entries from wildc...

2018-08-07 Thread aprelev
Github user aprelev closed the pull request at: https://github.com/apache/ant-ivy/pull/74 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #74: Fix IVY-982 by subtracting negated entries from wi...

2018-08-06 Thread aprelev
GitHub user aprelev opened a pull request: https://github.com/apache/ant-ivy/pull/74 Fix IVY-982 by subtracting negated entries from wildcard bin ### Issue Configurations negation (exclusion) as in `conf="*, !foo->@"` does not work, This issue is reported in

[GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...

2018-08-05 Thread aprelev
Github user aprelev closed the pull request at: https://github.com/apache/ant-ivy/pull/73 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...

2018-08-03 Thread aprelev
Github user aprelev commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/73#discussion_r207675516 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -193,16 +193,8 @@ public void startElement(String uri, String localName, String

[GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...

2018-08-03 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/73#discussion_r207669472 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -193,16 +193,8 @@ public void startElement(String uri, String localName, String

[GitHub] ant-ivy pull request #73: Enable XML report parser to produce qualified extr...

2018-08-01 Thread aprelev
GitHub user aprelev opened a pull request: https://github.com/apache/ant-ivy/pull/73 Enable XML report parser to produce qualified extra attributes ### Issue `${ivy.deps.changed}` is always `true` for dependencies with extra attributes. ### Problem

[GitHub] ant-ivy pull request #72: Test

2018-05-30 Thread smolamarcin
GitHub user smolamarcin opened a pull request: https://github.com/apache/ant-ivy/pull/72 Test You can merge this pull request into a Git repository by running: $ git pull https://github.com/smolamarcin/ant-ivy test Alternatively you can review and apply these changes as the

[GitHub] ant-ivy pull request #72: Test

2018-05-30 Thread smolamarcin
Github user smolamarcin closed the pull request at: https://github.com/apache/ant-ivy/pull/72 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-28 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177857645 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new

[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-28 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177696348 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new

[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-28 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177694759 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new

[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-28 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177694862 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new

[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...

2018-03-27 Thread aanno
GitHub user aanno opened a pull request: https://github.com/apache/ant-ivy/pull/71 Ivy main/standalone: Patch to include 'makepom' function Hello, I added the pomfile option to main/standalone. This allows creating an (maven) pom file from outside an ant task.

[GitHub] ant-ivy pull request #70: IVY-1321 Make Main.run() public

2018-03-21 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/70 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #70: Make Main.run() usable programmatically

2018-03-19 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/70 Make Main.run() usable programmatically Inspired by #69 You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy ivy-1321 Alternatively

[GitHub] ant-ivy pull request #69: 2.4.x

2018-03-18 Thread supertick
GitHub user supertick opened a pull request: https://github.com/apache/ant-ivy/pull/69 2.4.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/supertick/ant-ivy 2.4.x Alternatively you can review and apply these changes as the

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-03-15 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/67 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

AW: [GitHub] ant-ivy pull request #:

2018-03-06 Thread jhm
ilto:g...@git.apache.org] > Gesendet: Dienstag, 6. März 2018 18:24 > An: dev@ant.apache.org > Betreff: [GitHub] ant-ivy pull request #: > > Github user twogee commented on the pull request: > > https://github.com/apache/ant- > ivy/commit/8ed4a9bea706320d97ce2fd3e6545d7ebdf8

[GitHub] ant-ivy pull request #:

2018-03-06 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/8ed4a9bea706320d97ce2fd3e6545d7ebdf8a49b#commitcomment-27956300 I believe we're using asciidoc now? --- - To unsubscribe,

[GitHub] ant-ivy pull request #68: Why no new Ivy version yet?

2018-03-01 Thread chinhodado
Github user chinhodado closed the pull request at: https://github.com/apache/ant-ivy/pull/68 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-27 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r171054211 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- Ah, I get it... the way things

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-27 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r171053071 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- Good catch, thanks. BTW, run this

[GitHub] ant-ivy pull request #:

2018-02-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/1a19f2f836cd33a25d458ed8ba9bbb3c7ce4ff96#commitcomment-27816643 Could we do release and sign in one go by adding distributions to ivy.xml and using a separate filesystem resolver to copy and

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-18 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168989393 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- strange, thanks. As Ivy uses

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-18 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168964592 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- Yes. Invocation of Ant runs Ivy's

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-18 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168964407 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- to run which unit tests? Ivy's?

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-18 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168963965 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- If Ant (launcher and core) is

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-18 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168961676 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- why has this dependency been

[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...

2018-02-08 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/62#discussion_r167136873 --- Diff: src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java --- @@ -91,6 +91,9 @@ protected ResolvedResource

[GitHub] ant-ivy pull request #68: Why no new Ivy version yet?

2018-02-08 Thread chinhodado
GitHub user chinhodado opened a pull request: https://github.com/apache/ant-ivy/pull/68 Why no new Ivy version yet? I'm just making this PR because the mailing list is a pain to use and there's no issue tracker here on GitHub for the project...but why isn't there a new release for

[GitHub] ant-ivy pull request #66: IVY-1545 Detect circular dependencies in POMs

2018-02-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/66 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...

2018-02-06 Thread apupier
Github user apupier commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/62#discussion_r166349423 --- Diff: src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java --- @@ -91,6 +91,9 @@ protected ResolvedResource

[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...

2018-02-06 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/62#discussion_r166282397 --- Diff: src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java --- @@ -91,6 +91,9 @@ protected ResolvedResource

[GitHub] ant-ivy pull request #65: IVY-1485 Ensure dependency is applicable to all co...

2018-02-06 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/65 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

2018-02-02 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/67 IVY-1483 Invoke Ant through Ivy; like this: `java -jar ivy.jar -properties version.properties -main org.apache.tools.ant.Main` You can merge this pull request into a Git repository by running:

[GitHub] ant-ivy pull request #:

2018-02-02 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/7ebc8107a22038c06c0b0ff095f9f73d854e1422#commitcomment-27303399 And then there's `TestHelper.getCurrentAuthenticator()`... ---

[GitHub] ant-ivy pull request #66: IVY-1545 Detect circular dependencies in POMs

2018-02-02 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/66 IVY-1545 Detect circular dependencies in POMs You can merge this pull request into a Git repository by running: $ git pull https://github.com/javabrett/ant-ivy IVY-1545 Alternatively you can

[GitHub] ant-ivy pull request #65: IVY-1485 Ensure dependency is applicable to all co...

2018-02-01 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/65 IVY-1485 Ensure dependency is applicable to all configurations I adopted a patch by @tbingaman You can merge this pull request into a Git repository by running: $ git pull

[GitHub] ant-ivy pull request #64: IVY-1280 Support preemptive authentication

2018-02-01 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/64 IVY-1280 Support preemptive authentication I adopted a patch by @AurelienLourot You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy

[GitHub] ant-ivy pull request #63: IVY-1486 respect exclude regardless of order

2018-01-08 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/63 IVY-1486 respect exclude regardless of order You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy ivy-1486 Alternatively you can

[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...

2018-01-05 Thread apupier
GitHub user apupier opened a pull request: https://github.com/apache/ant-ivy/pull/62 IVY-1572 - Check for Thread interruption while resolving resources Signed-off-by: Aurélien Pupier You can merge this pull request into a Git repository by running: $ git

[GitHub] ant-ivy pull request #61: Use japicmp to check binary compatibility

2017-10-19 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/61 Use japicmp to check binary compatibility japicmp 0.11 has got an Ant task. It can as well be used for documenting the public API. Grouped related targets, too (moved `sources` closer to

[GitHub] ant-ivy pull request #:

2017-09-15 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/ab8b608744500c6af9933df5977a2aa054ac3c04#commitcomment-24318098 Is this Maven 2 or [Maven 3/Aether](http://maven.apache.org/aether.html)? ---

[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...

2017-08-31 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/60#discussion_r136417644 --- Diff: build-release.xml --- @@ -179,11 +180,11 @@ - + --- End diff -- Very

[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...

2017-08-31 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/60#discussion_r136327295 --- Diff: build-release.xml --- @@ -179,11 +180,11 @@ - + --- End diff --

[GitHub] ant-ivy pull request #53: suppressed warnings

2017-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...

2017-08-30 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/60 use Unicode glyphs or SVG data URLs instead of bitmaps I put this up for review in case I missed some page that used the removed icons. You can merge this pull request into a Git repository by

[GitHub] ant-ivy pull request #59: IVY-1566 - Store External form of URL in cached fi...

2017-08-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #59: IVY-1566 - Store External form of URL in cached fi...

2017-08-10 Thread apupier
GitHub user apupier opened a pull request: https://github.com/apache/ant-ivy/pull/59 IVY-1566 - Store External form of URL in cached files So hard to configure the project in my IvyIDE, cannot launch test individually so I abandoned the to search how to write a test. I

[GitHub] ant-ivy pull request #58: IVY-1566 - Store External form of URL in cached fi...

2017-08-10 Thread apupier
Github user apupier closed the pull request at: https://github.com/apache/ant-ivy/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #58: IVY-1566 - Store External form of URL in cached fi...

2017-08-10 Thread apupier
GitHub user apupier opened a pull request: https://github.com/apache/ant-ivy/pull/58 IVY-1566 - Store External form of URL in cached files So hard to configure the project in my IvyIDE, cannot launch test individually so I abandoned the to search how to write a test. I

[GitHub] ant-ivy pull request #:

2017-08-08 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/a9dd1573eb0edbfa977da90dd3bcb1863451ec2a#commitcomment-23529287 Perhaps [this](https://stackoverflow.com/questions/3587071/disable-intellij-starred-package-imports) could be of use 😃

[GitHub] ant-ivy pull request #:

2017-08-07 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/f4237388ea9b93278db12a43c9db9f18e51b6f7f#commitcomment-23518067 Good catch 👍 would you mind to have a look at 72b730fc, too? --- If your project is set up for it, you can reply to this

[GitHub] ant-ivy pull request #:

2017-08-05 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/9b2165894ef23247d658dd37e93161c1a59b1c65#commitcomment-23498086 What else must be done to remove it? Deprecate the class? Here's the [relevant

[GitHub] ant-ivy pull request #56: use “Maven 2” consistently

2017-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #:

2017-07-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23340291 Sorry for a terse suggestion, I meant we could provide more information to the end user about the symlink/symlinkmass now that

[GitHub] ant-ivy pull request #57: fix last inconsistencies in generics

2017-07-27 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/57 fix last inconsistencies in generics ... use collections, not arrays You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy

[GitHub] ant-ivy pull request #56: use “Maven 2” consistently

2017-07-27 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/56 use “Maven 2” consistently You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy maven-2-in-asciidoc Alternatively you can review

[GitHub] ant-ivy pull request #:

2017-07-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/6607bdcb3ba69d2ab4f41be6292cc5a6df6365ba#commitcomment-23339716 In URLHandlerDispatcher, ``` @Override public void download(final URL src, final File dest, final

[GitHub] ant-ivy pull request #:

2017-07-27 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23334838 Do you mean for the `symlinkmass` deprecation? In this release, I just wanted it to be deprecated with a log message showing up

[GitHub] ant-ivy pull request #:

2017-07-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23334637 Perhaps `UnsupportedOperationException` would be a useful heuristic? --- If your project is set up for it, you can reply to this

[GitHub] ant-ivy pull request #55: use vectorised logo

2017-07-27 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/55 use vectorised logo I'd like to remove downloaded.gif, error.gif, evicted.gif and searched.gif as well. Maybe we could vote on colours for downloaded and evicted 😉 if green is too dark or

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129757849 --- Diff: src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java --- @@ -85,14 +85,12 @@ public

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129668076 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -71,132 +71,139 @@ --- End diff -- Here's a "diff -wc"-style

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129663139 --- Diff: src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java --- @@ -85,14 +85,12 @@ public

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129660986 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -71,132 +71,139 @@ --- End diff -- It's a change from if ...

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129587968 --- Diff: src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java --- @@ -85,14 +85,12 @@ public

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129593699 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -71,132 +71,139 @@ --- End diff -- This file has a large

[GitHub] ant-ivy pull request #:

2017-07-25 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286798 Sure, I'll do a find/replace in one of my upcoming doc fixes commit. --- If your project is set up for it, you can reply to

[GitHub] ant-ivy pull request #:

2017-07-25 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286714 In fact, there's a bunch of places where [Mm]aven2 is used...

[GitHub] ant-ivy pull request #:

2017-07-25 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286444 In asciidoc/tutorial/multiple.adoc, please replace Maven2 with Maven 2 for consistency 😃 --- If your project is set up for

[GitHub] ant-ivy pull request #54: IVY-735 Support timeouts on resolvers

2017-07-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #54: IVY-735 Support timeouts on resolvers

2017-07-21 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/54 IVY-735 Support timeouts on resolvers The commit in this PR adds support for specifying connection and read timeouts for resolvers, so that users have control over how the resolvers behave when

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-18 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/53 Suppressed warnings As described in previous PR, all compiler warnings are annotated. This PR removes a few of them, along with some refactoring. Changes are grouped in separate commits which

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127480601 --- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java --- @@ -306,7 +306,7 @@ public boolean isClosedRange() { return

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127475255 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination,

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127474316 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination,

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127408025 --- Diff: src/java/org/apache/ivy/tools/analyser/JarJarDependencyAnalyser.java --- @@ -39,21 +39,22 @@ public JarJarDependencyAnalyser(File

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127398802 --- Diff: src/java/org/apache/ivy/util/url/HttpClientHandler.java --- @@ -177,7 +177,7 @@ public URLInfo getURLInfo(URL url, int timeout) {

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127398451 --- Diff: src/java/org/apache/ivy/tools/analyser/JarJarDependencyAnalyser.java --- @@ -39,21 +39,22 @@ public JarJarDependencyAnalyser(File

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127397658 --- Diff: src/java/org/apache/ivy/plugins/repository/ssh/SshCache.java --- @@ -263,9 +263,8 @@ public void clearSession(Session session) { *

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127397389 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination,

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396424 --- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java --- @@ -306,7 +306,7 @@ public boolean isClosedRange() { return

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396341 --- Diff: src/java/org/apache/ivy/osgi/repo/RepositoryManifestIterable.java --- @@ -59,11 +59,11 @@ protected InputStream getInputStream(String f) throws

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396320 --- Diff: src/java/org/apache/ivy/osgi/repo/RepositoryManifestIterable.java --- @@ -59,11 +59,11 @@ protected InputStream getInputStream(String f) throws

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395825 --- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java --- @@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root) {

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395788 --- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java --- @@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root) {

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395633 --- Diff: src/java/org/apache/ivy/osgi/p2/XMLInputParser.java --- @@ -19,12 +19,11 @@ import java.io.IOException; import

[GitHub] ant-ivy pull request #:

2017-07-13 Thread nlalevee
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/commit/6f22f4b49c2a3a59840d28e6cbe0c37a56ab1f90#commitcomment-23071422 Probably. And rather than asking for it, it is often better to suggest a patch. --- If your project is set up for it, you can

[GitHub] ant-ivy pull request #:

2017-07-12 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/6f22f4b49c2a3a59840d28e6cbe0c37a56ab1f90#commitcomment-23069324 Neat! 👍 Perhaps it would make sense to ask asciidoctorj team to add support for inlined Ruby and ditto for asciidoctor-ant?

[GitHub] ant-ivy pull request #51: Fix some string comparisons with ==

2017-07-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-09 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/52 Generics in core This is as far as I can get without significant changes to API. Any remaining points of contention are annotated by `@SuppressWarnings` (and I'm not proud of what `NoFilter`

[GitHub] ant-ivy pull request #51: Fix some string comparisons with ==

2017-07-06 Thread chinhodado
GitHub user chinhodado opened a pull request: https://github.com/apache/ant-ivy/pull/51 Fix some string comparisons with == You can merge this pull request into a Git repository by running: $ git pull https://github.com/chinhodado/ant-ivy master Alternatively you can review

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-03 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #50: Check spelling, fix whitespace and links

2017-07-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-01 Thread Gintautas Grigelionis
I believe stackoverflow has an answer [1] Gintas [1] https://stackoverflow.com/questions/30454635/when-using-for-a-primitive-and-a-boxed-value-is-autoboxing-done-or-is-unbox 2017-07-01 15:56 GMT+02:00 jaikiran : > Github user jaikiran commented on a diff in the pull

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-01 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/48#discussion_r125161935 --- Diff: src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java --- @@ -161,7 +159,7 @@ private PGPSecretKey

  1   2   3   >