Re: [GitHub] ant pull request #:

2018-05-13 Thread Jaikiran Pai
No problem. That change to WHATSNEW is fine, I don't mind. -Jaikiran On 13/05/18 1:03 PM, Gintautas Grigelionis wrote: Thanks, great work! I hope you don't mind me taking the liberty to adjust WHATSNEW. Gintas 2018-05-13 6:01 GMT+02:00 Jaikiran Pai : I did plan

Re: [GitHub] ant pull request #:

2018-05-13 Thread Gintautas Grigelionis
Thanks, great work! I hope you don't mind me taking the liberty to adjust WHATSNEW. Gintas 2018-05-13 6:01 GMT+02:00 Jaikiran Pai : > I did plan to addit yesterday, but my local tests did not trigger the > package-info constant pool entry for some reason. So I decided

Re: [GitHub] ant pull request #:

2018-05-12 Thread Jaikiran Pai
I did plan to addit yesterday, but my local tests did not trigger the package-info constant pool entry for some reason. So I decided to not rush it in and spend some time to get the test right, to make sure it works fine. I'll add it in either tonight or tomorrow once I get to see what's going

[GitHub] ant pull request #:

2018-05-12 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb#commitcomment-28953469 In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java: In

[GitHub] ant pull request #:

2018-04-27 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28765601 In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java: In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java

[GitHub] ant pull request #:

2018-04-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28765518 In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java: In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java

[GitHub] ant pull request #:

2018-04-23 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28691928 In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java: In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java

[GitHub] ant pull request #:

2018-04-23 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28691921 In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java: In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java

[GitHub] ant pull request #:

2018-04-23 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28691811 In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java: In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java

[GitHub] ant pull request #:

2018-04-22 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28688854 In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java: In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java

[GitHub] ant pull request #:

2018-04-22 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28688738 In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java: In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java

[GitHub] ant pull request #:

2018-04-22 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28688418 In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java: In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java

[GitHub] ant pull request #:

2018-04-15 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28590841 In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java: In

[GitHub] ant pull request #:

2018-04-15 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28590563 In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java: In

[GitHub] ant pull request #:

2018-04-15 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28589786 In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java: In

[GitHub] ant pull request #:

2018-04-15 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28586872 In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java: In

[GitHub] ant pull request #:

2018-04-11 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28526626 In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java: In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java

[GitHub] ant pull request #:

2018-04-11 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28525323 In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java: In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java

[GitHub] ant pull request #:

2018-04-11 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28525288 In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java: In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java

[GitHub] ant pull request #:

2018-04-11 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28522026 In src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java: In

[GitHub] ant pull request #:

2018-04-11 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28521960 In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java: In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java

[GitHub] ant pull request #:

2018-04-10 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28515176 In src/main/org/apache/tools/ant/util/LazyHashtable.java: In src/main/org/apache/tools/ant/util/LazyHashtable.java on line 32:

[GitHub] ant pull request #:

2018-04-10 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/4b14d85f11b9a7728dcd2d9420551fd28bf8f45e#commitcomment-28515126 In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java: In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java on line

[GitHub] ant pull request #:

2018-04-10 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28509355 In src/main/org/apache/tools/ant/util/LazyHashtable.java: In src/main/org/apache/tools/ant/util/LazyHashtable.java on line 32:

[GitHub] ant pull request #:

2018-04-10 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/4b14d85f11b9a7728dcd2d9420551fd28bf8f45e#commitcomment-28507789 In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java: In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java on line

[GitHub] ant pull request #:

2018-04-09 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/4b14d85f11b9a7728dcd2d9420551fd28bf8f45e#commitcomment-28500962 In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java: In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java on line

[GitHub] ant pull request #:

2018-04-09 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487664 In src/main/org/apache/tools/ant/util/LazyHashtable.java: In src/main/org/apache/tools/ant/util/LazyHashtable.java on line 32:

[GitHub] ant pull request #:

2018-04-09 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487485 In src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java: In

[GitHub] ant pull request #:

2018-04-09 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487413 In src/main/org/apache/tools/ant/taskdefs/Concat.java: In src/main/org/apache/tools/ant/taskdefs/Concat.java on line 597:

[GitHub] ant pull request #:

2018-04-09 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487270 In src/main/org/apache/tools/ant/XmlLogger.java: In src/main/org/apache/tools/ant/XmlLogger.java on line 210: the debugging

[GitHub] ant pull request #:

2018-04-09 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487214 In src/main/org/apache/tools/ant/Project.java: In src/main/org/apache/tools/ant/Project.java on line 1831: this changes the

[GitHub] ant pull request #:

2018-04-05 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28428982 :+1: --- - To unsubscribe, e-mail:

[GitHub] ant pull request #:

2018-04-05 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/26c8789a5067809255040d3338235b5ae25a3898#commitcomment-28428974 don't worry. I'm happy Jenkins caught it. --- - To

[GitHub] ant pull request #:

2018-04-05 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28428804 You're right, there is no concise way to do backwards foreach loops in Java. I will revert them later today. ---

[GitHub] ant pull request #:

2018-04-05 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/26c8789a5067809255040d3338235b5ae25a3898#commitcomment-28428779 Sorry about letting this through. getLocationURLs() should be annotated with `@SuppressWarnings("deprecated") `. ---

[GitHub] ant pull request #:

2018-04-05 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28426966 In src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java: In

[GitHub] ant pull request #:

2018-04-04 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28426956 In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java: In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java

[GitHub] ant pull request #:

2018-04-04 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28426843 In src/main/org/apache/tools/ant/taskdefs/Sync.java: In src/main/org/apache/tools/ant/taskdefs/Sync.java on line 242: I think

[GitHub] ant pull request #:

2018-03-17 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/a312b6728acb7a8d1f8765899615205b3042cb7e#commitcomment-28138020 @jaikiran would it be possible to add a `classpath` attribute? ---

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-17 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/60 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #:

2018-03-05 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/5aa1e8eff81ad6005e62587cdaaa962fce1105ea#commitcomment-27929054 In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java: In

[GitHub] ant pull request #:

2018-03-05 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/5aa1e8eff81ad6005e62587cdaaa962fce1105ea#commitcomment-27928590 In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java: In

[GitHub] ant pull request #:

2018-03-05 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/e06168ca78b819a21924f3716b99e3621b4855ef#commitcomment-27927813 It's not quite appropriate here, but we need a new release of Ivy... :cry: ---

[GitHub] ant pull request #:

2018-03-05 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/5aa1e8eff81ad6005e62587cdaaa962fce1105ea#commitcomment-27927763 In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java: In

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172044906 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172044717 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,295 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172044665 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,295 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172044509 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,295 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172043964 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172043835 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,295 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-04 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r172043778 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,295 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-21 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r169626791 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-21 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r169625878 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-21 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r169624865 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-21 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r169624837 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-21 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r169624475 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-20 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r169248698 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-20 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r169248048 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-20 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r169247383 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-20 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r169245116 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-20 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r169243988 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java --- @@ -0,0 +1,508 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-18 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168983237 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-18 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168983221 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-18 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168983118 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-18 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168964381 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-18 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168964295 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-18 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168963955 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

[GitHub] ant pull request #62: Use char notation to represent a character to improve ...

2018-02-16 Thread reudismam
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/62 Use char notation to represent a character to improve performance. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reudismam/ant character

[GitHub] ant pull request #61: Use the isEmpty method instead of comparing the value ...

2018-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant/pull/61 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #61: Use the isEmpty method instead of comparing the value ...

2018-02-15 Thread reudismam
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/61 Use the isEmpty method instead of comparing the value of size() to 0. You can merge this pull request into a Git repository by running: $ git pull https://github.com/reudismam/ant size

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-02-15 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/60 JUnit 5 support - A new junitlauncher task This is the initial working version of a new `junitlauncher` task that support using JUnit 5 framework for testing, within Ant build files. The commit in

[GitHub] ant pull request #57: Make junitreport with Saxon

2018-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant/pull/57 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #59: Fix NPE in ChainedMapper.

2018-02-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant/pull/59 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #59: Fix NPE in ChainedMapper.

2018-02-08 Thread jpountz
GitHub user jpountz opened a pull request: https://github.com/apache/ant/pull/59 Fix NPE in ChainedMapper. This NPE happens whenever any of the sub mappers returns `null`, which may happen eg. with `GlobPatternMapper`. You can merge this pull request into a Git repository by

[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...

2018-02-06 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/58#discussion_r166217627 --- Diff: src/main/org/apache/tools/ant/taskdefs/Parallel.java --- @@ -377,7 +377,7 @@ public synchronized void run() { } // now

[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...

2018-02-06 Thread bodewig
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/58#discussion_r166216151 --- Diff: src/main/org/apache/tools/ant/listener/MailLogger.java --- @@ -102,7 +102,7 @@ private static final String DEFAULT_MIME_TYPE = "text/plain";

[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...

2018-02-05 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/58#discussion_r166183671 --- Diff: src/main/org/apache/tools/ant/taskdefs/Parallel.java --- @@ -377,7 +377,7 @@ public synchronized void run() { } // now

[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...

2018-02-05 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/58#discussion_r166183611 --- Diff: src/main/org/apache/tools/ant/listener/MailLogger.java --- @@ -102,7 +102,7 @@ private static final String DEFAULT_MIME_TYPE = "text/plain";

[GitHub] ant pull request #58: Use StringBuilder instead of StringBuffer as it offers...

2018-02-05 Thread reudismam
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/58 Use StringBuilder instead of StringBuffer as it offers high performan… …ce in single thread places as it is generally the case. You can merge this pull request into a Git repository by running:

[GitHub] ant pull request #57: Make junitreport with Saxon

2018-02-04 Thread adamretter
GitHub user adamretter opened a pull request: https://github.com/apache/ant/pull/57 Make junitreport with Saxon Previously the XSLT(s) used in `junitreport` were only compatible with Xalan 2. Whilst you could specify a different `TransformerFactory`, and that could be Saxon, it

[GitHub] ant pull request #56: Use equals method of a string literal to prevent NPE a...

2018-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant/pull/56 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #56: Use equals method of a string literal to prevent NPE a...

2018-02-01 Thread reudismam
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/56 Use equals method of a string literal to prevent NPE and isEmpty() me… …thod instead of comparing a String object with an empty string. This change has already been done for some

[GitHub] ant pull request #55: Use valueOf method instead of constructor since valueO...

2018-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ant/pull/55 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #55: Use valueOf method instead of constructor since valueO...

2018-01-24 Thread reudismam
GitHub user reudismam opened a pull request: https://github.com/apache/ant/pull/55 Use valueOf method instead of constructor since valueOf has higher pe… …rformance. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] ant pull request #:

2018-01-23 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1465c4581ace84548ec9dfc487d62cfec14d84ad#commitcomment-27040705 we should try whether the bridge between 1.x and 2.x works and recommend our users to use that if it does. I don't think we

[GitHub] ant pull request #:

2018-01-23 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/1465c4581ace84548ec9dfc487d62cfec14d84ad#commitcomment-27040319 What about upgrading to 2.x with 1.x compatibility API? (ditto for Commons Logging). Any comments, @bodewig? ---

[GitHub] ant pull request #:

2018-01-22 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/538b7c9ffee7a18064f7726c8b20faf681adb218#commitcomment-27018577 I'd rather upgrade to Log4j 2.x :smile: --- - To unsubscribe,

[GitHub] ant pull request #52: [master] Fix BZ-58451 BZ-58833

2018-01-03 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/52 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #:

2017-12-27 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/d43d83e0198f86c9233631bcb443da132e394d65#commitcomment-26506626 You're welcome. That's why I try to make changes that are target for both branches just to the 1.9.x branch and merge it to

[GitHub] ant pull request #:

2017-12-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/d43d83e0198f86c9233631bcb443da132e394d65#commitcomment-26504265 Thanks for catching this one up, a slip of attention while backporting changes in master. ---

[GitHub] ant pull request #54: Let’s use Ivy (properly!) and drop Maven Ant tasks, ...

2017-12-26 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant/pull/54 Let’s use Ivy (properly!) and drop Maven Ant tasks, Commons OpenPGP, … … Python, etc. The implementation is incomplete, please comment. I put extraneous stuff in `attic` subdirectory for

[GitHub] ant pull request #53: Optional libraries for Ant 1.10

2017-12-25 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant/pull/53 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #:

2017-12-21 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/1a2c33fd0ef9dfc042044277707d7f38b0cfa0b0#commitcomment-26409414 Somebody with a sense of humour has a `@Deprecated` account on GitHub :rofl: ---

Re: [GitHub] ant pull request #:

2017-12-20 Thread Jaikiran Pai
No specific reason, just that I'm more used to using the javadoc variant of @deprecated since it allows explaining what's deprecated and why. I have now added the @Deprecated annotation too and pushed a commit. -Jaikiran On 20/12/17 11:08 PM, twogee wrote: Github user twogee commented on

[GitHub] ant pull request #:

2017-12-20 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/242d661161ddf2b28e6df23847c1471ee788bab7#commitcomment-26396824 In src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java: In src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java on line

[GitHub] ant pull request #53: Optional libraries for Ant 1.10

2017-12-19 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant/pull/53 Optional libraries for Ant 1.10 A bit unsure about JRuby: should we stay with 1.7 for a while or go for 9? In any case, would jruby-core be sufficient, or should jruby-stdlib be added, too? You can

[GitHub] ant pull request #50: Use newer third party libraries

2017-12-19 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant/pull/50 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #:

2017-12-18 Thread bodewig
Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/6f5db5e0689c0bea88f16f018be875ef9840825b#commitcomment-26342106 you are certainly right, thank you for catching this. --- - To

[GitHub] ant pull request #:

2017-12-18 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/6f5db5e0689c0bea88f16f018be875ef9840825b#commitcomment-26338779 Shouldn't we use HTML entities (eg )? Is HTML 3 is a requirement, too? :confused: ---

[GitHub] ant pull request #52: [master] Fix BZ-58451 BZ-58833

2017-12-16 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/52 [master] Fix BZ-58451 BZ-58833 The commit here fixes the issues reported in: https://bz.apache.org/bugzilla/show_bug.cgi?id=58833 https://bz.apache.org/bugzilla/show_bug.cgi?id=58451

  1   2   3   >