[
https://issues.apache.org/jira/browse/ANY23-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870779#comment-15870779
]
ASF GitHub Bot commented on ANY23-304:
--
Github user ansell commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/ANY23-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870778#comment-15870778
]
ASF GitHub Bot commented on ANY23-304:
--
Github user ansell commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/ANY23-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870844#comment-15870844
]
ASF GitHub Bot commented on ANY23-304:
--
Github user lewismc commented on the issue:
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/33#discussion_r101650632
--- Diff: core/src/main/java/org/apache/any23/rdf/RDFUtils.java ---
@@ -564,6 +569,4 @@ public static boolean isAbsoluteIRI(String href) {
}
[
https://issues.apache.org/jira/browse/ANY23-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870843#comment-15870843
]
ASF GitHub Bot commented on ANY23-304:
--
Github user lewismc commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/ANY23-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870842#comment-15870842
]
ASF GitHub Bot commented on ANY23-304:
--
Github user lewismc commented on a diff in the pull request:
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/33
> If there are a large number of new transitive dependencies, possibly
useful to add this as a plugin rather than into the core module.
Yes I think this is an excellent suggestion. I'm going
+1, built the source with unit tests, build passes successfully.
On Thu, Feb 16, 2017 at 5:18 AM, lewis john mcgibbney
wrote:
> PING folks.
> Would be nice to get reviews on this release candidate if possible. If we
> can't get any then I'll approach community@ and/or the
Hi Lewis,
I tried doing and core fails compiling in:
Tests in error:
EmbeddedJSONLDExtractorTest.testEmbeddedJSONLDInHead:30->AbstractExtractorTestCase.assertExtract:223->AbstractExtractorTestCase.assertExtract:210
? Runtime
+1 (binding)
Andy
- signature and hashes fine, KEYS file.
Signatures are good.
SHA1, MD5
- LICENSEs are OK
- NOTICE
- All ASF files have headers
Ran RAT.
Two files failed the RAT check; neither are critical. See below.
- No unexpected binary files
None found.
- Can compile from source
Github user ansell commented on a diff in the pull request:
https://github.com/apache/any23/pull/33#discussion_r101641510
--- Diff:
core/src/main/java/org/apache/any23/extractor/openie/OpenIEExtractor.java ---
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software
Github user ansell commented on a diff in the pull request:
https://github.com/apache/any23/pull/33#discussion_r101638032
--- Diff: core/src/main/java/org/apache/any23/rdf/RDFUtils.java ---
@@ -564,6 +569,4 @@ public static boolean isAbsoluteIRI(String href) {
}
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/33#discussion_r101650651
--- Diff:
core/src/main/java/org/apache/any23/extractor/openie/OpenIEExtractor.java ---
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software
13 matches
Mail list logo