[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread JulioCCBUcuenca
Github user JulioCCBUcuenca commented on the issue: https://github.com/apache/any23/pull/104 Thanks for your comments @lewismc. Will do it! :smile: @HansBrende librdfa supports RDFa 1.0 and 1.1, so I made sure that librdfa extractor works on all tests that Semargl extractor

[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/104 @lewismc I attempted to create a new branch using: ``` git checkout -b ANY23-295 git push canonical ANY23-295 ``` to which git responded with: ``` To

[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread JulioCCBUcuenca
Github user JulioCCBUcuenca commented on the issue: https://github.com/apache/any23/pull/104 I change the base branch. Thanks so much @HansBrende ---

[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/104 > Remember, that not only the libraries that librdfa uses are old but the librdfa project itself has not being active in a while. Yes but it is compliant with the RDFa test suite which is

[jira] [Commented] (ANY23-295) Implement ability to use librdfa

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573859#comment-16573859 ] ASF GitHub Bot commented on ANY23-295: -- Github user lewismc commented on the issue:

[jira] [Commented] (ANY23-295) Implement ability to use librdfa

2018-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573896#comment-16573896 ] ASF GitHub Bot commented on ANY23-295: -- Github user HansBrende commented on the issue:

[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/104 It is showing up here: https://git-wip-us.apache.org/repos/asf?p=any23.git But not here: https://github.com/apache/any23/branches ---

[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/104 @JulioCCBUcuenca Great to hear it passes the semargl test suites! However, `AbstractRDFaExtractorTestCase` contains only a fraction of the tests we run on RDFa. You should also test against the

[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/104 Ok, apparently due to some quirkiness of the way mirroring works, new branches in git-wip will not show up on github until an actual change is made to the branch. ---

[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/104 @JulioCCBUcuenca Alright, sounds great then! ---

[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/104 Ok, I added some whitespace to a package-info.java file, should be showing up now. ---

[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread JulioCCBUcuenca
Github user JulioCCBUcuenca commented on the issue: https://github.com/apache/any23/pull/104 @HansBrende it is testing those main tests as well. It is testing the tests of Semargl RDFa 1.0 (`RDFaExtractorTest`), Semargl RDFa 1.1 (`RDFa11ExtractorTest`), and base suitcase

[jira] [Created] (ANY23-387) Possible OutOfMemoryError with bad deeply nested HTML

2018-08-08 Thread Anthony Pessy (JIRA)
Anthony Pessy created ANY23-387: --- Summary: Possible OutOfMemoryError with bad deeply nested HTML Key: ANY23-387 URL: https://issues.apache.org/jira/browse/ANY23-387 Project: Apache Any23 Issue

[jira] [Commented] (ANY23-387) Possible OutOfMemoryError with bad deeply nested HTML

2018-08-08 Thread Hans Brende (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573278#comment-16573278 ] Hans Brende commented on ANY23-387: --- [~panthony] Would you mind verifying that this issue is present in

[jira] [Commented] (ANY23-386) Item's properties are in the wrong item since the 2.2

2018-08-08 Thread Hans Brende (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573275#comment-16573275 ] Hans Brende commented on ANY23-386: --- [~panthony] Would you try testing this on the 2.3-SNAPSHOT version?

[jira] [Closed] (ANY23-386) Item's properties are in the wrong item since the 2.2

2018-08-08 Thread Anthony Pessy (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Pessy closed ANY23-386. --- Resolution: Fixed Fix Version/s: 2.3 This issue is fixed on the `2.3-SNAPSHOT`. Failed to

[jira] [Resolved] (ANY23-386) Item's properties are in the wrong item since the 2.2

2018-08-08 Thread Hans Brende (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Brende resolved ANY23-386. --- Resolution: Fixed > Item's properties are in the wrong item since the 2.2 >

[jira] [Commented] (ANY23-386) Item's properties are in the wrong item since the 2.2

2018-08-08 Thread Hans Brende (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573367#comment-16573367 ] Hans Brende commented on ANY23-386: --- [~panthony] No release date has been set yet, although I'd imagine

[jira] [Resolved] (ANY23-386) Item's properties are in the wrong item since the 2.2

2018-08-08 Thread Hans Brende (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Brende resolved ANY23-386. --- Resolution: Duplicate > Item's properties are in the wrong item since the 2.2 >

[jira] [Commented] (ANY23-386) Item's properties are in the wrong item since the 2.2

2018-08-08 Thread Anthony Pessy (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573374#comment-16573374 ] Anthony Pessy commented on ANY23-386: - [~HansBrende] Alright ! Thank you for your time. > Item's

[jira] [Commented] (ANY23-386) Item's properties are in the wrong item since the 2.2

2018-08-08 Thread Anthony Pessy (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573295#comment-16573295 ] Anthony Pessy commented on ANY23-386: - [~HansBrende] Sure, how can I depend on a snapshot version ?   

[jira] [Reopened] (ANY23-386) Item's properties are in the wrong item since the 2.2

2018-08-08 Thread Hans Brende (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Brende reopened ANY23-386: --- > Item's properties are in the wrong item since the 2.2 >

[jira] [Commented] (ANY23-386) Item's properties are in the wrong item since the 2.2

2018-08-08 Thread Hans Brende (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573315#comment-16573315 ] Hans Brende commented on ANY23-386: --- [~panthony] if you're using maven, you can add the following

[jira] [Closed] (ANY23-387) Possible OutOfMemoryError with bad deeply nested HTML

2018-08-08 Thread Anthony Pessy (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Pessy closed ANY23-387. --- Resolution: Fixed Fix Version/s: 2.3 Issue already fixed. Sorry failed to find a similar

[GitHub] any23 pull request #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/any23/pull/104#discussion_r208642202 --- Diff: core/pom.xml --- @@ -335,7 +343,14 @@ - + + + + librdfa-rdf4j +

[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/104 @JulioCCBUcuenca Please address the issue of making librdfa-rdf4j a module within Any23 then push your changes. At that stage I will most likely approve the PR and we can test more thoroughly.

[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/104 `Current XML parsers can use both lang or xml:lang, but since librdfa uses an old library for parsing XML it generates an error since it cannot identify the language.` That seems

[GitHub] any23 issue #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/104 > @lewismc should we not test more thoroughly before merging to master? Maybe a separate branch instead? Yes absolutely. We should also definitely extend the integration tests as well such

[GitHub] any23 pull request #104: Any23 295: Implement ability to use librdfa

2018-08-08 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/any23/pull/104#discussion_r208642324 --- Diff: test-resources/src/test/resources/html/rdfa/basic.html --- @@ -14,7 +14,7 @@ See the License for the specific language governing permissions

[jira] [Updated] (ANY23-386) Item's properties are in the wrong item since the 2.2

2018-08-08 Thread Anthony Pessy (JIRA)
[ https://issues.apache.org/jira/browse/ANY23-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Pessy updated ANY23-386: Summary: Item's properties are in the wrong item since the 2.2 (was: (Huge) regression between 2.1

[jira] [Created] (ANY23-386) (Huge) regression between 2.1 and 2.2 ?

2018-08-08 Thread Anthony Pessy (JIRA)
Anthony Pessy created ANY23-386: --- Summary: (Huge) regression between 2.1 and 2.2 ? Key: ANY23-386 URL: https://issues.apache.org/jira/browse/ANY23-386 Project: Apache Any23 Issue Type: Bug