[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-27 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/56 @HansBrende > What do you think about my OOM handling suggestion? I edited my comment to provide some sample code. Excellent suggestion, I've accommodated it. I also agree that anothe

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-27 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/56 Ah, I see. Well, it may not be the end of the world if we stick with 4.2.6 for now--looks like that version requires less memory anyway. What do you think about my OOM handling suggestion? I

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-27 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/56 I logged an issue in JIRA about this. I’ve also been over to see that disappointingly there is not Maven artifact available for OpenIE 5. I didn’t hear anything back from the OpenIE team eith

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-27 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/56 On a slightly unrelated topic, according to [this github page](https://github.com/knowitall/openie), the current version of OpenIE is OpenIE 5, located [here](https://github.com/dair-iitd/OpenIE-sta

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-26 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/56 Or... in lieu of adding a config flag, it might be nice to just handle `OutOfMemoryError`s gracefully. If an `OutOfMemoryError` is encountered, just skip the OpenIE extraction and move on to the nex

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-26 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/56 @lewismc my suggestion was to provide a config flag *in addition to* the existing checkbox (the difference being: the config flag would *not* be controlled by the user accessing the webpage--but by

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-26 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/56 > My main concern, if this will be deployed to any23.org, would be the RAM usage. We can always request more RAM for the dedicated VM powering any23.org > One solution might be to add

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-26 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/56 (The flag could even be read at the build-level: for example, you might add a build step that reads your configuration file and modifies the HTML to show or hide the toggle according to whether or n

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-26 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/56 I haven't tried it locally, but I agree it's pretty cool functionality and would aptly demonstrate that plugin-loading works. My main concern, if this will be deployed to any23.org, would be

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-26 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/56 Yes this is optizonal for the core API and would really only be used to demonstrate applications that can be built using Any23’s dynamic plugin loading capabilities. This is a good excuse to up

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-26 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/56 I mean, I'm not sure what kind of resources you want your webservice to be using, but 6GB memory sounds like a blocker to me. Using OpenIE with the core api would be opt-in only, right? ---

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-26 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/56 Any comments here folks? ---

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-23 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/56 OK folks, so this issue is now available for testing. I can see two immediate issues 1. OpenIE is memory-intensive and can prety easily exhaust >6GB memory for larger jobs. This is an issue if

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-23 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/56 I've messed this PR up now so I will close and reopen another once I have the dependency issue resolved. I'll also provide an update to the documentation as to how dynamic classloading is done per exam

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-23 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/56 Hi @HansBrende your suggestion fixed the code so I have pushed for further review. @ansell thank you for the suggestions I think you are absolutely right... I've posted a [question](https://lists.

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-08 Thread ansell
Github user ansell commented on the issue: https://github.com/apache/any23/pull/56 I don't have time right now to debug this or work on its design. It isn't a pattern I have worked on in the past. All ``ServiceLoader`` projects that I have worked on in the past either have all of the

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-08 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/56 @HansBrende not yet sorry, I have been overloaded :( I will try tonight. ---

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-08 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/56 @lewismc have you been able to test whether or not my suggested insertion fixes your problem? ---

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-05 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/56 @jgrzebyta Yes, I had that problem too. Mvn build fails, but that's not related to the classloader problem @lewismc is having (which my comment above should fix--the extractor registry automatically

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-05 Thread jgrzebyta
Github user jgrzebyta commented on the issue: https://github.com/apache/any23/pull/56 @lewismc I have: `Failed to execute goal on project apache-any23-service: Could not resolve dependencies for project org.apache.any23:apache-any23-service:war:2.3-SNAPSHOT: Failure to find

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-03 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/56 @lewismc I really have no idea how to deploy to Tomcat, being a bit of a noob, but have you tried doing something like this in `Servlet.java`? ``` if (loadedJars) { ExtractorReg

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-03 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/56 Thanks @HansBrende :) Once you have built the Webservice and deployed to Tomcat, you should make sure that you check the **openie** checkbox in the GUI. You can set a breakpoint at the [openie c

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-02 Thread HansBrende
Github user HansBrende commented on the issue: https://github.com/apache/any23/pull/56 @lewismc you said you had some specific lines for debugging? ---

[GitHub] any23 issue #56: ANY23-321 Add openie toggle functionality to service

2018-02-02 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/any23/pull/56 @HansBrende @jgrzebyta can you both please have a look at dynamic plugin loading in this patch? I am at a loss, having tried to debug this with no progress. Thanks in advance, ---