Yes Thomas. I'm going to create a docker image.
I was hoping that I can create the docker for 3.7.0 from new changes in
master which pulls dist atrato instead of creating from my repo. This will
act as a pilot for building docker from apex-core repo as well. Let me know
if this is fine.
Regards,
+1 for the initiative
Some thoughts:
- it is probably good to retain a level of abstraction, to avoid direct
dependency on dropwizard
- support programmatic metric creation (not just annotations)
- remove deprecated counter and auto-metric code and migrate operators to
use new API
- which metric
+1 for the #1 proposal.
Thank you,
Vlad
On 5/9/18 07:14, Thomas Weise wrote:
+1 for the initiative
Some thoughts:
- it is probably good to retain a level of abstraction, to avoid direct
dependency on dropwizard
- support programmatic metric creation (not just annotations)
- remove
+1 for the feature.
+1 for an abstracted way of metrics library integration.
Some additional thoughts on this:
- We might have implications of adding a set of dependencies from drop
wizard into the engine core ( guava versions etc).
- Flink as pointed out by Thomas seems to have taken an
[
https://issues.apache.org/jira/browse/APEXCORE-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Weise resolved APEXCORE-811.
---
Resolution: Fixed
Fix Version/s: 4.0.0
> Move docker build sourcecode from private
+1 for approach 1. As Thomas mentioned, I think there metrics layer should
be abstracted out from its implementation. This way one can plugin
different metrics systems in apex.
Also keep in mind that there is a lot of code which uses AutoMetrics
annotations. We should help a smooth transition
[
https://issues.apache.org/jira/browse/APEXCORE-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469891#comment-16469891
]
ASF GitHub Bot commented on APEXCORE-811:
-
tweise closed pull request #598: APEXCORE-811 Added
I would prefer to create it from a release branch since master is a moving
target.
Since we don't have the docker files in apex-core/release-3.7, my
suggestion to create the branch in your repo, as done till now.
You can still pilot the build for the latest image from apex-core/master
Thanks
