[jira] [Commented] (APEXMALHAR-2241) The metadata kafka consumer should also pickup the properties setting on the kafka input operator.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1560#comment-1560
 ] 

ASF GitHub Bot commented on APEXMALHAR-2241:


Github user asfgit closed the pull request at:

https://github.com/apache/apex-malhar/pull/423


> The metadata kafka consumer should also pickup the properties setting on the 
> kafka input operator. 
> ---
>
> Key: APEXMALHAR-2241
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2241
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Siyuan Hua
>Assignee: Venkatesh Kottapalli
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2241) The metadata kafka consumer should also pickup the properties setting on the kafka input operator.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514640#comment-15514640
 ] 

ASF GitHub Bot commented on APEXMALHAR-2241:


GitHub user venkateshkottapalli opened a pull request:

https://github.com/apache/apex-malhar/pull/423

APEXMALHAR-2241 - The metadata kafka consumer should also pickup the 
properties setting on the kafka input operator

Fixes two issues - 
* metadata kafka consumer not picking up properties set 
* Consumer properties set from Properties.xml are  not getting picked.
* Added test case to validate the consumer Properties are not reset.

@siyuanh Please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/venkateshkottapalli/apex-malhar 
APEXMALHAR-2241-KafkaConsumer-MetaDataProps

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/apex-malhar/pull/423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #423


commit 02c040ac184396602116f6a1eec26b0c838a6d23
Author: venkateshDT 
Date:   2016-09-22T20:27:32Z

fixes two issues - pick the metadata consumer properties and setting the 
consumer properties from Properties.xml for kafka inputoperator not working

added test case

Removed trailing spaces

Removed unused imports




> The metadata kafka consumer should also pickup the properties setting on the 
> kafka input operator. 
> ---
>
> Key: APEXMALHAR-2241
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2241
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Siyuan Hua
>Assignee: Venkatesh Kottapalli
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2241) The metadata kafka consumer should also pickup the properties setting on the kafka input operator.

[Venkatesh Kottapalli (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496849#comment-15496849
 ] 

Venkatesh Kottapalli commented on APEXMALHAR-2241:
--

Sure Siyuan. I will set the consumer properties and test.

> The metadata kafka consumer should also pickup the properties setting on the 
> kafka input operator. 
> ---
>
> Key: APEXMALHAR-2241
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2241
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Siyuan Hua
>Assignee: Venkatesh Kottapalli
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2241) The metadata kafka consumer should also pickup the properties setting on the kafka input operator.

[Siyuan Hua (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496632#comment-15496632
 ] 

Siyuan Hua commented on APEXMALHAR-2241:


Hey [~Venkatesh Kottapalli] Would you like to fix this as you already know the 
root cause. And also a small test case please.

> The metadata kafka consumer should also pickup the properties setting on the 
> kafka input operator. 
> ---
>
> Key: APEXMALHAR-2241
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2241
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Siyuan Hua
>Assignee: Venkatesh Kottapalli
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)