Re: Issues/questions with apr_memcache_multigetp

2015-09-23 Thread Jim Jagielski
Haven't looked at the actual bug but yet, in general, we appreciate it when people send in patches that fix bugs or errors in our code instead of simply forking off those changes. Apache tries to work a little bit differently than the current buzz about forking and working in isolation; we

Issues/questions with apr_memcache_multigetp

2015-09-23 Thread Jeffrey Crowell
Hi, I work on mod_pagespeed, where we use a forked version of apr_memcache.c ( https://github.com/pagespeed/mod_pagespeed/blob/master/third_party/aprutil/apr_memcache2.c) to interact with memcached. Recently we've become aware of a bug where we end up hanging in apr_memcache2_multigetp, pinning

Re: Issues/questions with apr_memcache_multigetp

2015-09-23 Thread Jeffrey Crowell
Jim, Our current patches were to fix some compile time warnings about signed vs. unsigned comparisons, which I think have actually backfired and are causing the 100% cpu usage. My current guess is that our forked version works as the initial code intended, and causes the hang, and the upstream