Re: New warnings on trunk in maintainer mode
On 17.11.2018 23:16, Branko Čibej wrote: > .../atomic/unix/builtins.c:71:53: warning: passing 'const void *' to > parameter of type 'void *' discards qualifiers > [-Wincompatible-pointer-types-discards-qualifiers] > return (void*) __sync_val_compare_and_swap(mem, cmp, with); I think the prototype for apr_atomic_casptr is just wrong; it should be void* apr_atomic_casptr(void *volatile *, void *, void *); not void* apr_atomic_casptr(void *volatile *, void *, const void *); Thoughts? Can we fix this in 2.x? -- Brane
New warnings on trunk in maintainer mode
I see the following new-ish warnings on trunk, on macOS: .../jose/apr_jose_decode.c:21:14: warning: no previous prototype for function 'apr_jose_flatten' [-Wmissing-prototypes] apr_status_t apr_jose_flatten(apr_bucket_brigade *bb, apr_jose_text_t *in, 13 of these, the above is just a sample ... prototypes (and docstrings) are missing from include/apr_jose.h. and: .../atomic/unix/builtins.c:71:53: warning: passing 'const void *' to parameter of type 'void *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers] return (void*) __sync_val_compare_and_swap(mem, cmp, with); -- Brane