Re: svn commit: r1854123 - in /apr/apr/trunk: CHANGES threadproc/unix/signals.c

[Yann Ylavic]

On Thu, Mar 7, 2019 at 6:36 PM Yann Ylavic  wrote:
>
> On Thu, Mar 7, 2019 at 4:12 PM William A Rowe Jr  wrote:
> >
> > did you want to backport this to 1.7.0 branch?
>
> Done in r1854995, thanks for the reminder!
>
> >
> > Do we want to identify the delta and old pre-1.7 behavior in the doxygen
> > of this function?
>
> Something like:

I went with r1855049 and backported it to 1.7.x.
Hth..

Re: svn commit: r1854123 - in /apr/apr/trunk: CHANGES threadproc/unix/signals.c

[Yann Ylavic]

On Thu, Mar 7, 2019 at 4:12 PM William A Rowe Jr  wrote:
>
> did you want to backport this to 1.7.0 branch?

Done in r1854995, thanks for the reminder!

>
> Do we want to identify the delta and old pre-1.7 behavior in the doxygen
> of this function?

Something like:

Index: include/apr_thread_proc.h
===
--- include/apr_thread_proc.h(revision 1854994)
+++ include/apr_thread_proc.h(working copy)
@@ -816,6 +816,8 @@ APR_DECLARE(apr_status_t) apr_setup_signal_thread(
  * functions should return 1 if the signal has been handled, 0 otherwise.
  * @param signal_handler The function to call when a signal is received
  * apr_status_t apr_signal_thread((int)(*signal_handler)(int signum))
+ * @note From APR 1.7, SIGUSR2 is no more ignored by apr_signal_thread() and
+ * thus can by caught by the signal_handler.
  */
 APR_DECLARE(apr_status_t) apr_signal_thread(int(*signal_handler)(int signum));

?

Re: svn commit: r1854123 - in /apr/apr/trunk: CHANGES threadproc/unix/signals.c

[William A Rowe Jr]

Hi Yann,

did you want to backport this to 1.7.0 branch?

Do we want to identify the delta and old pre-1.7 behavior in the doxygen
of this function?


On Fri, Feb 22, 2019 at 3:21 AM  wrote:

> Author: ylavic
> Date: Fri Feb 22 09:21:19 2019
> New Revision: 1854123
>
> URL: http://svn.apache.org/viewvc?rev=1854123=rev
> Log:
> Signals: Allow handling of SIGUSR2 in apr_signal_thread.
>
> It's not like users have so many free signals to play with, let's increase
> this number by 100% here, not so bad :)
>
> Modified:
> apr/apr/trunk/CHANGES
> apr/apr/trunk/threadproc/unix/signals.c
>
> Modified: apr/apr/trunk/CHANGES
> URL:
> http://svn.apache.org/viewvc/apr/apr/trunk/CHANGES?rev=1854123=1854122=1854123=diff
>
> ==
> --- apr/apr/trunk/CHANGES [utf-8] (original)
> +++ apr/apr/trunk/CHANGES [utf-8] Fri Feb 22 09:21:19 2019
> @@ -1,6 +1,8 @@
>   -*- coding: utf-8 -*-
>  Changes for APR 2.0.0
>
> +  *) Signals: Allow handling of SIGUSR2 in apr_signal_thread. [Yann
> Ylavic]
> +
>*) Atomics: Support for 64bit ints. [Jim Jagielski]
>
>*) apr_jose: Add support for encoding and decoding of JSON Object
>
> Modified: apr/apr/trunk/threadproc/unix/signals.c
> URL:
> http://svn.apache.org/viewvc/apr/apr/trunk/threadproc/unix/signals.c?rev=1854123=1854122=1854123=diff
>
> ==
> --- apr/apr/trunk/threadproc/unix/signals.c (original)
> +++ apr/apr/trunk/threadproc/unix/signals.c Fri Feb 22 09:21:19 2019
> @@ -307,13 +307,7 @@ static void remove_sync_sigs(sigset_t *s
>  /* the rest of the signals removed from the mask in this function
>   * absolutely must be removed; you cannot block synchronous signals
>   * (requirement of pthreads API)
> - *
> - * SIGUSR2 is being removed from the mask for the convenience of
> - * Purify users (Solaris, HP-UX, SGI) since Purify uses SIGUSR2
>   */
> -#ifdef SIGUSR2
> -sigdelset(sig_mask, SIGUSR2);
> -#endif
>  }
>
>  APR_DECLARE(apr_status_t) apr_signal_thread(int(*signal_handler)(int
> signum))
>
>
>