[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870036#comment-15870036 ] ASF subversion and git services commented on ARIA-42: - Commit 1498ad397bcbed5a69c01f6d512a251e375792c7 in incubator-ariatosca's branch refs/heads/ARIA-79-concurrent-storage-modifications from mxmrlv [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=1498ad3 ] ARIA-42-Generic-ctx-serialization-mechanism > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > Fix For: 0.1.0 > > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859249#comment-15859249 ] ASF GitHub Bot commented on ARIA-42: Github user asfgit closed the pull request at: https://github.com/apache/incubator-ariatosca/pull/68 > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859248#comment-15859248 ] ASF subversion and git services commented on ARIA-42: - Commit 1498ad397bcbed5a69c01f6d512a251e375792c7 in incubator-ariatosca's branch refs/heads/master from mxmrlv [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=1498ad3 ] ARIA-42-Generic-ctx-serialization-mechanism > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859234#comment-15859234 ] ASF subversion and git services commented on ARIA-42: - Commit 1498ad397bcbed5a69c01f6d512a251e375792c7 in incubator-ariatosca's branch refs/heads/ARIA-42-Generic-ctx-serialization-mechanism from mxmrlv [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=1498ad3 ] ARIA-42-Generic-ctx-serialization-mechanism > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858259#comment-15858259 ] ASF GitHub Bot commented on ARIA-42: Github user ran-z commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/68#discussion_r100119409 --- Diff: tests/storage/__init__.py --- @@ -65,3 +65,14 @@ def release_sqlite_storage(storage): session.close() for engine in set(mapi._engine for mapi in mapis): --- End diff -- dont forget to revisit mock context > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[
https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858257#comment-15858257
]
ASF GitHub Bot commented on ARIA-42:
Github user ran-z commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/68#discussion_r100119147
--- Diff: aria/storage/core.py ---
@@ -66,10 +67,10 @@ def __init__(self,
self.registered = {}
self._initiator = initiator
self._initiator_kwargs = initiator_kwargs or {}
+self._api_kwargs = api_kwargs or {}
+self._additional_api_kwargs = {}
--- End diff --
unpicklable
> Implement full blown mechanism for serializing an operation context
> ---
>
> Key: ARIA-42
> URL: https://issues.apache.org/jira/browse/ARIA-42
> Project: AriaTosca
> Issue Type: Story
>Reporter: Dan Kilman
>Assignee: Maxim Orlov
>
> The current mechanism at
> aria/orchestration/workflows/context/serialization.py is very limited.
> It serializes/deserializes the context.model and context.resource with hard
> coded knowledge of the actual implementation involved and even how they were
> initialized. Specifically:
> The model storage initialized is always expected to be sqlachemy based with
> no additional engine configuration (i.e. only the engine url is used to
> re-construct the sqlalchemy engine), similar logic applies to the
> instantiated sqlalchemy session.
> The resource storage initialized is always the file based resource storage.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[
https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858116#comment-15858116
]
ASF GitHub Bot commented on ARIA-42:
Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/68#discussion_r100087789
--- Diff: aria/storage/sql_mapi.py ---
@@ -364,6 +369,28 @@ def _load_relationships(instance):
getattr(instance, rel.key)
+def init_storage(base_dir=None, filename='db.sqlite'):
+if base_dir is not None:
+uri = 'sqlite:///{platform_char}{path}'.format(
+# Handles the windows behavior where there is not root, but
drivers.
+# Thus behaving as relative path.
+platform_char='' if 'Windows' in platform.system() else '/',
+
+path=os.path.join(base_dir, filename))
+engine_kwargs = {}
+else:
+uri = 'sqlite:///:memory:'
--- End diff --
remove in memory option to tests only
> Implement full blown mechanism for serializing an operation context
> ---
>
> Key: ARIA-42
> URL: https://issues.apache.org/jira/browse/ARIA-42
> Project: AriaTosca
> Issue Type: Story
>Reporter: Dan Kilman
>Assignee: Maxim Orlov
>
> The current mechanism at
> aria/orchestration/workflows/context/serialization.py is very limited.
> It serializes/deserializes the context.model and context.resource with hard
> coded knowledge of the actual implementation involved and even how they were
> initialized. Specifically:
> The model storage initialized is always expected to be sqlachemy based with
> no additional engine configuration (i.e. only the engine url is used to
> re-construct the sqlalchemy engine), similar logic applies to the
> instantiated sqlalchemy session.
> The resource storage initialized is always the file based resource storage.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858117#comment-15858117 ] ASF GitHub Bot commented on ARIA-42: Github user mxmrlv commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/68#discussion_r100089478 --- Diff: tests/orchestrator/workflows/executor/test_executor.py --- @@ -80,9 +81,9 @@ class MockException(Exception): pass -class MockContext(object): +class MockContext(operation.BaseOperationContext): -def __init__(self, *args, **kwargs): +def __init__(self, *args, **kwargs): # pylint: disable=super-init-not-called --- End diff -- add serialize function > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857862#comment-15857862 ] ASF subversion and git services commented on ARIA-42: - Commit 4c5126e188535215b64b38955c0577f4e186f522 in incubator-ariatosca's branch refs/heads/ARIA-42-Generic-ctx-serialization-mechanism from mxmrlv [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=4c5126e ] ARIA-42-Generic-ctx-serialization-mechanism > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854749#comment-15854749 ] ASF subversion and git services commented on ARIA-42: - Commit 01f96369973bd9564bb19bdb44ffc9ac15166504 in incubator-ariatosca's branch refs/heads/ARIA-42-Generic-ctx-serialization-mechanism from mxmrlv [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=01f9636 ] ARIA-42-Generic-ctx-serialization-mechanism > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854741#comment-15854741 ] ASF subversion and git services commented on ARIA-42: - Commit efdd85f662b0df78d88f62b59272558b8b5a3290 in incubator-ariatosca's branch refs/heads/ARIA-42-Generic-ctx-serialization-mechanism from mxmrlv [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=efdd85f ] ARIA-42-Generic-ctx-serialization-mechanism > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854379#comment-15854379 ] ASF subversion and git services commented on ARIA-42: - Commit a9951360ea2c95a859cf239097cfe5c64631144f in incubator-ariatosca's branch refs/heads/ARIA-42-Generic-ctx-serialization-mechanism from mxmrlv [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=a995136 ] ARIA-42-Generic-ctx-serialization-mechanism > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854322#comment-15854322 ] ASF subversion and git services commented on ARIA-42: - Commit 52df10954f4c2347726c945964f36a038168d27d in incubator-ariatosca's branch refs/heads/ARIA-42-Generic-ctx-serialization-mechanism from mxmrlv [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=52df109 ] ARIA-42-Generic-ctx-serialization-mechanism > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854273#comment-15854273 ] ASF subversion and git services commented on ARIA-42: - Commit 53344f781cf0ab836e1064625e176d5570bb9eb2 in incubator-ariatosca's branch refs/heads/ARIA-42-Generic-ctx-serialization-mechanism from mxmrlv [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=53344f7 ] ARIA-42-Generic-ctx-serialization-mechanism > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARIA-42) Implement full blown mechanism for serializing an operation context
[ https://issues.apache.org/jira/browse/ARIA-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854277#comment-15854277 ] ASF subversion and git services commented on ARIA-42: - Commit 59c266dc2bfe264c5ff6868b0fc8be8ef16f9d09 in incubator-ariatosca's branch refs/heads/ARIA-42-Generic-ctx-serialization-mechanism from mxmrlv [ https://git-wip-us.apache.org/repos/asf?p=incubator-ariatosca.git;h=59c266d ] ARIA-42-Generic-ctx-serialization-mechanism > Implement full blown mechanism for serializing an operation context > --- > > Key: ARIA-42 > URL: https://issues.apache.org/jira/browse/ARIA-42 > Project: AriaTosca > Issue Type: Story >Reporter: Dan Kilman >Assignee: Maxim Orlov > > The current mechanism at > aria/orchestration/workflows/context/serialization.py is very limited. > It serializes/deserializes the context.model and context.resource with hard > coded knowledge of the actual implementation involved and even how they were > initialized. Specifically: > The model storage initialized is always expected to be sqlachemy based with > no additional engine configuration (i.e. only the engine url is used to > re-construct the sqlalchemy engine), similar logic applies to the > instantiated sqlalchemy session. > The resource storage initialized is always the file based resource storage. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
