[jira] [Commented] (ARROW-261) [C++] Refactor BinaryArray/StringArray classes to not inherit from ListArray
[ https://issues.apache.org/jira/browse/ARROW-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580980#comment-15580980 ] Wes McKinney commented on ARROW-261: see PR https://github.com/apache/arrow/pull/176 > [C++] Refactor BinaryArray/StringArray classes to not inherit from ListArray > > > Key: ARROW-261 > URL: https://issues.apache.org/jira/browse/ARROW-261 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Reporter: Micah Kornfield >Assignee: Wes McKinney > > also change there builders to not inherit from ListBuilder. These should be > first class types. I think the consensus is to have them inherit from > PrimitiveArray but I think I this might be awkward, and having them inherit > directly from Array might be better. [~wesmckinn] thoughts? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARROW-261) [C++] Refactor BinaryArray/StringArray classes to not inherit from ListArray
[ https://issues.apache.org/jira/browse/ARROW-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511360#comment-15511360 ] Wes McKinney commented on ARROW-261: The scope of this issue will also involve fixing the IPC adapter to not write string as list-like metadata > [C++] Refactor BinaryArray/StringArray classes to not inherit from ListArray > > > Key: ARROW-261 > URL: https://issues.apache.org/jira/browse/ARROW-261 > Project: Apache Arrow > Issue Type: Bug > Components: C++ >Reporter: Micah Kornfield >Assignee: Wes McKinney > > also change there builders to not inherit from ListBuilder. These should be > first class types. I think the consensus is to have them inherit from > PrimitiveArray but I think I this might be awkward, and having them inherit > directly from Array might be better. [~wesmckinn] thoughts? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
