Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195986 ---

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195989 ---

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195997 ---

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195998 ---

Re: Review Request 65297: Advanced Search DSL: Support System Attributes within Query

2018-01-23 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65297/#review196100 --- repository/src/main/java/org/apache/atlas/query/DSLVisitor.java

Re: [VOTE] Release Apache Atlas version 1.0.0-alpha release candidate 2

2018-01-23 Thread Sharmadha Sainath
+1 for 1.0.0-alpha-rc2 Verification done : 1. New DSL search changes. 2. UI functionality - Search , Tag creation , Tag Association/Disassociation/modification of attributes , Entity Creation/Modification on UI , Navigating to entities , detailsPage of entity, Saving search. 3. Type and

Jenkins build is back to normal : Atlas-master-UnitTests #313

2018-01-23 Thread Apache Jenkins Server
See

Re: [VOTE] Release Apache Atlas version 1.0.0-alpha release candidate 2

2018-01-23 Thread Ramesh Mani
+1 for 1.0.0-alpha release candidate 2 Verified build from the source https://dist.apache.org/repos/dist/dev/atlas/1.0.0-alpha-rc2/apache-atlas-1 .0.0-alpha-sources.tar.gz Verified some of the source files. Thanks, Ramesh On 1/19/18, 5:36 AM, "Keval Bhatt" wrote: >Atlas

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell
> On Jan. 23, 2018, 1:03 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java > > Lines 115 (patched) > > > > > > should here be > >

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell
> On Jan. 22, 2018, 2:17 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java > > Lines 104 (patched) > > > > > > is it possible to change

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell
> On Jan. 23, 2018, 1:39 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatch.java > > Lines 49 (patched) > > > > > > if the user wants to user create a

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell
> On Jan. 23, 2018, noon, Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSConnectorProvider.java > > Lines 40 (patched) > > > > > > should here extends

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell
> On Jan. 23, 2018, 1:03 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java > > Lines 133 (patched) > > > > > > here the

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell
> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 91 (original), 86 (patched) > > > > > > based on the comments

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell
> On Jan. 23, 2018, 1:03 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java > > Lines 96 (patched) > > > > > > should here be > >

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell
> On Jan. 22, 2018, 2:17 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java > > Lines 162 (patched) > > > > > > why do we need to

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell
> On Jan. 23, 2018, 1:03 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSConnectorProvider.java > > Lines 41 (patched) > > > > > > is it necessary to have

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell
> On Jan. 22, 2018, 2:17 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java > > Lines 226 (patched) > > > > > > what if the

Review Request 65297: Advanced Search DSL: Support System Attributes within Query

2018-01-23 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65297/ --- Review request for atlas and Apoorv Naik. Bugs: ATLAS-2418