Review Request 61667: ATLAS-2044: In-memory filtering after index query

2017-08-15 Thread Apoorv Naik
teUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/61667/diff/1/ Testing --- REST and UI testing no longer show the false positive matches. mvn clean package -Pdist (in progress) Thanks, Apoorv Naik

Re: [ANNOUNCE] New Committer: Mandy Chessell

2017-08-15 Thread Apoorv Naik
Congratulations Mandy. On 8/15/17, 10:21 AM, "Ayub Khan Pathan" wrote: >Congratulations, Mandy. > >On 8/15/17, 8:51 PM, "Madhan Neethiraj" wrote: > >Atlas community, > > > >Apache Atlas PMC has asked Mandy Chessell to become a

Re: [ANNOUNCE] New Committer: Ashutosh Mestry

2017-08-15 Thread Apoorv Naik
Congratulations Ashutosh. On 8/15/17, 10:21 AM, "Ayub Khan Pathan" wrote: >Congratulations, Ashutosh! > >On 8/13/17, 11:03 PM, "Madhan Neethiraj" wrote: > >Atlas community, > > > >Apache Atlas PMC has asked Ashutosh Mestry to

Re: [ANNOUNCE] New Committer: David Radley

2017-08-15 Thread Apoorv Naik
Congratulations David. On 8/15/17, 10:20 AM, "Ayub Khan Pathan" wrote: >Congratulations, David. > >On 8/13/17, 11:07 PM, "Madhan Neethiraj" wrote: > >Atlas community, > > > >Apache Atlas PMC has asked David Radley to become a

Review Request 61670: ATLAS-1880: UTs

2017-08-15 Thread Apoorv Naik
PRE-CREATION Diff: https://reviews.apache.org/r/61670/diff/1/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter

2017-08-10 Thread Apoorv Naik
IT I believe, that would eliminate the need of starting the server. - Apoorv Naik On Aug. 10, 2017, 11:20 a.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

2017-08-09 Thread Apoorv Naik
/61502/diff/3/ Changes: https://reviews.apache.org/r/61502/diff/2-3/ Testing --- Validated the correctness of results using curl/postman calls, any invalid type name / classification throws 400 now. mvn clean package -Pdist,berkeley-elasticsearch executes successfully Thanks, Apoorv Naik

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

2017-08-09 Thread Apoorv Naik
the correctness of results using curl/postman calls, any invalid type name / classification throws 400 now. mvn clean package -Pdist,berkeley-elasticsearch executes successfully Thanks, Apoorv Naik

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

2017-08-09 Thread Apoorv Naik
error JSON to have a details field which can capture more information if needed. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61502/#review182477 ------

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

2017-08-10 Thread Apoorv Naik
Apoorv Naik On Aug. 9, 2017, 5:51 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61502/ >

Re: Review Request 61667: ATLAS-2044: In-memory filtering after index query

2017-08-16 Thread Apoorv Naik
an package -Pdist (in progress) Thanks, Apoorv Naik

Re: Review Request 61667: ATLAS-2044: In-memory filtering after index query

2017-08-16 Thread Apoorv Naik
b209ecb4 repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/61667/diff/4/ Changes: https://reviews.apache.org/r/61667/diff/3-4/ Testing --- REST and UI testing no longer show the false positive matches. mvn clean packag

Re: Review Request 61541: ATLAS-2037: Unit Test Failure Resolution: testConsumersAreStoppedWhenInstanceBecomesPassive

2017-08-10 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61541/#review182606 --- Ship it! Ship It! - Apoorv Naik On Aug. 10, 2017, 4:18 p.m

Re: Review Request 60852: ATLAS-1947: Search results improvment

2017-07-13 Thread Apoorv Naik
/SearchPipeline.java Line 360 (original), 355 (patched) <https://reviews.apache.org/r/60852/#comment255672> This needs further refinement. Will fix the scoring logic in a separate JIRA - Apoorv Naik On July 13, 2017, 10:14 p.m., Apoorv Naik

Review Request 60852: ATLAS-1947: Search results improvment

2017-07-13 Thread Apoorv Naik
las/web/rest/DiscoveryREST.java dde300e2 Diff: https://reviews.apache.org/r/60852/diff/1/ Testing --- mvn clean package runs successfully Thanks, Apoorv Naik

Re: Review Request 60852: ATLAS-1947: Search results improvment

2017-07-13 Thread Apoorv Naik
ean package runs successfully Thanks, Apoorv Naik

Re: Review Request 60816: Addresses Use of KafkaConsumer in Thread by Implementing Kafka's ShutdownableThread

2017-07-12 Thread Apoorv Naik
contributor review. - Apoorv Naik On July 13, 2017, 5:07 a.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 60852: ATLAS-1947: Search results improvment

2017-07-14 Thread Apoorv Naik
cessfully Thanks, Apoorv Naik

Re: Review Request 60852: ATLAS-1947: Improvements for ATLAS-1880 and some change to AtlasSearchResult

2017-07-14 Thread Apoorv Naik
ava d0da0303 webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 1a9f57a3 webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java dde300e2 Diff: https://reviews.apache.org/r/60852/diff/3/ Testing --- mvn clean package runs successfully Thanks, Apoorv Naik

Review Request 60927: ATLAS-1957: Multi-vertex atlas graph query

2017-07-17 Thread Apoorv Naik
://reviews.apache.org/r/60927/diff/1/ Testing --- Thanks, Apoorv Naik

Re: Review Request 60927: ATLAS-1957: Multi-vertex atlas graph query

2017-07-17 Thread Apoorv Naik
/ClassificationSearchProcessor.java Lines 184 (patched) <https://reviews.apache.org/r/60927/#comment255971> TODO: The multi-vertex query will be used here - Apoorv Naik On July 17, 2017, 10:31 p.m., Apoorv Naik

Review Request 60922: ATLAS-1925: Misc bugfixes for ATLAS-1880

2017-07-17 Thread Apoorv Naik
/atlas/discovery/SearchProcessor.java 1a2d997b Diff: https://reviews.apache.org/r/60922/diff/1/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Review Request 60923: ATLAS-1956: Search results should include the filter criteria attributes

2017-07-17 Thread Apoorv Naik
--- Tested using curl calls, response contains the attributes present in the filter criteria mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-20 Thread Apoorv Naik
/SearchProcessor.java Line 56 (original), 56 (patched) <https://reviews.apache.org/r/60980/#comment256520> Should we add all solr reserved characters here ? + - && || ! ( ) { } [ ] ^ " ~ * ? : / Otherwise overall it looks good. - Apoorv Naik On July 21, 2017

Review Request 61100: Hooks to include atlas-intg jar

2017-07-24 Thread Apoorv Naik
a4e4d0f9 Diff: https://reviews.apache.org/r/61100/diff/1/ Testing --- mvn clean package -DskipTests -Pdist copies the atlas-intg*.jar to the dependency folder under target Thanks, Apoorv Naik

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-19 Thread Apoorv Naik
false - Apoorv Naik On July 19, 2017, 6:40 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 60927: ATLAS-1957: Multi-vertex atlas graph query

2017-07-19 Thread Apoorv Naik
ter. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60927/#review180908 --- On July 17, 2017, 10:31 p.

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-19 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60980/#review180964 --- Ship it! Ship It! - Apoorv Naik On July 19, 2017, 6:40 p.m

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-19 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60980/#review181000 --- Ship it! Ship It! - Apoorv Naik On July 19, 2017, 9:59 p.m

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-28 Thread Apoorv Naik
date https://reviews.apache.org/media/uploaded/files/2017/06/22/f3558280-60bd-49dd-92c6-c1176f86bc70__hive_table-date.json Hive Table Like https://reviews.apache.org/media/uploaded/files/2017/06/22/f07517dd-1c6c-4d2d-8bfd-3d494506b23c__hive_table-like.json Type and tag https://reviews.apache.org/media/uploaded/files/2017/06/22/83768696-aa5c-4c08-a776-143753eb4548__type-tag.json Thanks, Apoorv Naik

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-28 Thread Apoorv Naik
/titan/query/TitanGraphQuery.java Lines 175 (patched) <https://reviews.apache.org/r/60159/#comment253753> This should be offset + limit - Apoorv Naik On June 28, 2017, 9:18 p.m., Apoorv Naik wrote: > > --- > This is a

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-28 Thread Apoorv Naik
l), 77 (patched) <https://reviews.apache.org/r/60159/#comment253751> This should be offset + limit - Apoorv Naik On June 28, 2017, 9:18 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 60603: ATLAS-1906: Support for custom header(s) in AtlasClient

2017-07-04 Thread Apoorv Naik
matically generated e-mail. To reply, visit: https://reviews.apache.org/r/60603/#review179558 ------- On July 3, 2017, 5:16 p.m., Apoorv Naik wrote: > > ---

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-28 Thread Apoorv Naik
/06/22/d6e54af0-f27f-4c6f-b9d3-4e3a0eb258ac__hive_table-date_2.json Hive table date https://reviews.apache.org/media/uploaded/files/2017/06/22/f3558280-60bd-49dd-92c6-c1176f86bc70__hive_table-date.json Hive Table Like https://reviews.apache.org/media/uploaded/files/2017/06/22/f07517dd-1c6c-4d2d-8bfd-3d494506b23c__hive_table-like.json Type and tag https://reviews.apache.org/media/uploaded/files/2017/06/22/83768696-aa5c-4c08-a776-143753eb4548__type-tag.json Thanks, Apoorv Naik

Re: Review Request 60627: ATLAS-1906 :- Atlas client should support setting hadoop-jwt token in header

2017-07-05 Thread Apoorv Naik
g/r/60627/#comment254476> Does it make sense to add a check in the callAPI to maybe log a warning if knox is enabled and no cookie is set ? Also where is **isKnoxSsoEnabled** used ? - Apoorv Naik On July 5, 2017, 2:37 p.m., Nixon Rod

Review Request 61437: Basic Search TWiki

2017-08-04 Thread Apoorv Naik
Thanks, Apoorv Naik

Review Request 61233: Default error page for Atlas web endpoints

2017-07-28 Thread Apoorv Naik
://reviews.apache.org/r/61233/diff/1/ Testing --- Tested with UI interaction, any invalid request now lands on error.jsp Thanks, Apoorv Naik

Re: Review Request 61246: ATLAS-2008: basic-search: updated Gremlin query used in tag-attribute filtering to use bind variables

2017-07-31 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61246/#review181838 --- Ship it! Ship It! - Apoorv Naik On July 30, 2017, 6:53 p.m

Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

2017-08-01 Thread Apoorv Naik
fo => LOG.debug - Apoorv Naik On Aug. 1, 2017, 11:07 a.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 61375: Fix Maven warnings ATLAS-2015

2017-08-02 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61375/#review182013 --- Ship it! Ship It! - Apoorv Naik On Aug. 2, 2017, 10:47 a.m

Re: Review Request 61370: ATLAS-2014: populate createdBy, updatedBy fields on type create and update

2017-08-02 Thread Apoorv Naik
in a test. Only init() can be confusing. repository/src/test/java/org/apache/atlas/repository/store/graph/v1/InverseReferenceUpdateV1Test.java Line 107 (original), 110 (patched) <https://reviews.apache.org/r/61370/#comment257826> init => initContext or initRequestContext - Apoorv Naik

Review Request 61502: ATLAS-2025: Validation on type name and classification

2017-08-08 Thread Apoorv Naik
: https://reviews.apache.org/r/61502/diff/1/ Testing --- Validated the correctness of results using curl/postman calls, any invalid type name / classification throws 400 now. mvn clean package -Pdist,berkeley-elasticsearch executes successfully Thanks, Apoorv Naik

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

2017-08-08 Thread Apoorv Naik
other check - Apoorv Naik On Aug. 8, 2017, 5:16 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 61747: [ATLAS-2059]: Update test-patch.sh script for PreCommit-ATLAS-Build jenkins job

2017-08-18 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61747/#review183254 --- Ship it! Ship It! - Apoorv Naik On Aug. 18, 2017, 6:11 p.m

Re: Review Request 61667: ATLAS-2044: In-memory filtering after index query

2017-08-16 Thread Apoorv Naik
an package -Pdist (in progress) Thanks, Apoorv Naik

Re: Review Request 61667: ATLAS-2044: In-memory filtering after index query

2017-08-16 Thread Apoorv Naik
s.apache.org/r/61667/diff/1-2/ Testing --- REST and UI testing no longer show the false positive matches. mvn clean package -Pdist (in progress) Thanks, Apoorv Naik

Re: Review Request 61762: [ATLAS-2062]: Add flag to disable v1 gremlin search API using atlas-application property

2017-08-18 Thread Apoorv Naik
/web/resources/MetadataDiscoveryResource.java Line 76 (original), 83 (patched) <https://reviews.apache.org/r/61762/#comment259287> Inject configuration here instead. - Apoorv Naik On Aug. 18, 2017, 11:01 p.m., Sarath Subramanian

Review Request 61764: ATLAS-2061: Entity, Tag filter fetches empty results when applied on an enum attribute.

2017-08-18 Thread Apoorv Naik
://reviews.apache.org/r/61764/diff/1/ Testing --- UI and REST tests give correct results Thanks, Apoorv Naik

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-21 Thread Apoorv Naik
st nested query generation fix webapp/src/main/webapp/WEB-INF/web.xml Lines 36 (patched) <https://reviews.apache.org/r/60159/#comment252736> Accidental change - Apoorv Naik On June 22, 2017, 5:24 a.m., Apoorv Naik wrote: > >

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-26 Thread Apoorv Naik
e.json Hive table (date comparison) https://reviews.apache.org/media/uploaded/files/2017/06/22/d6e54af0-f27f-4c6f-b9d3-4e3a0eb258ac__hive_table-date_2.json Hive table date https://reviews.apache.org/media/uploaded/files/2017/06/22/f3558280-60bd-49dd-92c6-c1176f86bc70__hive_table-date.json Hive Table Like https://reviews.apache.org/media/uploaded/files/2017/06/22/f07517dd-1c6c-4d2d-8bfd-3d494506b23c__hive_table-like.json Type and tag https://reviews.apache.org/media/uploaded/files/2017/06/22/83768696-aa5c-4c08-a776-143753eb4548__type-tag.json Thanks, Apoorv Naik

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

2017-09-13 Thread Apoorv Naik
/ Testing --- Tested via scripts and network call timing in Chrome/Firefox. Thanks, Apoorv Naik

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

2017-09-13 Thread Apoorv Naik
in Chrome/Firefox. Thanks, Apoorv Naik

Re: Review Request 62127: ATLAS-2118: Basic search contains issue

2017-09-14 Thread Apoorv Naik
) - repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 1cb2249d Diff: https://reviews.apache.org/r/62127/diff/3/ Changes: https://reviews.apache.org/r/62127/diff/2-3/ Testing --- UI and REST calls work as expected now Thanks, Apoorv Naik

Review Request 62359: Atlas client enhancement for import call

2017-09-15 Thread Apoorv Naik
/java/org/apache/atlas/utils/TestResourceFileUtils.java PRE-CREATION Diff: https://reviews.apache.org/r/62359/diff/1/ Testing --- Performed an import against a local instance of Atlas from test code Thanks, Apoorv Naik

Re: Review Request 62416: ATLAS-2121: Case sensitivity for tag/type name search with index

2017-09-19 Thread Apoorv Naik
/1-2/ Testing --- UI and REST calls work as expected. Thanks, Apoorv Naik

Review Request 62416: ATLAS-2121: Case sensitivity for tag/type name search with index

2017-09-19 Thread Apoorv Naik
/atlas/discovery/ClassificationSearchProcessor.java 1d4815df repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 970cd28e Diff: https://reviews.apache.org/r/62416/diff/1/ Testing --- UI and REST calls work as expected. Thanks, Apoorv Naik

Review Request 62401: ATLAS-2138: Admin import calls in Atlas client

2017-09-18 Thread Apoorv Naik
/AtlasBaseClient.java 602831a2 repository/src/test/java/org/apache/atlas/utils/TestResourceFileUtils.java PRE-CREATION Diff: https://reviews.apache.org/r/62401/diff/1/ Testing --- Successful import from test code Thanks, Apoorv Naik

Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

2017-09-22 Thread Apoorv Naik
Thanks, Apoorv Naik

Re: Review Request 62491: ATLAS-2151: Surrounding brace fix for multiple filters on same attribute

2017-09-22 Thread Apoorv Naik
teTime"] } { "typeName": "hive_table", "excludeDeletedEntities": true, "classification" : "", "query": "", "limit": 10, "offset": 0, "entityFilters": { "attributeName": "createTime", "operator": "neq", "attributeValue": "1491248917103" }, "tagFilters": null, "attributes": ["createTime"] } ``` Verified from logs that the index query is enclosed within braces for multi-filter attribute query and not when there's only one attribute (single) filter Verified the results from REST calls (as UI doesn't support this use case) Thanks, Apoorv Naik

Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

2017-09-20 Thread Apoorv Naik
/62455/diff/1/ Testing --- mvn clean package -Dberkeley-elasticsearch went through fine Build was done 3-4 times to ensure that the concurrency tests passed every time Thanks, Apoorv Naik

Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

2017-09-20 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62455/#review185837 --- Will update the code per the review comments - Apoorv Naik

Re: Review Request 62127: ATLAS-2118: Basic search contains issue

2017-09-13 Thread Apoorv Naik
/ Testing --- UI and REST calls work as expected now Thanks, Apoorv Naik

Review Request 62338: ATLAS-2091: Special tokenizer character shouldn't be included in index query

2017-09-14 Thread Apoorv Naik
. The logs indicate that the attribute will not be processed by index Thanks, Apoorv Naik

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

2017-09-13 Thread Apoorv Naik
/SearchProcessor.java ddf117fa Diff: https://reviews.apache.org/r/62129/diff/5/ Changes: https://reviews.apache.org/r/62129/diff/4-5/ Testing --- UI and REST calls working as expected now. Thanks, Apoorv Naik

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

2017-09-13 Thread Apoorv Naik
mail. To reply, visit: https://reviews.apache.org/r/62129/#review185363 ------- On Sept. 14, 2017, 2:32 a.m., Apoorv Naik wrote: > > --- > This is an automatically gener

Re: Review Request 62338: ATLAS-2091: Special tokenizer character shouldn't be included in index query

2017-09-14 Thread Apoorv Naik
operator should match the provided value as is (user will most likely enter a regex for LIKE) - Apoorv Naik On Sept. 14, 2017, 6:43 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 62127: ATLAS-2118: Basic search contains issue

2017-09-14 Thread Apoorv Naik
operator should match the provided value as is (user will most likely enter a regex for LIKE) - Apoorv Naik On Sept. 14, 2017, 4:37 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 62338: ATLAS-2091: Special tokenizer character shouldn't be included in index query

2017-09-14 Thread Apoorv Naik
> On Sept. 14, 2017, 7:34 p.m., Apoorv Naik wrote: > > This should be extended for suffix regex matches too. And LIKE operator > > should match the provided value as is (user will most likely enter a regex > > for LIKE) Oops, commented on wr

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

2017-09-13 Thread Apoorv Naik
: https://reviews.apache.org/r/62129/diff/3-4/ Testing --- UI and REST calls working as expected now. Thanks, Apoorv Naik

Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

2017-09-21 Thread Apoorv Naik
was done 3-4 times to ensure that the concurrency tests passed every time Thanks, Apoorv Naik

Review Request 62491: ATLAS-2151: Surrounding brace fix for multiple filters on same attribute

2017-09-21 Thread Apoorv Naik
ntities": true, "classification" : "", "query": "", "limit": 10, "offset": 0, "entityFilters": { "attributeName": "createTime", "operator": "neq", "attributeValue": "1491248917103" }, "tagFilters": null, "attributes": ["createTime"] } ``` Verified from logs that the index query is enclosed within braces for multi-filter attribute query and not when there's only one attribute (single) filter Verified the results from REST calls (as UI doesn't support this use case) Thanks, Apoorv Naik

Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

2017-09-22 Thread Apoorv Naik
--- mvn clean package -Dberkeley-elasticsearch went through fine Build was done 3-4 times to ensure that the concurrency tests passed every time Thanks, Apoorv Naik

Re: Review Request 61670: ATLAS-1880: Integration tests for the search functionality

2017-10-02 Thread Apoorv Naik
/61670/diff/4/ Changes: https://reviews.apache.org/r/61670/diff/3-4/ Testing --- mvn clean package executes successfully Test runs from IDE successfully Thanks, Apoorv Naik

Review Request 62758: ATLAS-2184: IsNull/NotNull bugfixes

2017-10-03 Thread Apoorv Naik
/diff/1/ Testing --- UI/REST calls works as expected, no 500s encountered Thanks, Apoorv Naik

Review Request 62875: ATLAS-2201: Test consistency and dependency upgrade

2017-10-10 Thread Apoorv Naik
package executes successfully with new changes Thanks, Apoorv Naik

Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2

2017-10-13 Thread Apoorv Naik
"guid/", HttpMethod.DELETE, Response.Status.NO_CONTENT); public void deleteRelationshipByGuid(String guid) throws AtlasServiceException { callAPI(API_V2.DELETE_RELATIONSHIP_BY_GUID, AtlasRelationship.class, null, guid); } ``` - Apoorv Naik On Oct. 13

Re: Review Request 62889: ATLAS-1757 POM changes

2017-10-16 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62889/#review188191 --- Ship it! Ship It! - Apoorv Naik On Oct. 11, 2017, 1:43 p.m

Re: Review Request 62984: ATLAS-2210 Get and Delete Relationships in AtlasClientV2

2017-10-16 Thread Apoorv Naik
allAPI(API_V2.DELETE_RELATIONSHIP_BY_GUID, null, null, guid); } ``` This should work. - Apoorv Naik On Oct. 13, 2017, 6:48 p.m., Andrew Hulbert wrote: > > --- > This is an automatically generated e-mail.

Re: Question about PRs and workflow

2017-10-13 Thread Apoorv Naik
Hey Andrew, Thanks for your interest in Atlas, the best way to contribute is to file JIRAs and then open a corresponding code review on Reviewboard. Currently we don’t follow the Github PR model for Atlas. > On Oct 13, 2017, at 8:52 AM, Andrew Hulbert wrote: > > Hi,

Review Request 62110: ATLAS-2115: Fix Regression on Basic search

2017-09-06 Thread Apoorv Naik
/1/ Testing --- Tested via scripts and network call timing in Chrome/Firefox. Thanks, Apoorv Naik

Re: [ANNOUNCE] New Committer: Sharmadha Sainath

2017-09-08 Thread Apoorv Naik
Congratulations Sharmadha. On 9/8/17, 10:29 AM, "Sarath Subramanian" wrote: >Congratulations Sharmadha! > > >Regards, >Sarath Subramanian > >On Thu, Sep 7, 2017 at 4:49 PM, Madhan Neethiraj wrote: > >> Atlas community, >> >> >> >> Apache Atlas PMC has

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-09-08 Thread Apoorv Naik
less it exceeds 10 - Apoorv Naik On Sept. 1, 2017, 9:50 a.m., David Radley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

2017-09-06 Thread Apoorv Naik
repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java fc973e6f Diff: https://reviews.apache.org/r/62129/diff/1/ Testing --- UI and REST calls working as expected now. Thanks, Apoorv Naik

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

2017-09-06 Thread Apoorv Naik
> On Sept. 6, 2017, 11:17 p.m., Apoorv Naik wrote: > > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > > Lines 329 (patched) > > <https://reviews.apache.org/r/62110/diff/2/?file=1816688#file1816688line329> > > > > I think

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

2017-09-06 Thread Apoorv Naik
. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62110/#review184744 --- On Sept. 6, 2017, 6:07 a.m.,

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

2017-09-06 Thread Apoorv Naik
d5e39236 repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java fc973e6f Diff: https://reviews.apache.org/r/62110/diff/2/ Changes: https://reviews.apache.org/r/62110/diff/1-2/ Testing --- Tested via scripts and network call timing in Chrome/Firefox. Thanks, Apoorv Naik

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

2017-09-06 Thread Apoorv Naik
/SearchPredicateUtil.java Lines 329 (patched) <https://reviews.apache.org/r/62110/#comment260958> I think this should be return (value instanceof Collection) && ((Collection) value).contains(attrVal); - Apoorv Naik On Sept. 6, 2017, 11:11 p.m., Apo

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

2017-09-06 Thread Apoorv Naik
g/r/62129/#comment260962> Will do. - Apoorv Naik On Sept. 6, 2017, 11:38 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

2017-09-06 Thread Apoorv Naik
eviews.apache.org/r/62129/#review184749 --- On Sept. 6, 2017, 11:38 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

2017-09-12 Thread Apoorv Naik
/ClassificationSearchProcessor.java 0daab030 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java d5e39236 Diff: https://reviews.apache.org/r/62129/diff/3/ Changes: https://reviews.apache.org/r/62129/diff/2-3/ Testing --- UI and REST calls working as expected now. Thanks, Apoorv Naik

Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search

2017-09-11 Thread Apoorv Naik
Diff: https://reviews.apache.org/r/62110/diff/3/ Changes: https://reviews.apache.org/r/62110/diff/2-3/ Testing --- Tested via scripts and network call timing in Chrome/Firefox. Thanks, Apoorv Naik

Re: Review Request 62129: ATLAS-2117: Basic search issues due to Titan Solr schema

2017-09-11 Thread Apoorv Naik
working as expected now. Thanks, Apoorv Naik

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-09-12 Thread Apoorv Naik
/v1/AtlasTypeDefGraphStoreV1.java Lines 385 (patched) <https://reviews.apache.org/r/61526/#comment261494> Sorry I misread the brackets. This is ok. - Apoorv Naik On Sept. 12, 2017, 12:09 p.m., David Radley

Review Request 62127: ATLAS-2118: Basic search contains issue

2017-09-06 Thread Apoorv Naik
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java d5e39236 Diff: https://reviews.apache.org/r/62127/diff/1/ Testing --- UI and REST calls work as expected now Thanks, Apoorv Naik

Review Request 62585: ATLAS-2179: Split Atlas client library to avoid unnecessary dependencies

2017-09-26 Thread Apoorv Naik
/test.properties PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java ad88c1b3 Diff: https://reviews.apache.org/r/62585/diff/1/ Testing --- compile goes through fine mvn clean package also goes through fine Thanks, Apoorv Naik

Re: Review Request 62585: ATLAS-2179: Split Atlas client library to avoid unnecessary dependencies

2017-09-26 Thread Apoorv Naik
, Apoorv Naik

Re: Review Request 62585: ATLAS-2179: Split Atlas client library to avoid unnecessary dependencies

2017-09-26 Thread Apoorv Naik
--- compile goes through fine mvn clean package also goes through fine QuickStart ran successfully Thanks, Apoorv Naik

Re: Review Request 62568: ATLAS-2174:- Code Improvement & Validations

2017-09-26 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62568/#review186270 --- Ship it! Ship It! - Apoorv Naik On Sept. 26, 2017, 12:01

Re: Review Request 62577: [ATLAS-2176] NegativeSSLAndKerberosTest failing due to error in initialization

2017-09-26 Thread Apoorv Naik
good. repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java Line 121 (original), 122 (patched) <https://reviews.apache.org/r/62577/#comment262751> Spaces instead of tabs - Apoorv Naik On Sept. 26, 2017, 3:06 p.m., Gergo Barna

Review Request 62627: ATLAS-2155: Allow null value comparison for NEQ operation with String attributes

2017-09-27 Thread Apoorv Naik
- repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 18d77ee7 Diff: https://reviews.apache.org/r/62627/diff/1/ Testing --- REST and curl validation mvn clean package was successful as well Thanks, Apoorv Naik

  1   2   3   4   5   6   7   >