Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

2017-08-02 Thread Ashutosh Mestry
://kafka.apache.org/0110/javadoc/org/apache/kafka/clients/consumer/KafkaConsumer.html - Ashutosh Mestry On Aug. 2, 2017, 8:48 a.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 61263: ATLAS-2010: Hook consumer should start consumption after type registry init is complete

2017-08-02 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61263/#review182038 --- Ship it! Ship It! - Ashutosh Mestry On July 31, 2017, 7:07

Review Request 61665: ATLAS-2047: Exception Thrown by Kafka Consumer Ends up Filling Logs Due to Incorrect Handling

2017-08-15 Thread Ashutosh Mestry
the scenarios and verify the fix. **Functional tests** Verified regular notification scenarios. Thanks, Ashutosh Mestry

Re: Review Request 61518: ATLAS-2033: Changed Pretty JSON Generation to Ugly for v1 Entity Serializers

2017-08-09 Thread Ashutosh Mestry
8/09/440a989c-81ea-4653-b896-9d0d51465de4__ugly.json Pretty https://reviews.apache.org/media/uploaded/files/2017/08/09/1cf92e66-2dc6-4ded-a546-f1eaa7dcba36__pretty.json Thanks, Ashutosh Mestry

Re: Review Request 61541: ATLAS-2037: Unit Test Failure Resolution: testConsumersAreStoppedWhenInstanceBecomesPassive

2017-08-10 Thread Ashutosh Mestry
for _NotificationHookConsumerTest_. Thanks, Ashutosh Mestry

Review Request 60722: Fix for: Export of hive_table with fetchType "connected" fails

2017-07-07 Thread Ashutosh Mestry
tests** - Executed existing unit tests. **Functional tests** - Executed standard set of tests. Thanks, Ashutosh Mestry

Re: Review Request 60722: Fix for: Export of hive_table with fetchType "connected" fails

2017-07-10 Thread Ashutosh Mestry
/ Changes: https://reviews.apache.org/r/60722/diff/1-2/ Testing --- **Unit tests** - Executed existing unit tests. **Functional tests** - Executed standard set of tests. Thanks, Ashutosh Mestry

Re: Review Request 60597: ATLAS-1908 : - Updating old Kafka consumer api properties to reflect change in new KafkaConsumer configs for Atlas

2017-07-12 Thread Ashutosh Mestry
) <https://reviews.apache.org/r/60597/#comment255549> Should this be 1000 ms? My thinking is 100 ms will be too short. - Ashutosh Mestry On July 3, 2017, 1:17 p.m., Nixon Rodrigues wrote: > > --- > This is an automatica

Re: Review Request 60857: ATLAS-1950: Import API: Improvement: Specify Supertypes in Import Transforms

2017-07-14 Thread Ashutosh Mestry
Diff: https://reviews.apache.org/r/60857/diff/1/ Testing --- **Unit tests** Unit test verifying this behavior were added. **Functional tests** Regular imports were run. Thanks, Ashutosh Mestry

Re: Review Request 60868: ATLAS-1940 :- Fix to remove duplicate type which causes Atlas server to fails on startup.

2017-07-14 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60868/#review180535 --- Ship it! Ship It! - Ashutosh Mestry On July 14, 2017, 3:13

Re: Review Request 61002: ATLAS-1968: Import File Signature Change

2017-07-20 Thread Ashutosh Mestry
ce.java 92217178 Diff: https://reviews.apache.org/r/61002/diff/2/ Changes: https://reviews.apache.org/r/61002/diff/1-2/ Testing --- **Functional test** Imported ZIP file using the new API. **Unit tests** None. Thanks, Ashutosh Mestry

Re: Review Request 61046: ATLAS-1960: Export, Import & ImportFile APIs EndPoints Handled in HA PASSIVE State

2017-07-21 Thread Ashutosh Mestry
ttps://reviews.apache.org/r/61046/diff/1/ Testing --- **Unit tests** - Updated unit tests. - Executed existing tests. **Function tests** On local VM by changing application property and using debugger to step thru. Thanks, Ashutosh Mestry

Re: Review Request 61046: ATLAS-1960: Export, Import & ImportFile APIs EndPoints Handled in HA PASSIVE State

2017-07-21 Thread Ashutosh Mestry
it tests. - Executed existing tests. **Function tests** On local VM by changing application property and using debugger to step thru. Thanks, Ashutosh Mestry

Re: Review Request 61103: ATLAS-1985 :- Fix URLEncoding while redirecting to Active instance in HA.

2017-07-25 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61103/#review181353 --- Ship it! Ship It! - Ashutosh Mestry On July 25, 2017, 11:30

Re: Review Request 60857: ATLAS-1950: Import API: Improvement: Specify Supertypes in Import Transforms

2017-07-26 Thread Ashutosh Mestry
/diff/3/ Changes: https://reviews.apache.org/r/60857/diff/2-3/ Testing --- **Unit tests** Unit test verifying this behavior were added. **Functional tests** Regular imports were run. Thanks, Ashutosh Mestry

Re: Review Request 60857: ATLAS-1950: Import API: Improvement: Specify Supertypes in Import Transforms

2017-07-19 Thread Ashutosh Mestry
ccedeb14 Diff: https://reviews.apache.org/r/60857/diff/2/ Changes: https://reviews.apache.org/r/60857/diff/1-2/ Testing --- **Unit tests** Unit test verifying this behavior were added. **Functional tests** Regular imports were run. Thanks, Ashutosh Mestry

Review Request 60816: Addresses Use of KafkaConsumer in Thread by Implementing Kafka's ShutdownableThread

2017-07-12 Thread Ashutosh Mestry
/60816/diff/1/ Testing --- **Unit tests** Executed exisiting tests. **Functional tests** - Created entities via Hive. Thanks, Ashutosh Mestry

Review Request 61518: ATLAS-2033: Changed Pretty JSON Generation to Ugly for v1 Entity Serializers

2017-08-08 Thread Ashutosh Mestry
://reviews.apache.org/r/61518/diff/1/ Testing --- **Unit tests** Existing suite. Thanks, Ashutosh Mestry

Review Request 61195: ATLAS-1995: Performance Improvement Using IndexQuery for Attribute-based Entity Lookup

2017-07-27 Thread Ashutosh Mestry
/notification/NotificationHookConsumer.java 51276d3 Diff: https://reviews.apache.org/r/61195/diff/1/ Testing --- **Unit tests** None. **Functional tests** Verified the performance improvement using the _AtlasPerfTracer_. Thanks, Ashutosh Mestry

Review Request 61200: ATLAS-1996: Log4J Default Configuration Updated

2017-07-27 Thread Ashutosh Mestry
-log4j.xml c30403e Diff: https://reviews.apache.org/r/61200/diff/1/ Testing --- **Functional tests** Observed configuration changes in the logs generated. Thanks, Ashutosh Mestry

Re: Review Request 61665: ATLAS-2047: Exception Thrown by Kafka Consumer Ends up Filling Logs Due to Incorrect Handling

2017-08-16 Thread Ashutosh Mestry
pache.org/r/61665/#review183030 --- On Aug. 15, 2017, 4:58 p.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 61665: ATLAS-2047: Exception Thrown by Kafka Consumer Ends up Filling Logs Due to Incorrect Handling

2017-08-16 Thread Ashutosh Mestry
NotificationHookConsumerTest.java a6f58e8 Diff: https://reviews.apache.org/r/61665/diff/2/ Changes: https://reviews.apache.org/r/61665/diff/1-2/ Testing --- **Unit tests** Updated unit tests to reproduce the scenarios and verify the fix. **Functional tests** Verified regular notificati

Review Request 61761: ATLAS-2064: Compressed Messages Posted by Hooks

2017-08-18 Thread Ashutosh Mestry
. **Functional tests** - Simulated scenario where Atlas is on newer version and hooks are on older (uncompressed) version. - Updated hive hook and Atlas to new version and verified hive hook functionality for Atlas. Thanks, Ashutosh Mestry

Re: Review Request 58434: Import API: Improved the API to Update Existing Types Attributes

2017-06-26 Thread Ashutosh Mestry
onal unit tests: _UniqueList_. - Import-Export APIs verified with test file set. Thanks, Ashutosh Mestry

Re: Review Request 61940: ATLAS-2090 : UI - Cache busting for static content (css, js)

2017-09-13 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61940/#review185305 --- Ship it! Ship It! - Ashutosh Mestry On Sept. 13, 2017, 2:11

Re: Review Request 62039: ATLAS-2100: UserProfile & SavedSearch Implementation

2017-09-15 Thread Ashutosh Mestry
ATION webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java 6eadc967 webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 52258e3c webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java c32f36ea webapp/src/main/java/org/apache/atlas/web/util/Servlets.java 4a92763a Diff: https://reviews.apache.org/r/62039/diff/5/ Changes: https://reviews.apache.org/r/62039/diff/4-5/ Testing --- **Deployment** - Copy _0010-base_model.json_ & _0011-user-profile_model.json_ to server location: _/usr/hdp/current/atlas-server/models_ - Deploy _atlas.war_ **Unit tests** Added unit tests for: - _UserProfileService_. **Functional testing** - Verification using CURL calls. - Verification via UI to ensure that internal entities do not show up. Thanks, Ashutosh Mestry

Re: Review Request 62382: ATLAS-2144 Add Knox x-forwarded path to Atlas base URL when Atlas is access via knox proxy

2017-09-18 Thread Ashutosh Mestry
ws.apache.org/r/62382/#comment261877> For my education: What is the implication of this change? - Ashutosh Mestry On Sept. 18, 2017, 1:06 p.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 62039: ATLAS-2100: UserProfile & SavedSearch Implementation

2017-09-16 Thread Ashutosh Mestry
ntityChangeListener.java 6eadc967 webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 52258e3c webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java c32f36ea webapp/src/main/java/org/apache/atlas/web/util/Servlets.java 4a92763a Diff: https://reviews.apache.org/r/62039/diff/7/ Changes: https://reviews.apache.org/r/62039/diff/6-7/ Testing --- **Deployment** - Copy _0010-base_model.json_ & _0011-user-profile_model.json_ to server location: _/usr/hdp/current/atlas-server/models_ - Deploy _atlas.war_ **Unit tests** Added unit tests for: - _UserProfileService_. **Functional testing** - Verification using CURL calls. - Verification via UI to ensure that internal entities do not show up. File Attachments Patch for Master https://reviews.apache.org/media/uploaded/files/2017/09/15/ba9b07c2-5868-4f79-ad51-7d7c9ee39c44__ATLAS-2100-Master-DataAccess.patch Thanks, Ashutosh Mestry

Review Request 62390: ATLAS-2146: Remove Powermock Usage

2017-09-18 Thread Ashutosh Mestry
--- **Unit tests** - Executed impacted unit tests. - Build with tests. Thanks, Ashutosh Mestry

Re: Review Request 62420: ATLAS-2148: Enhancement to Saved Search

2017-09-19 Thread Ashutosh Mestry
d-28f6-487a-8126-aaf6fc8a1028__savedSearch.json saved search for update https://reviews.apache.org/media/uploaded/files/2017/09/19/2b1d4619-65d8-4435-87cb-9b11878a7420__savedSearch-for-update.json Thanks, Ashutosh Mestry

Re: Review Request 62420: ATLAS-2148: Enhancement to Saved Search

2017-09-19 Thread Ashutosh Mestry
s/2017/09/19/f9f6ec2d-28f6-487a-8126-aaf6fc8a1028__savedSearch.json saved search for update https://reviews.apache.org/media/uploaded/files/2017/09/19/2b1d4619-65d8-4435-87cb-9b11878a7420__savedSearch-for-update.json Thanks, Ashutosh Mestry

Review Request 62420: ATLAS-2148: Enhancement to Saved Search

2017-09-19 Thread Ashutosh Mestry
rom the new UI. CURL calls. File Attachments ---- Saved Search JSON https://reviews.apache.org/media/uploaded/files/2017/09/19/f845e2cf-3354-48e4-bfed-76b09a581af2__savedSearch.json Thanks, Ashutosh Mestry

Re: Review Request 62420: ATLAS-2148: Enhancement to Saved Search

2017-09-19 Thread Ashutosh Mestry
views.apache.org/r/62420/diff/2/ Changes: https://reviews.apache.org/r/62420/diff/1-2/ Testing --- **Unit tests** Updated to reflect new logic. **Functional tests** >From the new UI. CURL calls. File Attachments ---- Saved Search JSON https://reviews.apache.org/media/uploaded/files/2017/09/19/f845e2cf-3354-48e4-bfed-76b09a581af2__savedSearch.json Thanks, Ashutosh Mestry

Review Request 62484: ATLAS-2160: Execute Saved Searches

2017-09-21 Thread Ashutosh Mestry
saved/execute/18a21a1b-af61-47c6-a50a-34e8ae81dad3; ``` Diffs - webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java aed82ae0 Diff: https://reviews.apache.org/r/62484/diff/1/ Testing --- **Unit tests** None **Functional tests** Executed APIs using CURL calls. Thanks, Ashutosh Mestry

Re: Review Request 62484: ATLAS-2160: Execute Saved Searches

2017-09-22 Thread Ashutosh Mestry
aed82ae0 Diff: https://reviews.apache.org/r/62484/diff/1/ Testing (updated) --- **Unit tests** Executed existing tests. **Functional tests** Executed APIs using CURL calls. Thanks, Ashutosh Mestry

Re: Review Request 62484: ATLAS-2160: Execute Saved Searches

2017-09-22 Thread Ashutosh Mestry
84/diff/2/ Changes: https://reviews.apache.org/r/62484/diff/1-2/ Testing --- **Unit tests** Executed existing tests. **Functional tests** Executed APIs using CURL calls. Thanks, Ashutosh Mestry

Re: Review Request 62484: ATLAS-2160: Execute Saved Searches

2017-09-22 Thread Ashutosh Mestry
esting --- **Unit tests** Executed existing tests. **Functional tests** Executed APIs using CURL calls. Thanks, Ashutosh Mestry

Re: Review Request 61807: ATLAS-2075: Kafka Messages: Split & Combine Implementation

2017-09-20 Thread Ashutosh Mestry
few of existing unit tests. - Added tests to verify backward compatibility. **Functional tests** - Verified regular flow. - Verified cases: - Case where server is shutdown before all the parts of a message are committed. Thanks, Ashutosh Mestry

Re: Review Request 62039: ATLAS-2100: UserProfile & SavedSearch Implementation

2017-09-14 Thread Ashutosh Mestry
il. To reply, visit: https://reviews.apache.org/r/62039/#review185426 ------- On Sept. 13, 2017, 9:34 p.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-m

Re: Review Request 62255: ATLAS-2129: Addressed Case Where Abrupt Shutdown of Atlas During Import Retains Entities Imported Before Shutdown

2017-09-14 Thread Ashutosh Mestry
://reviews.apache.org/r/62255/diff/1-2/ Testing --- **Unit tests** No new tests added. **Functional tests** Import API tested. Thanks, Ashutosh Mestry

Re: Review Request 62255: ATLAS-2129: Addressed Case Where Abrupt Shutdown of Atlas During Import Retains Entities Imported Before Shutdown

2017-09-14 Thread Ashutosh Mestry
/diff/2-3/ Testing --- **Unit tests** No new tests added. **Functional tests** Import API tested. Thanks, Ashutosh Mestry

Re: Review Request 62255: ATLAS-2129: Addressed Case Where Abrupt Shutdown of Atlas During Import Retains Entities Imported Before Shutdown

2017-09-14 Thread Ashutosh Mestry
(updated) --- **Unit tests** - Executed refactored unit tests. **Functional tests** - Import API tested. - Import validated via UI (on multiple browsers). - Verified abrupt abort scenario. Thanks, Ashutosh Mestry

Re: Review Request 62493: ATLAS-2162 : Add hyperlink for URI formatted attribute value on property table

2017-09-22 Thread Ashutosh Mestry
to a global place, so that this does not get created and initializd each time. - Ashutosh Mestry On Sept. 22, 2017, 7:29 a.m., pratik pandey wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 62382: ATLAS-2144 Add Knox x-forwarded path to Atlas base URL when Atlas is access via knox proxy

2017-09-22 Thread Ashutosh Mestry
/filters/AtlasKnoxSSOAuthenticationFilter.java Lines 425 (patched) <https://reviews.apache.org/r/62382/#comment262352> You could remove this if you don't have corresponding tests. - Ashutosh Mestry On Sept. 22, 2017, 5:32 p.m., Nixon Rodrigues

Re: Review Request 62797: ATLAS-2192: Split Join Messages Improved Logging

2017-10-06 Thread Ashutosh Mestry
://reviews.apache.org/r/62797/diff/1-2/ Testing --- **Unit tests** - Added existing. - Executed existing. **Functional testing** - Executed tests with large messages. Thanks, Ashutosh Mestry

Review Request 62755: ATLAS-2186: Jetty Downgraded to v8

2017-10-03 Thread Ashutosh Mestry
/ Testing --- **Functional** - SSL - Non-SSL **Unit tests** - Existing tests. Thanks, Ashutosh Mestry

Review Request 62797: ATLAS-2192: Split Join Messages Improved Logging

2017-10-05 Thread Ashutosh Mestry
tests with large messages. Thanks, Ashutosh Mestry

Re: Review Request 62957: ATLAS-2195: Addressing Txn Leak During Startup

2017-10-13 Thread Ashutosh Mestry
93d-8f43-5fcaf884c055__create-entity.sh Thanks, Ashutosh Mestry

Re: Review Request 62957: ATLAS-2195: Addressing Txn Leak During Startup

2017-10-13 Thread Ashutosh Mestry
b20ddb13-7300-493d-8f43-5fcaf884c055__create-entity.sh Thanks, Ashutosh Mestry

Re: Review Request 61200: ATLAS-1996: Log4J Default Configuration Updated

2017-09-08 Thread Ashutosh Mestry
changes in the logs generated. Thanks, Ashutosh Mestry

Re: Review Request 61665: ATLAS-2047: Exception Thrown by Kafka Consumer Ends up Filling Logs Due to Incorrect Handling

2017-08-29 Thread Ashutosh Mestry
s://reviews.apache.org/r/61665/diff/2-3/ Testing --- **Unit tests** Updated unit tests to reproduce the scenarios and verify the fix. **Functional tests** Verified regular notification scenarios. Thanks, Ashutosh Mestry

Re: Review Request 61940: ATLAS-2090 : UI - Cache busting for static content (css, js)

2017-09-07 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61940/#review184874 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 28, 2017, 1:22

Re: Review Request 61940: ATLAS-2090 : UI - Cache busting for static content (css, js)

2017-09-07 Thread Ashutosh Mestry
tps://reviews.apache.org/r/61940/#comment261068> Support _require.js_ with _bust_. ```javascript ``` - Ashutosh Mestry On Aug. 28, 2017, 1:22 p.m., keval bhatt wrote: > > --- > This is an automatically g

Re: Review Request 61200: ATLAS-1996: Log4J Default Configuration Updated

2017-09-07 Thread Ashutosh Mestry
--- **Functional tests** Observed configuration changes in the logs generated. Thanks, Ashutosh Mestry

Review Request 62255: ATLAS-2129: Addressed Case Where Abrupt Shutdown of Atlas During Import Retains Entities Imported Before Shutdown

2017-09-12 Thread Ashutosh Mestry
Diff: https://reviews.apache.org/r/62255/diff/1/ Testing --- **Unit tests** No new tests added. **Functional tests** Import API tested. Thanks, Ashutosh Mestry

Review Request 62227: ATLAS-2120: Import API: Type Attribute Type Definition Matched

2017-09-11 Thread Ashutosh Mestry
unit tests added. **Functional tests** - Executed success and failure scenarios. Thanks, Ashutosh Mestry

Review Request 62251: ATLAS-2129: Loss of Imported Data In case of Abrupt Atlas Shutdown

2017-09-12 Thread Ashutosh Mestry
_GraphTransactionInterceptor_ functionality. - Executed existing unit tests. **Functional tests** Import functional tests. Thanks, Ashutosh Mestry

Re: Review Request 62577: [ATLAS-2176] NegativeSSLAndKerberosTest failing due to error in initialization

2017-09-26 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62577/#review186288 --- Ship it! Ship It! - Ashutosh Mestry On Sept. 26, 2017, 3:06

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-28 Thread Ashutosh Mestry
atlas/notification/AtlasNotificationBaseMessage.java Lines 130 (patched) <https://reviews.apache.org/r/62681/#comment263314> Consider encapsulating these methods into separate utility class. - Ashutosh Mestry On Sept. 28, 2017, 11:08 p.m.

Review Request 62691: ATLAS-2089: Upgrade Jetty to Newer Version

2017-09-29 Thread Ashutosh Mestry
, non-SSL, Knox integration. Thanks, Ashutosh Mestry

Re: Review Request 62681: ATLAS-2075: notification enhancement to handle large messages, using compression and multi-part messages

2017-09-29 Thread Ashutosh Mestry
/org/apache/atlas/notification/AbstractNotification.java Lines 204 (patched) <https://reviews.apache.org/r/62681/#comment263565> Consider using Math.Ceil. - Ashutosh Mestry On Sept. 29, 2017, 10:32 p.m., Madhan Neethiraj

Re: Review Request 61807: ATLAS-2075: Kafka Messages: Split & Combine Implementation

2017-09-25 Thread Ashutosh Mestry
cases: - Case where server is shutdown before all the parts of a message are committed. Thanks, Ashutosh Mestry

Review Request 61807: ATLAS-2075: Kafka Messages: Split & Combine Implementation

2017-08-21 Thread Ashutosh Mestry
to verify backward compatibility. **Functional tests** - Verified regular flow. - Verified cases: - Case where server is shutdown before all the parts of a message are committed. Thanks, Ashutosh Mestry

Re: Review Request 61940: ATLAS-2090 : UI - Cache busting for static content (css, js)

2017-08-28 Thread Ashutosh Mestry
& templates are loaded from the server for each build that is deployed. I verified: - Firefox - Chrome Played around with the UI while noting the URLs requested from server. Good thing is that the _bust_ value remains constant across browsers (re-stating the point above). - Ashutosh Me

Re: Review Request 61940: ATLAS-2090 : UI - Cache busting for static content (css, js)

2017-08-28 Thread Ashutosh Mestry
. Is this intentional? If yes, what is the rationale? http://localhost:21000/js/libs/requirejs/require.js - Ashutosh Mestry On Aug. 28, 2017, 1:22 p.m., keval bhatt wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: [VOTE] Release Apache Atlas 0.8.1 - release candidate 1

2017-08-24 Thread Ashutosh Mestry
+1 for the release. Sarath: Thanks for the efforts on the release! I have verified the build and artifacts. I did functional testing on search and Export-Import APIs. ~ ashutosh Ashutosh Mestry (ames...@apache.org) ... I get up each morning determined both to change the world and have one

Re: Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter

2017-08-21 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61552/#review183352 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 11, 2017, 4:25

Re: Review Request 61788: ATLAS-2074: AtlasType.resolveReferences() method made package-private

2017-08-21 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61788/#review183357 --- Ship it! Ship It! - Ashutosh Mestry On Aug. 21, 2017, 6:05

Re: Review Request 62009: ATLAS-2101: Update Implementation to Eliminate Use of Stopwatch

2017-08-31 Thread Ashutosh Mestry
) - graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/database/idassigner/StandardIDPool.java PRE-CREATION Diff: https://reviews.apache.org/r/62009/diff/2/ Changes: https://reviews.apache.org/r/62009/diff/1-2/ Testing --- Thanks, Ashutosh Mestry

Re: Review Request 62039: ATLAS-2100: UserProfile & SavedSearch Implementation

2017-09-01 Thread Ashutosh Mestry
ATION repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java 54d6b40 repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 728d418 repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 52258e3 webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java c32f36e webapp/src/main/java/org/apache/atlas/web/util/Servlets.java 4a92763 Diff: https://reviews.apache.org/r/62039/diff/2/ Changes: https://reviews.apache.org/r/62039/diff/1-2/ Testing --- **Deployment** - Copy _0010-base_model.json_ & _0011-user-profile_model.json_ to server location: _/usr/hdp/current/atlas-server/models_ - Deploy _atlas.war_ **Unit tests** Added unit tests for: - _UserProfileService_. **Functional testing** - Verification using CURL calls. Thanks, Ashutosh Mestry

Review Request 62039: ATLAS-2100: UserProfile & SavedSearch Implementation

2017-09-01 Thread Ashutosh Mestry
ository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java 54d6b40 repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 728d418 repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 52258e3 webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java c32f36e webapp/src/main/java/org/apache/atlas/web/util/Servlets.java 4a92763 Diff: https://reviews.apache.org/r/62039/diff/1/ Testing --- **Deployment** - Copy _0010-base_model.json_ & _0011-user-profile_model.json_ to server location: _/usr/hdp/current/atlas-server/models_ - Deploy _atlas.war_ **Unit tests** Added unit tests for: - _UserProfileService_. **Functional testing** - Verification using CURL calls. Thanks, Ashutosh Mestry

Review Request 62009: ATLAS-2101: Update Implementation to Eliminate Use of Stopwatch

2017-08-30 Thread Ashutosh Mestry
/StandardIDPool.java PRE-CREATION Diff: https://reviews.apache.org/r/62009/diff/1/ Testing --- Thanks, Ashutosh Mestry

Re: Review Request 61665: ATLAS-2047: Exception Thrown by Kafka Consumer Ends up Filling Logs Due to Incorrect Handling

2017-08-30 Thread Ashutosh Mestry
pache.org/r/61665/diff/4-5/ Testing --- **Unit tests** Updated unit tests to reproduce the scenarios and verify the fix. **Functional tests** Verified regular notification scenarios. Thanks, Ashutosh Mestry

Review Request 62957: ATLAS-2195: Addressing Txn Leak During Startup

2017-10-12 Thread Ashutosh Mestry
__create-entity.sh Thanks, Ashutosh Mestry

Re: Review Request 63136: ATLAS-2218: Separate UT and IT in webapp module

2017-10-23 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63136/#review189000 --- Ship it! - Ashutosh Mestry On Oct. 19, 2017, 4:59 a.m

Re: Review Request 63136: ATLAS-2218: Separate UT and IT in webapp module

2017-10-23 Thread Ashutosh Mestry
> On Oct. 23, 2017, 11:08 p.m., Ashutosh Mestry wrote: > > I was able to execute ITs and UTs indepdenently. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63136/#rev

Re: Review Request 63136: ATLAS-2218: Separate UT and IT in webapp module

2017-10-23 Thread Ashutosh Mestry
t; > (Updated Oct. 19, 2017, 4:59 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-2218 > https://issues.apache.org/jira/browse/ATLAS-2218 > > > Repository: atlas > > > Desc

Re: Review Request 63152: ATLAS-2218: TestMetadata.py fix

2017-10-23 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63152/#review188996 --- Ship it! Ship It! - Ashutosh Mestry On Oct. 19, 2017, 4:32

Re: Review Request 64072: ATLAS-2274, ATLAS-2277: search for classification '*' - doesn't honor excludeDeletedEntities=true; fails when typeName filter is specified

2017-11-27 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64072/#review191919 --- Ship it! Ship It! - Ashutosh Mestry On Nov. 26, 2017, 7:34

Re: Review Request 64048: ATLAS-2275: fix for incorrect serialization of date type trait attributes in entity notification

2017-11-23 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64048/#review191809 --- Ship it! Ship It! - Ashutosh Mestry On Nov. 23, 2017, 10:24

Review Request 64721: DSL: Phase 2: Operators and Test Suite

2017-12-19 Thread Ashutosh Mestry
of tests that exercise the implementation. - Updated _QueryProcessTest_ to include additional scenarios. **Functional tests** - Verified scenarios from UI. Thanks, Ashutosh Mestry

Re: Review Request 63721: ATLAS-1964 :UI, Support to resize and order columns in Search table

2017-11-14 Thread Ashutosh Mestry
(patched) <https://reviews.apache.org/r/63721/#comment268565> Where is the file with attributations? - Ashutosh Mestry On Nov. 14, 2017, 6:40 a.m., pratik pandey wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 64476: DSL Implementation using Antlr

2017-12-10 Thread Ashutosh Mestry
up environment to verify various clauses implemented. **Verification** Generated Gremlin queries have been verified using JanusGraph shell customized for Atlas. Thanks, Ashutosh Mestry

Re: Review Request 64476: DSL Implementation using Antlr

2017-12-10 Thread Ashutosh Mestry
nts so far and update. Indeed. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64476/#review193340 --- On Dec. 9, 2017, 1:34 a.m.,

Re: Review Request 64476: DSL Implementation using Antlr

2017-12-11 Thread Ashutosh Mestry
clauses implemented. **Functional testing** - Verified from web UI. - Verified using '_Saved Search_' feature. **Additional verification** Generated Gremlin queries have been verified using JanusGraph shell customized for Atlas. Thanks, Ashutosh Mestry

Re: Review Request 64476: DSL Implementation using Antlr

2017-12-11 Thread Ashutosh Mestry
. - Verified using '_Saved Search_' feature. **Additional verification** Generated Gremlin queries have been verified using JanusGraph shell customized for Atlas. Thanks, Ashutosh Mestry

Re: Review Request 64476: DSL Implementation using Antlr

2017-12-11 Thread Ashutosh Mestry
. **Functional testing** - Verified from web UI. - Verified using '_Saved Search_' feature. **Additional verification** Generated Gremlin queries have been verified using JanusGraph shell customized for Atlas. Thanks, Ashutosh Mestry

Re: Review Request 64476: DSL Implementation using Antlr

2017-12-11 Thread Ashutosh Mestry
** - Verified from web UI. - Verified using '_Saved Search_' feature. **Additional verification** Generated Gremlin queries have been verified using JanusGraph shell customized for Atlas. Thanks, Ashutosh Mestry

Re: Review Request 66899: Large Notification Messages: Avoid Duplicate Processing

2018-05-04 Thread Ashutosh Mestry
d2b3dfdab Diff: https://reviews.apache.org/r/66899/diff/4/ Changes: https://reviews.apache.org/r/66899/diff/3-4/ Testing --- **Unit tests** Additional unit tests to test specific scenarios. Thanks, Ashutosh Mestry

Re: Review Request 66928: Data Migration: Import: Infer Types that Store Edge Ids

2018-05-14 Thread Ashutosh Mestry
tests** Regular flow verified. **[Pre-commit build](https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/404/)** Thanks, Ashutosh Mestry

Re: Review Request 66064: ATLAS-2478 Elasticsearch support broken with JanusGraph 0.2.0

2018-05-07 Thread Ashutosh Mestry
> On April 13, 2018, 12:34 a.m., Ashutosh Mestry wrote: > > Can you please add instructions on how to use this profile? I tried the > > patch today and I am still having trouble getting Atlas up. > > Pierre Padovani wrote: > Let me rebase the patch and make some cha

Re: Review Request 66064: ATLAS-2478 Elasticsearch support broken with JanusGraph 0.2.0

2018-05-07 Thread Ashutosh Mestry
tps://reviews.apache.org/r/66064/#comment284490> This is getting included even when the profile is not selected. - Ashutosh Mestry On May 7, 2018, 9:28 p.m., Pierre Padovani wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 66064: ATLAS-2478 Elasticsearch support broken with JanusGraph 0.2.0

2018-05-07 Thread Ashutosh Mestry
, line 163, in File "./bin/atlas_start.py", line 92, in main Exception: ('Could not find hbase-site.xml in %s. Please set env var HBASE_CONF_DIR to the hbase client conf dir', './target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/hbase/conf') - Ashutosh Mestry On M

Re: Review Request 66064: ATLAS-2478 Elasticsearch support broken with JanusGraph 0.2.0

2018-05-07 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66064/#review202597 --- Ship it! Ship It! - Ashutosh Mestry On May 7, 2018, 9:28

Re: Review Request 66928: Data Migration: Import: Infer Types that Store Edge Ids

2018-05-10 Thread Ashutosh Mestry
/TypesStoringEdgeIdsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/66928/diff/5/ Changes: https://reviews.apache.org/r/66928/diff/4-5/ Testing --- **Unit tests** Additional tests added. **Functional tests** Regular flow verified. Thanks, Ashutosh Mestry

Re: Review Request 66928: Data Migration: Import: Infer Types that Store Edge Ids

2018-05-10 Thread Ashutosh Mestry
. **Functional tests** Regular flow verified. Thanks, Ashutosh Mestry

Re: Review Request 66928: Data Migration: Import: Infer Types that Store Edge Ids

2018-05-11 Thread Ashutosh Mestry
added. **Functional tests** Regular flow verified. **[Pre-commit build](https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/382/)** Thanks, Ashutosh Mestry

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

2018-05-07 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/#review202564 --- Ship it! Ship It! - Ashutosh Mestry On May 4, 2018, 10:55

Re: Review Request 66928: Data Migration: Import: Infer Types that Store Edge Ids

2018-05-20 Thread Ashutosh Mestry
** Additional tests added. **Functional tests** Regular flow verified. **[Pre-commit build](https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/423/)** Thanks, Ashutosh Mestry

Re: Review Request 66928: Data Migration: Import: Infer Types that Store Edge Ids

2018-05-20 Thread Ashutosh Mestry
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66928/#review203462 ------- On May 17, 2018, 8:48 p.m., Ashutosh Mestry wrote: > > --- >

  1   2   3   4   5   6   7   8   9   10   >