Re: [ANNOUNCE] New Committer: Ashutosh Mestry

2017-08-15 Thread David Radley
Congratulations Ashutosh, From: Madhan Neethiraj To: Cc: "ames...@apache.org" Date: 13/08/2017 18:33 Subject:[ANNOUNCE] New Committer: Ashutosh Mestry Atlas community, Apache Atlas PMC has asked Ashutosh

Re: [ANNOUNCE] New Committer: Mandy Chessell

2017-08-16 Thread David Radley
Congratulations Mandy From: Mandy Chessell To: Madhan Neethiraj Cc: dev@atlas.apache.org Date: 15/08/2017 16:40 Subject:Re: [ANNOUNCE] New Committer: Mandy Chessell Thanks Madhan - I am delighted this has happened and

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-16 Thread David Radley
> On Aug. 11, 2017, 11:11 a.m., David Radley wrote: > > distro/src/bin/atlas_config.py > > Lines 71 (patched) > > <https://reviews.apache.org/r/61561/diff/1/?file=1794995#file1794995line71> > > > > I am uncomfortable duplicating the default port values

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-16 Thread David Radley
tps://reviews.apache.org/r/61561/#comment259021> You are passing an empty string as the message. I suggest removing this parameter and hard coding the message in the function. - David Radley On Aug. 15, 2017, 10:08 p.m., Richard Ding

Re: Review Request 61681: [ATLAS-1475]: Create Entity via UI : Currently a simple entity can be associated with any number of complex entities, which seems inconsistent.

2017-08-16 Thread David Radley
ints mention that the attribute is not in the ends in the relationshipDef. - David Radley On Aug. 16, 2017, 8:34 a.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 61568: ATLAS-2003: Add Javadoc format to class summaries

2017-08-15 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61568/#review182940 --- Ship it! Ship It! - David Radley On Aug. 10, 2017, 6:15 p.m

Review Request 61657: ATLAS-2045 Renumber shipped Atlas models

2017-08-15 Thread David Radley
-kafka_model.json addons/models/0080-storm_model.json repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java 42f70111d513217b8fbe73e1416c6c94e91a1b7d Diff: https://reviews.apache.org/r/61657/diff/1/ Testing --- Ran the junits Thanks, David Radley

Re: Review Request 61568: ATLAS-2003: Add Javadoc format to class summaries

2017-08-11 Thread David Radley
/InMemoryJAASConfiguration.java Lines 54 (patched) <https://reviews.apache.org/r/61568/#comment258660> Hi Richard, this looks good - please could you generate the swagger and make sure that it tolerates the markup you have added. - David Radley On Aug. 10, 2017, 6:15 p.m., Richard Ding

Re: Review Request 61566: ATLAS-1867: org.apache.atlas.AtlasClientV2.deleteAtlasTypeDefs gives an exception

2017-08-11 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61566/#review182673 --- Ship it! Ship It! - David Radley On Aug. 10, 2017, 5:56 p.m

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

2017-08-10 Thread David Radley
ing the one in AtlasErrorcode. It is also good practise to have error numbers that can only come from one place in the code - to ease debugging. - David Radley On Aug. 9, 2017, 5:51 p.m., Apoorv Naik wrote: > > --- > This is an autom

Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-08-11 Thread David Radley
not exist to the ClassificationDef. this should fail. 10) Create a ClassificationDef with no entitytypes as a subtype of another ClassificationDef. Ensure that the sub classification can be applied to entities specifed in the parent. Thanks, David Radley

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-11 Thread David Radley
uring startup, how can we tell the polling to cease? - David Radley On Aug. 10, 2017, 5:47 p.m., Richard Ding wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many cardinality gives incorrect relationship attribute value

2017-08-11 Thread David Radley
TH for association relationships. repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java Line 386 (original), 392 (patched) <https://reviews.apache.org/r/61589/#comment258681> this has lost its indentation - David Radley On Aug. 11, 2017, 7:33 a.m.,

Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many cardinality gives incorrect relationship attribute value

2017-08-11 Thread David Radley
/v1/AtlasRelationshipStoreSoftDeleteV1Test.java Line 18 (original), 18 (patched) <https://reviews.apache.org/r/61589/#comment258682> The testing indicated that buuild works with skipIts. Does this means that it breaks some tests asis ? - David Radley On Aug. 11, 2017, 7:33 a.m.,

Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many cardinality gives incorrect relationship attribute value

2017-08-11 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61589/#review182702 --- - David Radley On Aug. 11, 2017, 7:33 a.m., Sarath Subramanian

Re: Committer process

2017-08-14 Thread David Radley
Hi Madhan, That makes sense. I will correct the wiki,thanks, David -- David Radley - Apache Atlas committer From:Madhan Neethiraj <mad...@apache.org> To: David Radley <david...@apache.org> Cc:"dev@atlas.apache.org" <dev@atlas.apache.org> Date:14/

Re: Review Request 61568: ATLAS-2003: Add Javadoc format to class summaries

2017-08-14 Thread David Radley
> On Aug. 11, 2017, 9:22 a.m., David Radley wrote: > > common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java > > Lines 54 (patched) > > <https://reviews.apache.org/r/61568/diff/1/?file=1795060#file1795060line54> > > > > Hi Rich

Re: Review Request 60681: ATLAS-1698 Glossary OMAS API - early Swagger draft

2017-07-07 Thread David Radley
Maven build. Thanks, David Radley

Re: Review Request 58422: Addressed Davids review comments

2017-07-11 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58422/#review180192 --- Ship it! Ship It! - David Radley On July 11, 2017, 2:02 p.m

Re: Review Request 60681: ATLAS-1698 Glossary OMAS API - early Swagger draft

2017-07-10 Thread David Radley
rl and a body - have I missed something? - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60681/#review179998 ------- On July 10, 2017, 9:31 p.m., David Radley wrote: > > -

Re: Review Request 60681: ATLAS-1698 Glossary OMAS API - early Swagger draft

2017-07-10 Thread David Radley
=false. the output is in file:///<>/webapp/target/api/v2/apidocs/index.html where <> is where you ran the Maven build. Thanks, David Radley

Re: Review Request 60970: ATLAS-1901: Tolerate no propogatetags on Relationshipdef

2017-07-19 Thread David Radley
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60970/#review180928 ------- On July 19, 2017, 2:26 p.m., David Radley wrote: > > --- >

Re: Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-20 Thread David Radley
> On July 19, 2017, 3:11 p.m., David Radley wrote: > > addons/models/0080-storm_model.json > > Line 150 (original), 150 (patched) > > <https://reviews.apache.org/r/60938/diff/2/?file=1778156#file1778156line150> > > > > shouldn't this be aggr

Relationships diagnostics

2017-07-21 Thread David Radley
Hi Madhan and Sarath, I am playing with relationships and the glossary models. When I make mistakes I am finding it difficult to work out what I have done wrong or whether there is a bug somewhere. I intend to improve the diagnostics. The error I get back from an incorrect relationship creation

Re: Relationship attributes

2017-07-25 Thread David Radley
this in Jira 1991. I suggest we remove displayText from AtlasRelatedObjectId. I am OK with this suggestion if the above 2 points are addressed. all the best, David. From: Madhan Neethiraj <mad...@apache.org> To: David Radley <david_rad...@uk.ibm.com>, Graham Wallis

Re: Review Request 61088: [ATLAS-1988]: Implement REST API to search for related entities

2017-07-25 Thread David Radley
aults and errors that the user needs to be aware of. webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java Lines 273 (patched) <https://reviews.apache.org/r/61088/#comment256868> I suggest a sort direction would be useful here, maybe defined as an enum that include Ascendi

Review Request 61085: ATLAS-1983: Add relationship cardinality validation

2017-07-24 Thread David Radley
a second which resulted in the error. Thanks, David Radley

Relationship attributes

2017-07-23 Thread David Radley
Hi Madhan, When I see the phrase 'relationship attributes', I am never quite sure whether we are referring to the attributes of an entity that relate to another entity or the attributes of the relationship instance itself. I think the phrase ' relationship attributes' more naturally fits as the

Re: Review Request 60681: ATLAS-1698 Glossary OMAS API - early Swagger draft

2017-07-19 Thread David Radley
webapp/target/api/v2/apidocs/index.html where <> is where you ran the Maven build. Thanks, David Radley

Re: Review Request 60927: ATLAS-1957: Multi-vertex atlas graph query

2017-07-19 Thread David Radley
cases. - David Radley On July 17, 2017, 10:31 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60927/ >

Re: Maven restructure

2017-07-19 Thread David Radley
milar enough with, but just noting we need to understand/decide on best practice for use of -source and -target. Nigel. Nigel Jones, Analytics CTO Office - jon...@uk.ibm.com From: David Radley <david_rad...@uk.ibm.com> To: Graham Wallis <dev@atlas.apache.org> Cc: dev@

Review Request 60970: ATLAS-1901: Tolerate no propogatetags on Relationshipdef

2017-07-19 Thread David Radley
with propogateTags = NONE. Thanks, David Radley

Re: Relationship attributes

2017-07-24 Thread David Radley
ks, Sarath Subramanian On Sun, Jul 23, 2017 at 2:22 AM, David Radley <david_rad...@uk.ibm.com> wrote: > Hi Madhan, > When I see the phrase 'relationship attributes', I am never quite sure > whether we are referring to the attributes of an entity that relate to > another enti

Re: Relationship attributes

2017-07-24 Thread David Radley
hemselves might have attributes, it can be confusing. I was going to suggest ‘relatedEntities’; but ‘relationships’ seems to be good choice. +1 for naming the field as ‘relationships’. Thanks, Madhan On 7/24/17, 12:53 AM, "David Radley" <david_rad...@uk.ibm.com> w

Review Request 61077: ATLAS-1986 Rename relationshipAttributes in Entity to relationships.

2017-07-24 Thread David Radley
a relationship then did a get on the entity to see the new relationships part in the returned json Thanks, David Radley

Re: Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities

2017-07-02 Thread David Radley
(patched) <https://reviews.apache.org/r/60578/#comment254214> atleast => at least entry => Def - David Radley On June 30, 2017, 8:25 p.m., Sarath Subramanian wrote: > > --- > This is an auto

Re: Review Request 60603: ATLAS-1906: Support for custom header(s) in AtlasClient

2017-07-04 Thread David Radley
r a clue as to why they might want to use this method; also it would not expose other low level http control functionality as a side effect. - David Radley On July 3, 2017, 5:16 p.m., Apoorv Naik wrote: > > --- > This is an automatically

Re: Review Request 60285: [ATLAS-1892]: Implement logic to create relationship attributes in AtlasEntityType

2017-07-06 Thread David Radley
we have already use this attribute name . repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java Lines 261 (patched) <https://reviews.apache.org/r/60285/#comment254599> the messages should have message numbers. - David Radley On June

Re: Review Request 60681: ATLAS-1698 Glossary OMAS API - early Swagger draft

2017-07-06 Thread David Radley
is in file:///<>/webapp/target/api/v2/apidocs/index.html where <> is where you ran the Maven build. Thanks, David Radley

Re: [DISCUSS] Restrict AtlasStruct and AtlasClassification attributes to primitive and enum types

2017-06-28 Thread David Radley
Hi, Some thoughts: On relationships having relationships I assume we do not want this. On structs having relationships I was wondering whether we should implement structs as properties in the containing entity - rather than as a separate vertex in the graph. It then becomes an extension to

Fw: [DISCUSS] Restrict AtlasStruct and AtlasClassification attributes to primitive and enum types

2017-06-28 Thread David Radley
Hi, Some thoughts: On relationships having relationships I assume we do not want this. On structs having relationships I was wondering whether we should implement structs as properties in the containing entity - rather than as a separate vertex in the graph. It then becomes an extension to

Re: Review Request 60532: ATLAS-1904

2017-06-29 Thread David Radley
41aac8fb976f15c33765d91f5c2f973b78b232a7 Diff: https://reviews.apache.org/r/60532/diff/1/ Testing --- Ran junits and created a composition relationshipDef as expected. Thanks, David Radley

Re: Review Request 60627: ATLAS-1906 :- Atlas client should support setting hadoop-jwt token in header

2017-07-05 Thread David Radley
essage relate to knox enabled not Kerberos? - David Radley On July 5, 2017, 2:37 p.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

<> AttributeDef string validation

2017-08-08 Thread David Radley
Radley/UK/IBM on 08/08/2017 10:12 - From: David Radley/UK/IBM To: Songqing Ding/Silicon Valley/IBM@IBMUS Cc: Graham Wallis/UK/IBM@IBMGB, Kelvin Lawrence/Austin/IBM@IBMUS, Mandy Chessell/UK/IBM@IBMGB, Nigel L Jones/UK/IBM@IBMGB Date: 08/08/2017 10:12 Subject:Re: Fw: Atlas Jiras

Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation

2017-08-09 Thread David Radley
ps://reviews.apache.org/r/61085/#review181253 ------- On July 24, 2017, 5:18 p.m., David Radley wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

2017-08-09 Thread David Radley
d - so the user has the context of what type is missing / invalid. - David Radley On Aug. 8, 2017, 5:16 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 61247: [ATLAS-1984]: Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-08-07 Thread David Radley
nly doing this checking for legacy cases abnd issuing errors otherwise. - David Radley On July 31, 2017, 3:36 a.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 61688: ATLAS-1836

2017-08-17 Thread David Radley
Start Atlas - check logs there are no errors. Query the typeDefs to check they exist. Thanks, David Radley

Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation

2017-08-17 Thread David Radley
he.org/r/61085/#review183043 --- On July 24, 2017, 5:18 p.m., David Radley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

[DISCUSS] Atlas models

2017-08-18 Thread David Radley
I am adding new models that will be part of Atlas by default. These models are grouped as different areas of metadata. Rather than add over 100 files in the models folder, I propose that we have subfolders of Area0-base, 0100Area1-connectors, 0200Area2-glossary etc and a 1000Hadoop folder

Re: [DISCUSS] Atlas models

2017-08-18 Thread David Radley
I made a mistake in the namings (thanks Mandy for pointing this out) : 0100Area1-connectors should be 0100Area1-assets. I have corrected below On 2017-08-18 10:30, "David Radley"<david...@apache.org> wrote: > I am adding new models that will be part of Atlas by de

Re: Review Request 61688: ATLAS-1836 Add Area 0 models

2017-08-18 Thread David Radley
-CloudPlatformsAndServices.json PRE-CREATION Diff: https://reviews.apache.org/r/61688/diff/4/ Changes: https://reviews.apache.org/r/61688/diff/3-4/ Testing --- Run junits Start Atlas - check logs there are no errors. Query the typeDefs to check they exist. Thanks, David Radley

Re: Review Request 61688: ATLAS-1836 Add Area 0 models

2017-08-17 Thread David Radley
there are no errors. Query the typeDefs to check they exist. Thanks, David Radley

Re: Review Request 61736: ATLAS-2049 Document common standards for OMAS interfaces

2017-08-18 Thread David Radley
b docs/src/site/twiki/index.twiki Lines 61 (patched) <https://reviews.apache.org/r/61736/#comment259248> Might be less ambiguous to remove Atlas from the title. - David Radley On Aug. 18, 2017, 2:55 p.m., Nigel Jones wrote: > >

Re: Review Request 60272: ATLAS-1891 Additional Validation checks for RelationshipDefs

2017-06-26 Thread David Radley
e enum is policed as a valid value by Atlas normal procssing there is no additional valition we need to do for propagaeTags - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60272/#review178862 -

Re: Review Request 60272: ATLAS-1891 Additional Validation checks for RelationshipDefs

2017-06-26 Thread David Radley
atest patch should get rid of the edges. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60272/#review178857 ------

Re: Review Request 60272: ATLAS-1891 Additional Validation checks for RelationshipDefs

2017-06-26 Thread David Radley
- this fails Delete an entityDef that has a relationshipdef - this fails Create a relationship with an endpoint name as a reserved word - this fails Thanks, David Radley

Review Request 60457: ATLS-1899

2017-06-27 Thread David Radley
--- ran junits created a relationshipDef with different types and names created a relationshipDef with ends contianing the same names and types. checked the trace to see that it was as expected in both cases. Thanks, David Radley

Re: Review Request 62109: [ATLAS-2116] : Implement tag propagation using relationships

2017-09-14 Thread David Radley
erver-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java Lines 95 (patched) <https://reviews.apache.org/r/62109/#comment261722> same server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java Lines 105 (patched) <https://reviews.apache.org/r

Tag propagation and classification entityTypes

2017-09-15 Thread David Radley
Hi Madhan and Sarath, It occurs to me that we are introducing 2 new definitions around classifications that require the code to traverse around the graph. - classificationDefs now have entityTypes to restrict the entities that they can be applied to. This requires us to check entity and

Review Request 62405: ATLAS2031 Allow AtlasClassificationDef entitytypes removal

2017-09-19 Thread David Radley
of EntityC , try to apply the classificaiton to it . It should fail 4) update the classification to have an empty list of classifications. 5) Repeat step 3 and it should now work. Thanks, David Radley

Tag propagation

2017-09-20 Thread David Radley
Hi Madhan and Sarath, We had a good discussion yesterday around tag propagation. To summarize: 1- Madhan was keen that we do not allow the removal of entityTypes from ClassificationDefs, if there are any instances of that classification applied to that entityType or any of its subtypes. I will

Re: Review Request 62109: [ATLAS-2116] : Implement tag propagation using relationships

2017-09-20 Thread David Radley
static - passing in the gremlinQueryProvider. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Lines 454 (patched) <https://reviews.apache.org/r/62109/#comment262138> I suggest we put out the exception message here - David Radley On Sept

Re: Review Request 62405: ATLAS2031 Allow AtlasClassificationDef entitytypes removal

2017-09-21 Thread David Radley
-010ebf265a6b__ATLAS2031.patch Thanks, David Radley

Re: Review Request 62463: ATLAS1836 Add Area 0 models

2017-10-08 Thread David Radley
--- Start Atlas and get the types to check they have been added. Thanks, David Radley

Re: Review Request 62463: ATLAS1836 Add Area 0 models

2017-10-04 Thread David Radley
--- Start Atlas and get the types to check they have been added. Thanks, David Radley

Re: [ANNOUNCE] Java 8 as minimum requirement for Apache Atlas 1.0.0 (master)

2017-10-04 Thread David Radley
Hi Madhan, I think this is a sensible move. I like the fact you have told the dev list so they can raise an concerns with this approach. I notice the reason for us needing to go to Java 8 was due to a Jetty library upgrade- which has just been reverted. I moved up to java 8 and the latest build

Re: Review Request 62846: ATLAS1839 Add area 3 types for glossary

2017-10-10 Thread David Radley
and retrieved them using postman Thanks, David Radley

Review Request 62846: ATLAS1839 Add area 3 types for glossary

2017-10-09 Thread David Radley
-SemanticAssignment.json PRE-CREATION addons/models/0300-Area3-SubjectArea/0380-SpineObjects.json PRE-CREATION Diff: https://reviews.apache.org/r/62846/diff/1/ Testing --- started Atlas with the types and retrieved them using postman Thanks, David Radley

Re: Review Request 60681: ATLAS-1698 Glossary OMAS API - early Swagger draft

2017-10-10 Thread David Radley
where <> is where you ran the Maven build. Thanks, David Radley

Re: Review Request 60681: ATLAS-1698 Glossary OMAS API - early Swagger draft

2017-10-10 Thread David Radley
/diff/8/ Changes: https://reviews.apache.org/r/60681/diff/7-8/ Testing --- generated the swagger by running mvn clean install -DskipTests -DskipEnunciate=false. the output is in file:///<>/webapp/target/api/v2/apidocs/index.html where <> is where you ran the Maven build. Th

Re: Review Request 62846: ATLAS1839 Add area 3 types for glossary

2017-10-10 Thread David Radley
and retrieved them using postman Thanks, David Radley

Review Request 62872: ATLAS2200 Correct Area 0 model for keyPattern attribute

2017-10-10 Thread David Radley
--- ATLAS2200 Correct Area 0 model for keyPattern attribute Diffs - addons/models/-Area0/0017-ExternalIdentifiers_model.json 3a3bb339 Diff: https://reviews.apache.org/r/62872/diff/1/ Testing --- used postman to ensure that the change had occurred. Thanks, David Radley

Re: Review Request 60681: ATLAS-1698 Glossary OMAS API - early Swagger draft

2017-10-06 Thread David Radley
an the Maven build. Thanks, David Radley

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-09-08 Thread David Radley
> > > > NPE when 's' is null as above - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/#review184375 --- On Sept. 1, 2017, 9:

Fw: [ANNOUNCE] New Committer: Sharmadha Sainath

2017-09-08 Thread David Radley
Congratulations Sharmadha, all the best, David. - Forwarded by David Radley/UK/IBM on 08/09/2017 10:27 - From: Madhan Neethiraj <mad...@apache.org> To: <dev@atlas.apache.org> Cc: <sharmad...@apache.org> Date: 08/09/2017 00:49 Subject:[ANNOU

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-09-08 Thread David Radley
. To reply, visit: https://reviews.apache.org/r/61526/#review184373 ------- On Sept. 1, 2017, 9:50 a.m., David Radley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61526/ >

Re: Review Request 62244: ATLAS2058 Add description to attributedefs and relationship enddefs

2017-09-13 Thread David Radley
an we include descriptions for existing attributes and > > relationshipEndDefs for out of the box models as part of this JIRA? > > David Radley wrote: > I think it is better to separate the putting values into the models into > separate Jiras. We can then use those Jiras to re

Re: Review Request 62244: ATLAS2058 Add description to attributedefs and relationship enddefs

2017-09-13 Thread David Radley
an we include descriptions for existing attributes and > > relationshipEndDefs for out of the box models as part of this JIRA? > > David Radley wrote: > I think it is better to separate the putting values into the models into > separate Jiras. We can then use those Jiras to re

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-09-13 Thread David Radley
to update an entity type that does not exist to the ClassificationDef. this should fail. Thanks, David Radley

Re: Review Request 62244: ATLAS2058 Add description to attributedefs and relationship enddefs

2017-09-13 Thread David Radley
an we include descriptions for existing attributes and > > relationshipEndDefs for out of the box models as part of this JIRA? > > David Radley wrote: > I think it is better to separate the putting values into the models into > separate Jiras. We can then use those Jiras to re

Re: Review Request 62244: ATLAS2058 Add description to attributedefs and relationship enddefs

2017-09-13 Thread David Radley
an we include descriptions for existing attributes and > > relationshipEndDefs for out of the box models as part of this JIRA? > > David Radley wrote: > I think it is better to separate the putting values into the models into > separate Jiras. We can then use those Jiras to re

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-09-12 Thread David Radley
to update an entity type that does not exist to the ClassificationDef. this should fail. Thanks, David Radley

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-09-12 Thread David Radley
ype.getTypeAndAllSubTypes()); > > } > > > > return ret; > > } agreed > On Sept. 1, 2017, 8:18 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > > Lines 450 (patched) > > <

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-09-12 Thread David Radley
nless it exceeds 10 Intellij seems to squash at 5 by default. I manually added the imports in line with this comment. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-09-12 Thread David Radley
mail. To reply, visit: https://reviews.apache.org/r/61526/#review184375 ------- On Sept. 12, 2017, 12:09 p.m., David Radley wrote: > > --- > This is an automatically generated e

Re: Review Request 62244: ATLAS2058 Add description to attributedefs and relationship enddefs

2017-09-12 Thread David Radley
mechanism to introduce description. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62244/#review185223 ------- On

Review Request 62244: ATLAS2058 Add description to attributedefs and relationship enddefs

2017-09-12 Thread David Radley
and a relationship end with a description and then issue getTypeDefs to check they are there. Thanks, David Radley

Review Request 62463: ATLAS1836 Add Area 0 models

2017-09-25 Thread David Radley
the types to check they have been added. Thanks, David Radley

Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues

2017-09-25 Thread David Radley
is Jira comments - as it implies there might still be an issue here. repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java Lines 1246 (patched) <https://reviews.apache.org/r/62455/#comment262535> I suggest we test V2 API code paths as well as V1 API code pat

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-08-21 Thread David Radley
in other threads. > > > > @Sarath - it might be worth removing "public" access to > > AtlasType.resolveReferences() to avoid possible misuse like here. > > David Radley wrote: > This was existing code, in this case we get the classificationtype by > name, but because it is

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-08-21 Thread David Radley
cks between #387 and #392 can be folded into a the following > > statement. Please review: > > > > boolean canApply = entityTypes.isEmpty() || > > entityTypes.contains(entity.getTypeName()) || > > CollectionUtils.containsAny(entityTypes.entityType.getAllSuperType

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-08-21 Thread David Radley
in other threads. > > > > @Sarath - it might be worth removing "public" access to > > AtlasType.resolveReferences() to avoid possible misuse like here. > > David Radley wrote: > This was existing code, in this case we get the classificationtype by > name, but because it is

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-08-21 Thread David Radley
eed to store the entityTypes specified in our supertypes. i.e. > > our parent classificationDefs may specify more entityTypes that we also > > need to allow > > > > This comment doesn't look correct. A classification can have restricted > > entity-t

Re: About the way traits are stored in TitanDB

2017-08-25 Thread David Radley
Hi Benjamin, The way Atlas is architected is that there is one graph for types and a separate graph for the instances. I see a lot of benefits with this design. Having edges between the types allows us to navigate and check types consistency with gremlin queries. It means we can implement

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-08-20 Thread David Radley
nd call the canApplyToEntityType method. It does need the entitytype method though as the canApplyToEntityType needs the entitytype as it input parameter - so it can check supertypes, I think we therefore need the entityType and there is little gained in having a new helper method. - David --- This is an auto

Re: Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-08-20 Thread David Radley
to add an entity type that does not exist to the ClassificationDef. this should fail. 10) Attempt to update an entity type that does not exist to the ClassificationDef. this should fail. Thanks, David Radley

Re: Review Request 61788: ATLAS-2074: AtlasType.resolveReferences() method made package-private

2017-08-21 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61788/#review183363 --- Ship it! Ship It! - David Radley On Aug. 21, 2017, 6:05 p.m

Re: Review Request 61788: ATLAS-2074: AtlasType.resolveReferences() method made package-private

2017-08-21 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61788/#review183364 --- Ship it! Ship It! - David Radley On Aug. 21, 2017, 6:05 p.m

Re: Review Request 61788: ATLAS-2074: AtlasType.resolveReferences() method made package-private

2017-08-21 Thread David Radley
(original), 54 (patched) <https://reviews.apache.org/r/61788/#comment259392> I suggest adding some comments to these methods along the lines of the wording in the Jira. - David Radley On Aug. 21, 2017, 6:05 p.m., Madhan Neethiraj

  1   2   3   4   5   6   >