Congratulations Ashutosh,
From: Madhan Neethiraj
To:
Cc: "ames...@apache.org"
Date: 13/08/2017 18:33
Subject:[ANNOUNCE] New Committer: Ashutosh Mestry
Atlas community,
Apache Atlas PMC has asked Ashutosh
Congratulations Mandy
From: Mandy Chessell
To: Madhan Neethiraj
Cc: dev@atlas.apache.org
Date: 15/08/2017 16:40
Subject:Re: [ANNOUNCE] New Committer: Mandy Chessell
Thanks Madhan - I am delighted this has happened and
> On Aug. 11, 2017, 11:11 a.m., David Radley wrote:
> > distro/src/bin/atlas_config.py
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/61561/diff/1/?file=1794995#file1794995line71>
> >
> > I am uncomfortable duplicating the default port values
tps://reviews.apache.org/r/61561/#comment259021>
You are passing an empty string as the message. I suggest removing this
parameter and hard coding the message in the function.
- David Radley
On Aug. 15, 2017, 10:08 p.m., Richard Ding
ints mention that the attribute is not in the
ends in the relationshipDef.
- David Radley
On Aug. 16, 2017, 8:34 a.m., Sarath Subramanian wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61568/#review182940
---
Ship it!
Ship It!
- David Radley
On Aug. 10, 2017, 6:15 p.m
-kafka_model.json
addons/models/0080-storm_model.json
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
42f70111d513217b8fbe73e1416c6c94e91a1b7d
Diff: https://reviews.apache.org/r/61657/diff/1/
Testing
---
Ran the junits
Thanks,
David Radley
/InMemoryJAASConfiguration.java
Lines 54 (patched)
<https://reviews.apache.org/r/61568/#comment258660>
Hi Richard, this looks good - please could you generate the swagger and
make sure that it tolerates the markup you have added.
- David Radley
On Aug. 10, 2017, 6:15 p.m., Richard Ding
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61566/#review182673
---
Ship it!
Ship It!
- David Radley
On Aug. 10, 2017, 5:56 p.m
ing the one in
AtlasErrorcode. It is also good practise to have error numbers that can only
come from one place in the code - to ease debugging.
- David Radley
On Aug. 9, 2017, 5:51 p.m., Apoorv Naik wrote:
>
> ---
> This is an autom
not exist to the
ClassificationDef. this should fail.
10) Create a ClassificationDef with no entitytypes as a subtype of another
ClassificationDef. Ensure that the sub classification can be applied to
entities specifed in the parent.
Thanks,
David Radley
uring startup, how can we tell the polling to cease?
- David Radley
On Aug. 10, 2017, 5:47 p.m., Richard Ding wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
TH for association relationships.
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Line 386 (original), 392 (patched)
<https://reviews.apache.org/r/61589/#comment258681>
this has lost its indentation
- David Radley
On Aug. 11, 2017, 7:33 a.m.,
/v1/AtlasRelationshipStoreSoftDeleteV1Test.java
Line 18 (original), 18 (patched)
<https://reviews.apache.org/r/61589/#comment258682>
The testing indicated that buuild works with skipIts. Does this means that
it breaks some tests asis ?
- David Radley
On Aug. 11, 2017, 7:33 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/#review182702
---
- David Radley
On Aug. 11, 2017, 7:33 a.m., Sarath Subramanian
Hi Madhan,
That makes sense. I will correct the wiki,thanks, David
--
David Radley - Apache Atlas committer
From:Madhan Neethiraj <mad...@apache.org>
To: David Radley <david...@apache.org>
Cc:"dev@atlas.apache.org" <dev@atlas.apache.org>
Date:14/
> On Aug. 11, 2017, 9:22 a.m., David Radley wrote:
> > common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java
> > Lines 54 (patched)
> > <https://reviews.apache.org/r/61568/diff/1/?file=1795060#file1795060line54>
> >
> > Hi Rich
Maven build.
Thanks,
David Radley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58422/#review180192
---
Ship it!
Ship It!
- David Radley
On July 11, 2017, 2:02 p.m
rl and
a body - have I missed something?
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60681/#review179998
-------
On July 10, 2017, 9:31 p.m., David Radley wrote:
>
> -
=false.
the output is in file:///<>/webapp/target/api/v2/apidocs/index.html
where <> is where you ran the Maven build.
Thanks,
David Radley
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60970/#review180928
-------
On July 19, 2017, 2:26 p.m., David Radley wrote:
>
> ---
>
> On July 19, 2017, 3:11 p.m., David Radley wrote:
> > addons/models/0080-storm_model.json
> > Line 150 (original), 150 (patched)
> > <https://reviews.apache.org/r/60938/diff/2/?file=1778156#file1778156line150>
> >
> > shouldn't this be aggr
Hi Madhan and Sarath,
I am playing with relationships and the glossary models. When I make
mistakes I am finding it difficult to work out what I have done wrong or
whether there is a bug somewhere. I intend to improve the diagnostics. The
error I get back from an incorrect relationship creation
this in Jira
1991. I suggest we remove displayText from AtlasRelatedObjectId.
I am OK with this suggestion if the above 2 points are addressed.
all the best, David.
From: Madhan Neethiraj <mad...@apache.org>
To: David Radley <david_rad...@uk.ibm.com>, Graham Wallis
aults and errors that the user needs to be aware of.
webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java
Lines 273 (patched)
<https://reviews.apache.org/r/61088/#comment256868>
I suggest a sort direction would be useful here, maybe defined as an enum
that include Ascendi
a second which resulted in the
error.
Thanks,
David Radley
Hi Madhan,
When I see the phrase 'relationship attributes', I am never quite sure
whether we are referring to the attributes of an entity that relate to
another entity or the attributes of the relationship instance itself. I
think the phrase ' relationship attributes' more naturally fits as the
webapp/target/api/v2/apidocs/index.html
where <> is where you ran the Maven build.
Thanks,
David Radley
milar enough with, but just noting we need to
understand/decide on best practice for use of -source and -target.
Nigel.
Nigel Jones, Analytics CTO Office - jon...@uk.ibm.com
From: David Radley <david_rad...@uk.ibm.com>
To: Graham Wallis <dev@atlas.apache.org>
Cc: dev@
with propogateTags = NONE.
Thanks,
David Radley
ks,
Sarath Subramanian
On Sun, Jul 23, 2017 at 2:22 AM, David Radley <david_rad...@uk.ibm.com>
wrote:
> Hi Madhan,
> When I see the phrase 'relationship attributes', I am never quite sure
> whether we are referring to the attributes of an entity that relate to
> another enti
hemselves might have attributes, it can be confusing.
I was going to suggest ‘relatedEntities’; but ‘relationships’ seems to be
good choice.
+1 for naming the field as ‘relationships’.
Thanks,
Madhan
On 7/24/17, 12:53 AM, "David Radley" <david_rad...@uk.ibm.com> w
a relationship then did a get on the entity to see the new
relationships part in the returned json
Thanks,
David Radley
(patched)
<https://reviews.apache.org/r/60578/#comment254214>
atleast => at least
entry => Def
- David Radley
On June 30, 2017, 8:25 p.m., Sarath Subramanian wrote:
>
> ---
> This is an auto
r a clue as to why they might want to use this method; also it would
not expose other low level http control functionality as a side effect.
- David Radley
On July 3, 2017, 5:16 p.m., Apoorv Naik wrote:
>
> ---
> This is an automatically
we have
already use this attribute name .
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
Lines 261 (patched)
<https://reviews.apache.org/r/60285/#comment254599>
the messages should have message numbers.
- David Radley
On June
is in file:///<>/webapp/target/api/v2/apidocs/index.html
where <> is where you ran the Maven build.
Thanks,
David Radley
Hi,
Some thoughts:
On relationships having relationships
I assume we do not want this.
On structs having relationships
I was wondering whether we should implement structs as properties in the
containing entity - rather than as a separate vertex in the graph. It then
becomes an extension to
Hi,
Some thoughts:
On relationships having relationships
I assume we do not want this.
On structs having relationships
I was wondering whether we should implement structs as properties in the
containing entity - rather than as a separate vertex in the graph. It then
becomes an extension to
essage relate to knox enabled not Kerberos?
- David Radley
On July 5, 2017, 2:37 p.m., Nixon Rodrigues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
Radley/UK/IBM on 08/08/2017 10:12 -
From: David Radley/UK/IBM
To: Songqing Ding/Silicon Valley/IBM@IBMUS
Cc: Graham Wallis/UK/IBM@IBMGB, Kelvin Lawrence/Austin/IBM@IBMUS,
Mandy Chessell/UK/IBM@IBMGB, Nigel L Jones/UK/IBM@IBMGB
Date: 08/08/2017 10:12
Subject:Re: Fw: Atlas Jiras
ps://reviews.apache.org/r/61085/#review181253
-------
On July 24, 2017, 5:18 p.m., David Radley wrote:
>
> ---
> This is an automatically generated e-mail.
d - so the user has the
context of what type is missing / invalid.
- David Radley
On Aug. 8, 2017, 5:16 p.m., Apoorv Naik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
nly doing this checking for legacy cases abnd issuing errors
otherwise.
- David Radley
On July 31, 2017, 3:36 a.m., Sarath Subramanian wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
he.org/r/61085/#review183043
---
On July 24, 2017, 5:18 p.m., David Radley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
I am adding new models that will be part of Atlas by default. These models are
grouped as different areas of metadata. Rather than add over 100 files in the
models folder, I propose that we have subfolders of Area0-base,
0100Area1-connectors, 0200Area2-glossary etc and a 1000Hadoop folder
I made a mistake in the namings (thanks Mandy for pointing this out) :
0100Area1-connectors should be 0100Area1-assets. I have corrected below
On 2017-08-18 10:30, "David Radley"<david...@apache.org> wrote:
> I am adding new models that will be part of Atlas by de
-CloudPlatformsAndServices.json PRE-CREATION
Diff: https://reviews.apache.org/r/61688/diff/4/
Changes: https://reviews.apache.org/r/61688/diff/3-4/
Testing
---
Run junits
Start Atlas - check logs there are no errors.
Query the typeDefs to check they exist.
Thanks,
David Radley
there are no errors.
Query the typeDefs to check they exist.
Thanks,
David Radley
b
docs/src/site/twiki/index.twiki
Lines 61 (patched)
<https://reviews.apache.org/r/61736/#comment259248>
Might be less ambiguous to remove Atlas from the title.
- David Radley
On Aug. 18, 2017, 2:55 p.m., Nigel Jones wrote:
>
>
e
enum is policed as a valid value by Atlas normal procssing there is no
additional valition we need to do for propagaeTags
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60272/#review178862
-
atest patch should get
rid of the edges.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60272/#review178857
------
- this fails
Delete an entityDef that has a relationshipdef - this fails
Create a relationship with an endpoint name as a reserved word - this fails
Thanks,
David Radley
---
ran junits
created a relationshipDef with different types and names
created a relationshipDef with ends contianing the same names and types.
checked the trace to see that it was as expected in both cases.
Thanks,
David Radley
Hi Madhan and Sarath,
It occurs to me that we are introducing 2 new definitions around
classifications that require the code to traverse around the graph.
- classificationDefs now have entityTypes to restrict the entities that
they can be applied to. This requires us to check entity and
of EntityC , try to apply the classificaiton to it . It
should fail
4) update the classification to have an empty list of classifications.
5) Repeat step 3 and it should now work.
Thanks,
David Radley
Hi Madhan and Sarath,
We had a good discussion yesterday around tag propagation. To summarize:
1- Madhan was keen that we do not allow the removal of entityTypes from
ClassificationDefs, if there are any instances of that classification
applied to that entityType or any of its subtypes. I will
static - passing in the gremlinQueryProvider.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Lines 454 (patched)
<https://reviews.apache.org/r/62109/#comment262138>
I suggest we put out the exception message here
- David Radley
On Sept
-010ebf265a6b__ATLAS2031.patch
Thanks,
David Radley
---
Start Atlas and get the types to check they have been added.
Thanks,
David Radley
---
Start Atlas and get the types to check they have been added.
Thanks,
David Radley
Hi Madhan,
I think this is a sensible move. I like the fact you have told the dev
list so they can raise an concerns with this approach. I notice the reason
for us needing to go to Java 8 was due to a Jetty library upgrade- which
has just been reverted. I moved up to java 8 and the latest build
and retrieved them using postman
Thanks,
David Radley
-SemanticAssignment.json
PRE-CREATION
addons/models/0300-Area3-SubjectArea/0380-SpineObjects.json PRE-CREATION
Diff: https://reviews.apache.org/r/62846/diff/1/
Testing
---
started Atlas with the types and retrieved them using postman
Thanks,
David Radley
/diff/8/
Changes: https://reviews.apache.org/r/60681/diff/7-8/
Testing
---
generated the swagger by running mvn clean install -DskipTests
-DskipEnunciate=false.
the output is in file:///<>/webapp/target/api/v2/apidocs/index.html
where <> is where you ran the Maven build.
Th
and retrieved them using postman
Thanks,
David Radley
---
ATLAS2200 Correct Area 0 model for keyPattern attribute
Diffs
-
addons/models/-Area0/0017-ExternalIdentifiers_model.json 3a3bb339
Diff: https://reviews.apache.org/r/62872/diff/1/
Testing
---
used postman to ensure that the change had occurred.
Thanks,
David Radley
an the Maven build.
Thanks,
David Radley
> >
> > NPE when 's' is null
as above
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61526/#review184375
---
On Sept. 1, 2017, 9:
Congratulations Sharmadha,
all the best, David.
- Forwarded by David Radley/UK/IBM on 08/09/2017 10:27 -
From: Madhan Neethiraj <mad...@apache.org>
To: <dev@atlas.apache.org>
Cc: <sharmad...@apache.org>
Date: 08/09/2017 00:49
Subject:[ANNOU
. To reply, visit:
https://reviews.apache.org/r/61526/#review184373
-------
On Sept. 1, 2017, 9:50 a.m., David Radley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61526/
>
an we include descriptions for existing attributes and
> > relationshipEndDefs for out of the box models as part of this JIRA?
>
> David Radley wrote:
> I think it is better to separate the putting values into the models into
> separate Jiras. We can then use those Jiras to re
an we include descriptions for existing attributes and
> > relationshipEndDefs for out of the box models as part of this JIRA?
>
> David Radley wrote:
> I think it is better to separate the putting values into the models into
> separate Jiras. We can then use those Jiras to re
to update an entity type that does not exist to the
ClassificationDef. this should fail.
Thanks,
David Radley
an we include descriptions for existing attributes and
> > relationshipEndDefs for out of the box models as part of this JIRA?
>
> David Radley wrote:
> I think it is better to separate the putting values into the models into
> separate Jiras. We can then use those Jiras to re
an we include descriptions for existing attributes and
> > relationshipEndDefs for out of the box models as part of this JIRA?
>
> David Radley wrote:
> I think it is better to separate the putting values into the models into
> separate Jiras. We can then use those Jiras to re
to update an entity type that does not exist to the
ClassificationDef. this should fail.
Thanks,
David Radley
ype.getTypeAndAllSubTypes());
> > }
> >
> > return ret;
> > }
agreed
> On Sept. 1, 2017, 8:18 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
> > Lines 450 (patched)
> > <
nless it exceeds 10
Intellij seems to squash at 5 by default. I manually added the imports in line
with this comment.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61
mechanism to introduce description.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62244/#review185223
-------
On
and a relationship end with
a description and then issue getTypeDefs to check they are there.
Thanks,
David Radley
the types to check they have been added.
Thanks,
David Radley
is Jira comments - as it implies there might still be
an issue here.
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java
Lines 1246 (patched)
<https://reviews.apache.org/r/62455/#comment262535>
I suggest we test V2 API code paths as well as V1 API code pat
cks between #387 and #392 can be folded into a the following
> > statement. Please review:
> >
> > boolean canApply = entityTypes.isEmpty() ||
> > entityTypes.contains(entity.getTypeName()) ||
> > CollectionUtils.containsAny(entityTypes.entityType.getAllSuperType
in other threads.
> >
> > @Sarath - it might be worth removing "public" access to
> > AtlasType.resolveReferences() to avoid possible misuse like here.
>
> David Radley wrote:
> This was existing code, in this case we get the classificationtype by
> name, but because it is
eed to store the entityTypes specified in our supertypes. i.e.
> > our parent classificationDefs may specify more entityTypes that we also
> > need to allow
> >
> > This comment doesn't look correct. A classification can have restricted
> > entity-t
Hi Benjamin,
The way Atlas is architected is that there is one graph for types and a
separate graph for the instances. I see a lot of benefits with this
design. Having edges between the types allows us to navigate and check
types consistency with gremlin queries. It means we can implement
nd call the
canApplyToEntityType method.
It does need the entitytype method though as the canApplyToEntityType needs the
entitytype as it input parameter - so it can check supertypes, I think we
therefore need the entityType and there is little gained in having a new helper
method.
- David
---
This is an auto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61788/#review183363
---
Ship it!
Ship It!
- David Radley
On Aug. 21, 2017, 6:05 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61788/#review183364
---
Ship it!
Ship It!
- David Radley
On Aug. 21, 2017, 6:05 p.m
(original), 54 (patched)
<https://reviews.apache.org/r/61788/#comment259392>
I suggest adding some comments to these methods along the lines of the
wording in the Jira.
- David Radley
On Aug. 21, 2017, 6:05 p.m., Madhan Neethiraj
so end up with the Area... content not being able to load as one of
the type names has already been used.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62030/#review
was there, byt issuing a get for all typedefs
Thanks,
David Radley
message
8) Attempt to update the classificationdef to add . this update works.
9) Attempt to add an entity type that does not exist to the ClassificationDef.
this should fail.
10) Attempt to update an entity type that does not exist to the
ClassificationDef. this should fail.
Thanks,
David
in other threads.
> >
> > @Sarath - it might be worth removing "public" access to
> > AtlasType.resolveReferences() to avoid possible misuse like here.
>
> David Radley wrote:
> This was existing code, in this case we get the classificationtype by
> name, but because it is
-CREATION
addons/models/-Area0/0090-CloudPlatformsAndServices.json PRE-CREATION
Diff: https://reviews.apache.org/r/62463/diff/3/
Changes: https://reviews.apache.org/r/62463/diff/2-3/
Testing
---
Start Atlas and get the types to check they have been added.
Thanks,
David Radley
ollow on Jira to update the documentation to document the new Maven
command lines.
repository/pom.xml
Lines 35 (patched)
<https://reviews.apache.org/r/62889/#comment264845>
I think this results in the warning when I apply the patch. : 1 line adds
whitespace errors.
Hi Madhan,
Thanks for sharing this. Unfortunately I am still getting errors. Any
thoughts ?
I get this in the application log when I issue a rest call.
2017-11-28 12:32:11,055 INFO - [main:] ~ Not running setup per
configuration atlas.server.run.setup.on.start.
ions to build & run Atlas in dev environment
David,
Did your REST API call return failure? I see the exception in my env too,
but didn’t see any issues in using Atlas.
Thanks,
Madhan
On 11/28/17, 4:37 AM, "David Radley" <david_rad...@uk.ibm.com> wrote:
Hi Madhan,
1 - 100 of 466 matches
Mail list logo