Re: [jira] [Updated] (ATLAS-1752) Atlas Group mapping for ranger doesn't work if using kerberos authentication

2017-08-02 Thread Graham Wallis
Has something odd happened to the JIRA entry for ATLAS-1752? When I click the link it doesn't show up. Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44-1962

Review Request 61375: Fix Maven warnings ATLAS-2015

2017-08-02 Thread Graham Wallis
: https://reviews.apache.org/r/61375/diff/1/ Testing --- Built with mvn clean install -Pdist,berkeley-elasticsearch with none of the previous warnings Thanks, Graham Wallis

Re: Review Request 58422: Addressed Davids review comments

2017-07-11 Thread Graham Wallis
/diff/3/ Changes: https://reviews.apache.org/r/58422/diff/2-3/ Testing --- Manually tested Thanks, Graham Wallis

Re: Review Request 60681: ATLAS-1698 Glossary OMAS API - early Swagger draft

2017-07-11 Thread Graham Wallis
, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44-1962-815356Tie: 7-245356 From: David Radley <david_rad...@uk.ibm.com> To: Madhan Neethiraj <mad...@apach

Re: Review Request 58422: Addressed Davids review comments

2017-07-11 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58422/#review178961 ------- On May 4, 2017, 10:52 a.m., Graham Wallis wrote: > >

Re: Maven restructure

2017-07-19 Thread Graham Wallis
e may be harder to identify (than the compile errors from the previous option) and would not enable any exploitation of Java 8 features in the Atlas modules still built under ‘J7’. Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com

Re: Review Request 60927: ATLAS-1957: Multi-vertex atlas graph query

2017-07-19 Thread Graham Wallis
rtex or Collection to multiQuery(). graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1AtlasMultiVertexQuery.java Lines 396 (patched) <https://reviews.apache.org/r/60927/#comment256253> Should this be accepting (and transforming) an edges parameter? - Gr

Test failure in GraphBackedMetadataRepositoryTest

2017-07-27 Thread Graham Wallis
is not case sensitive; but I can't see why else it would fail? Does anyone have any insight as to where to dig? Thanks in advance. Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel

Re: Review Request 61088: [ATLAS-1988]: Implement REST API to search for related entities

2017-07-26 Thread Graham Wallis
http://atlas.apache.org/mail-lists.html Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44-1962-815356Tie: 7-245356 From: ​Muhammad Waris​ <muhammad

Re: Relationship attributes

2017-07-24 Thread Graham Wallis
Personally I think 'relatedEntities' is clearer. Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44-1962-815356Tie: 7-245356 From: Madhan Neethiraj <

Re: Review Request 62889: ATLAS-1757 POM changes

2017-10-16 Thread Graham Wallis
eviews.apache.org/r/62889/#review187662 --- On Oct. 11, 2017, 1:43 p.m., Graham Wallis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62889/ > ---

Re: Review Request 63041: ATLAS-1757 rebased patch onto current master

2017-10-17 Thread Graham Wallis
(updated) --- Build only at this stage - work in progress Thanks, Graham Wallis

Re: Quick questions on AdaptiveWaiterTest

2017-10-17 Thread Graham Wallis
The difference in behaviour appears to be JDK specific. Sometime I will investigate just out of curiosity. Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44-1962

Review Request 63041: ATLAS-1757 Introduction of janus

2017-10-16 Thread Graham Wallis
bfa79e8101f1de962c26c48e3c71beb8e73b8876 Diff: https://reviews.apache.org/r/63041/diff/1/ Testing --- Build only at this stage Thanks, Graham Wallis

Review Request 62889: ATLAS-1757 POM changes

2017-10-11 Thread Graham Wallis
bfa79e8101f1de962c26c48e3c71beb8e73b8876 Diff: https://reviews.apache.org/r/62889/diff/1/ Testing --- Builds before and after POM changes with no new test failures being introduced. Thanks, Graham Wallis

Re: Review Request 63706: [ATLAS-2256]: Make JanusGraph as the default graph-provider in atlas

2017-11-10 Thread Graham Wallis
> On Nov. 9, 2017, 9:10 p.m., Madhan Neethiraj wrote: > > Ship It! Looks great - thanks for making the change Sarath - Graham --- This is an automatically generated e-mail. To reply, visit:

Re: Unable to start atlas on master

2017-11-15 Thread Graham Wallis
As far as I'm aware Berkeley JE (only, not the other distributions) is under the Apache 2.0 license Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44-1962

Re: Instructions to build & run Atlas in dev environment

2017-11-28 Thread Graham Wallis
Hi Nigel, You need to prevent webapp from excluding the sleepycat jar. It's the mod to webapp/pom.xml that I sent you. Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN

Re: Instructions to build & run Atlas in dev environment

2017-11-28 Thread Graham Wallis
have to wait for lots of ZK timeouts you will need to terminate the dead ZK process in order to clean the distro tree if you want to rebuild. Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley

Re: Instructions to build & run Atlas in dev environment

2017-11-28 Thread Graham Wallis
to localhost:21000. I have not tried to run quick_start yet. Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44-1962-815356Tie: 7-245356 From: Sarath

Re: standalone mode setup

2017-11-29 Thread Graham Wallis
asSetup? Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44-1962-815356Tie: 7-245356 From: Andrew Hulbert <andrew.hulb...@ccri.com> To: dev@a

Re: Instructions to build & run Atlas in dev environment

2017-11-29 Thread Graham Wallis
| janus } x { elastic | solr } x { bdb | hbase-embedded }; the hope being that it should be possible to arrive at a minimal but sufficient set of profiles that keep everyone happy, support all build phases and do not overlap/interfere with one another. Best regards, Graham Graham Wallis IBM

Re: standalone mode setup

2017-11-30 Thread Graham Wallis
=https-3A__github.com_apache_atlas_blob_435fe3fbad0dbb41297cc7af7986d3062704d7ee_intg_src_test_java_org_apache_atlas_TestRelationshipUtilsV2.java=DwIC-g=jf_iaSHvJObTbx-siA1ZOg=Li6zJa6pLsu8dGS1GSW1j00glumVmLp0H5HVkn5QyAA=uGYfCMWgjqaUXSk-wfUH1C8-hAbE5_UwnsqjMzDFkg8=kl8ydAVZBR1oiHt7mrk6PTV0hPkTaXQgG71K8bUl1Zk= Cheers, Andrew On 11/29/2017 05:26 AM, Graham Wallis wrote: > Hi Andrew > > Not sure

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2017-12-05 Thread Graham Wallis
/reviews.apache.org/r/63503/#comment271158> Should we also use 'protected' visibility here to prevent OMAS users setting securedProperties? Or was it just the getter that you want to protect? - Graham Wallis On Nov. 10, 2017, 12:48 p.m., Mandy Chessell wrote: > > ---

Re: Review Request 63462: ATLAS-2245: Update maven dependency to 3.5.0

2017-12-13 Thread Graham Wallis
-2308. - Graham Wallis On Dec. 13, 2017, 11:25 a.m., Nigel Jones wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 63879: ATLAS-2262: updated patch

2017-12-18 Thread Graham Wallis
, 2017, 3:28 p.m., David Radley wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > > Lines 1029 (patched) > > <https://reviews.apache.org/r/63879/diff/3-4/?file=1897765#file1897765line1049> > > >

Re: Review Request 63879: ATLAS-2262 patch updated

2017-12-18 Thread Graham Wallis
/ Testing --- Build with test enabled, using Janus graph provider Thanks, Graham Wallis

Re: java & Maven versions are now checked in build - ATLAS-2245

2017-12-20 Thread Graham Wallis
Nigel, Many thanks for sorting this and for the additional information on configuring IntelliJ. Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44-1962-815356

Review Request 63909: ATLAS-2232 - Remove source and target directives now at java8

2017-11-17 Thread Graham Wallis
. mvn clean mvn install -DskipTests mvn package -DskipTests -DskipEnunciate=false Thanks, Graham Wallis

Re: Review Request 63892: [ATLAS-2264]: Update JanusGraph version to 0.2.0

2017-11-17 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63892/#review191319 --- Please see my question on the JIRA - Graham Wallis On Nov. 16

Re: Review Request 63879: ATLAS-2262 Fix intermittent relationship failures

2017-11-16 Thread Graham Wallis
grap provider Thanks, Graham Wallis

Review Request 63879: ATLAS-2262 Fix intermittent relationship failures

2017-11-16 Thread Graham Wallis
/graph/v1/AtlasRelationshipStoreV1Test.java d207a6958ab9dce0bd9f8e08c8e49232ab7d2e8a Diff: https://reviews.apache.org/r/63879/diff/1/ Testing --- Build with full tests with Janus graph provider Thanks, Graham Wallis

Re: Review Request 63909: ATLAS-2232 - Remove source and target directives now at java8

2017-11-20 Thread Graham Wallis
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63909/#review191366 --- On Nov. 17, 2017, 12:52 p.m., Graham Wallis wrote: > > ---

Re: Review Request 63879: ATLAS-2262 Fix intermittent relationship failures

2017-11-20 Thread Graham Wallis
Thanks, Graham Wallis

Re: Review Request 63879: ATLAS-2262 Fix intermittent relationship failures

2017-11-20 Thread Graham Wallis
#review191362 --- On Nov. 16, 2017, 3:14 p.m., Graham Wallis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63879/ &g

Re: Review Request 63462: ATLAS-2245: Update maven dependency to 3.5.0

2017-11-21 Thread Graham Wallis
it and applied it a local branch and it built fine - although that didn't prove much in my case as my dev envt satisfies both conditions. - Graham Wallis On Nov. 3, 2017, 7:56 a.m., Nigel Jones wrote: > > --- > This is an automatically ge

Re: Review Request 63909: ATLAS-2232 - Remove source and target directives now at java8

2017-11-21 Thread Graham Wallis
> > error: diamond operator is not supported in -source 1.5 > > [WARNING] [ENUNCIATE] [javac] List ret= > > new ArrayList<>(); > > [WARNING] [ENUNCIATE] [javac] > > ^ > > [WARNING] [EN

Re: Review Request 63451: [ATLAS-2240]: Fix and enable unit test testConcurrentCalls()

2017-11-08 Thread Graham Wallis
problem with duplicated schema vertices in the graph schema. - Graham Wallis On Oct. 31, 2017, 10:21 p.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 63879: ATLAS-2262 Fix intermittent relationship failures

2017-12-08 Thread Graham Wallis
> what happens for delete edges. > > Graham Wallis wrote: > I think they can be ignored. > > David Radley wrote: > I thought Atlas tried to reuse soft deleted edges - so we avoid creating > multiple duplicate deleted edges. Good point - but from a quick look t

Review Request 64449: ATLAS-2305: update RAT

2017-12-08 Thread Graham Wallis
.patch Update version of RAT Diffs - pom.xml 56982912aa26dfaaf010bd3cf8e53754efd2c25c Diff: https://reviews.apache.org/r/64449/diff/1/ Testing --- Full build with tests using JanusGraph provider Thanks, Graham Wallis

Re: Review Request 63879: ATLAS-2262: updated patch

2017-12-08 Thread Graham Wallis
/ Testing (updated) --- Build with test enabled, using Janus graph provider Thanks, Graham Wallis

Re: Review Request 64435: ATLAS-2301: fix for concurrent modification error while creating audit record

2017-12-08 Thread Graham Wallis
o give to the audit? - Graham Wallis On Dec. 8, 2017, 3:20 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 64442: ATLAS-2304: fix Relationship search API to work TinkerPop3

2017-12-08 Thread Graham Wallis
same set of vertices in both cases? - Graham Wallis On Dec. 8, 2017, 7:13 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: compilation error in master

2017-12-01 Thread Graham Wallis
reported that clearing their .m2 repo was critical to getting a successful build, so I'd like to understand what is going on. Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN

Re: Review Request 64442: ATLAS-2304: fix Relationship search API to work TinkerPop3

2017-12-11 Thread Graham Wallis
> On Dec. 8, 2017, 9:39 a.m., Graham Wallis wrote: > > Just something to check... in TP3 the range() step is non-inclusive at the > > lower bound, i.e. > > > > gremlin> g.V().range(0,3) > > ==>v[1] > > ==>v[2] > > ==>

Re: Review Request 63879: ATLAS-2262 Fix intermittent relationship failures

2017-12-06 Thread Graham Wallis
4bb53cccec537a0a54afb5e8 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java > b6d82dd834b8cc8b3bac630c084b91ac34dd0cec > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > f6a15b695e676bc035ce8336bcce7bacf1852ff9 > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java > b24774d6376765f054022b9220b61769505e488c > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > fd1b6db0c4dd57cd70ba56f49b9c4751f6915858 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java > d207a6958ab9dce0bd9f8e08c8e49232ab7d2e8a > > > Diff: https://reviews.apache.org/r/63879/diff/3/ > > > Testing > --- > > Build with full tests with janus grap provider > > > Thanks, > > Graham Wallis > >

Re: Review Request 63879: ATLAS-2262 Fix intermittent relationship failures

2017-12-06 Thread Graham Wallis
it adds to the overall number of elements processed; some of the original variable names are a bit odd but I was trying to minimise changes. - Graham Wallis On Nov. 20, 2017, 5:15 p.m., Graham Wallis wrote: > > --- > Thi

Review Request 63417: ASTLAS-2242: gremlin3 traversals for discovery service

2017-10-30 Thread Graham Wallis
11980bec24a109cce7ee7b8c5d4a9f3d39ae124a Diff: https://reviews.apache.org/r/63417/diff/1/ Testing --- Built and tested with janus provider Thanks, Graham Wallis

Re: Review Request 62889: ATLAS-1757 POM changes

2017-10-30 Thread Graham Wallis
keOperator:301->runQuery:991 > > » Discovery > > > > GraphBackedDiscoveryServiceTest.testGremlinSearchReturnEdgeIds:247 » > > Discovery > > GraphBackedDiscoveryServiceTest.testGremlinSearchReturnVertexId:236 » > > Dis

Re: Review Request 63041: ATLAS-1757 introduction of JanusGraph 0.1.1

2017-10-30 Thread Graham Wallis
t; following section > > > > ```xml > > > > true > > > > GRAPH-PROVIDER > > titan0 > > > > > &

Re: Review Request 63041: ATLAS-1757 introduction of JanusGraph 0.1.1

2017-10-30 Thread Graham Wallis
, do you think it's safe to > > remove ? > > > > can we move the graph profiles from root pom to graphdb pom or there's > > a reason behind putting it in the main pom ? > > Graham Wallis wrote: > Thanks Apoorv. Agreed - I have wondered about this in the past as well.

Re: Review Request 63041: ATLAS-1757 patch v3

2017-10-25 Thread Graham Wallis
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63041/#review189078 --- On Oct. 24, 2017, 2:26 p.m., Graham Wallis wrote: > > --

Re: Review Request 63041: ATLAS-1757 patch v3

2017-10-25 Thread Graham Wallis
ly, visit: https://reviews.apache.org/r/63041/#review189077 --- On Oct. 24, 2017, 2:26 p.m., Graham Wallis wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 63041: ATLAS-1757 patch v3

2017-10-25 Thread Graham Wallis
well as the case where it is explicitly set to the value that activates the default profile). - Graham --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63041/#review189071 -

Re: Review Request 63041: ATLAS-1757 patch v3

2017-10-24 Thread Graham Wallis
041/diff/3/ Changes: https://reviews.apache.org/r/63041/diff/2-3/ Testing (updated) --- Built with: mvn clean install -DGRAPH-PROVIDER=janus -DskipTests Thanks, Graham Wallis

Review Request 63446: ATLAS-2240 first part of patch

2017-10-31 Thread Graham Wallis
fd87ea4c030cc40f3efc3cc7f0ad27f964f750d8 graphdb/pom.xml 1659b12f1e9c120eab3128cf41c260d0b98918dc pom.xml 3eb252e1874ab985371ae8c4fc9d8bf3fddfdbd8 Diff: https://reviews.apache.org/r/63446/diff/1/ Testing --- Built with titan0 and janus Thanks, Graham Wallis

Re: Review Request 63417: ASTLAS-2242: gremlin3 traversals for discovery service

2017-10-30 Thread Graham Wallis
,1) will pass one traverser. - Graham --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63417/#review189609 --- On Oct. 3

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

2018-05-08 Thread Graham Wallis
16736line709> > > > > why are we leaving in commented out code No valid reason - I wanted to highlight the effect of the change by having the 'before' and 'after' - but if the patch is seen as generally OK I should remove it. - Graham --------

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

2018-05-10 Thread Graham Wallis
- Graham --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/#review202564 --- On May 10, 2018, 1:11 p.m., Graham Wal

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

2018-05-10 Thread Graham Wallis
/repository/store/graph/v1/EntityGraphRetriever.java 183a2f6c0 Diff: https://reviews.apache.org/r/66949/diff/2/ Changes: https://reviews.apache.org/r/66949/diff/1-2/ Testing --- Functional testing of these changes to save reference copies of entities and relationships Thanks, Graham Wallis

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

2018-05-10 Thread Graham Wallis
the logic should check for > > a null homeId and a guid starting character of '-' (or null) we should say > > the guid is not assigned. > > Graham Wallis wrote: > I like that - I wrote the GUID handling change before adding the homeId > system attribute. We could

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

2018-05-10 Thread Graham Wallis
reference copies of entities and relationships Thanks, Graham Wallis

Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

2018-05-04 Thread Graham Wallis
to save reference copies of entities and relationships Thanks, Graham Wallis

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

2018-05-17 Thread Graham Wallis
ps://reviews.apache.org/r/66949/#review203241 ------- On May 10, 2018, 2:52 p.m., Graham Wallis wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

2018-05-16 Thread Graham Wallis
graph mode. The other two issues are just to accommodate the addition of the above and make them consistent. - Graham Wallis On May 15, 2018, 1:35 p.m., Bogdan Sava wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas

2018-05-16 Thread Graham Wallis
d it would be consistent with the others - change then all to setLocalRepositoryXXX() if you prefer). The body of the method should be: return adminAPI.setLocalRepositoryMode(userId, serverName, LocalRepositoryMode.LOCAL_GRAPH_REPOSITORY); - Gra

Re: Review Request 67089: ATLAS-2674 Unable to set an array value for an attribute in the open metadata

2018-05-15 Thread Graham Wallis
. Personally I find the 'rules' to be quite difficult to parse and correlate with the logic in the comments. Would it be possible to lay out the predicates more clearly, e.g. range checking 'element' within the array bounds and current size? - Graham Wallis On May 11, 2018, 2:56 p.m., David Radley wrote

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

2018-05-25 Thread Graham Wallis
reference copies of entities and relationships Thanks, Graham Wallis

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

2018-05-25 Thread Graham Wallis
. Best regards, Graham Graham Wallis IBM Analytics Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44 7741 379735 From: Madhan Neethiraj <mad...@apache.org> To: Graham Wallis <graham_wal...@uk.ibm.com> Cc:

Review Request 67486: ATLAS-2745 EnumDefStore manages defaultValue

2018-06-07 Thread Graham Wallis
-up testing loading Open Metadata types including EnumDefs with default values. Thanks, Graham Wallis

Re: [jira] [Commented] (ATLAS-1773) Create the OMRS Connector for Atlas

2018-06-18 Thread Graham Wallis
dependency and allows Atlas to start correctly. Did you then perform a full, clean build? Best regards, Graham Graham Wallis IBM Analytics Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44 7741 379735 From: "David Radley

Deleting entities and relationships

2018-06-18 Thread Graham Wallis
whether the delete was ultimately soft or hard). I'm not sure how I would get that information that for relationships. Best regards, Graham Graham Wallis IBM Analytics Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44 7741 379735 Unless

Re: Problem deleting edges with 1.0.0 - pre rc

2018-06-01 Thread Graham Wallis
Hi David - I think is already fixed. Best regards, Graham Graham Wallis IBM Analytics Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44 7741 379735 From: David Radley To: dev@atlas.apache.org Date: 01/06/2018 10:55 Subject

HBase 2.0 support in JanusGraph

2018-06-06 Thread Graham Wallis
In response to the recent question about if/when JanusGraph will support HBase 2.0 - I think it is in the JanusGraph 0.3.0 for which there is a release candidate, posted on May 21st. See: https://ibm.ent.box.com/v/janusgraph-release-candidates Best regards, Graham Graham Wallis IBM

Re: HBase 2.0 support in JanusGraph

2018-06-06 Thread Graham Wallis
Hi Madhan I think the 0.3.0 content is listed here: https://github.com/JanusGraph/janusgraph/milestone/4 I am not sure what the timescale is. Best regards, Graham Graham Wallis IBM Analytics Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel

Re: Deleting entities and relationships

2018-07-02 Thread Graham Wallis
to determine from the result/response returned by the delete method whether a delete was hard or soft. Best regards, Graham Graham Wallis IBM Analytics Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44 7741 379735 From: Graham

Re: ATLAS-2569 ATLAS-2571 - commit?

2018-05-01 Thread Graham Wallis
I have just committed both these patches to 1.0.0. Thanks Nigel. Best regards, Graham Graham Wallis IBM Analytics Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44 7741 379735 From: David Radley/UK/IBM To: Nigel L Jones/UK/IBM

Re: Review Request 63041: ATLAS-1757 introduction of JanusGraph 0.1.1

2017-10-27 Thread Graham Wallis
ea3 Diff: https://reviews.apache.org/r/63041/diff/4/ Changes: https://reviews.apache.org/r/63041/diff/3-4/ Testing (updated) --- Build and tested (UT runs) with titan0 and janus providers Thanks, Graham Wallis

Re: Review Request 64943: ATLAS-2332: support for attributes having nested collection datatype

2018-01-05 Thread Graham Wallis
the other returns an Object.class. Should this be consistent across both methods? - Graham Wallis On Jan. 4, 2018, 3:24 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 65033: Advanced Search Documentation Update

2018-01-09 Thread Graham Wallis
nt274146> typo: generated by docs/src/site/twiki/Search-Advanced.twiki Lines 291 (patched) <https://reviews.apache.org/r/65033/#comment274148> typo: clauses are no longer supported docs/src/site/twiki/Search-Basic.twiki Lines 31 (patched) <https://reviews.apache.org/r/65033/#commen

Re: Review Request 65123: ATLAS-2298 - Review of OCF JDBC Connector for Gaian

2018-01-18 Thread Graham Wallis
ect artifactId should be something like atlas-ocf-jdbc depending on nesting of modules. jdbc/pom.xml Lines 9 (patched) <https://reviews.apache.org/r/65123/#comment274980> I think version should be 1.0.0-SNAPSHOT - Graham Wallis On Jan. 18, 2018, 10:09 a.m., Yao Li wrote: > >

Re: [VOTE] Release Apache Atlas version 1.0.0-alpha release candidate 0

2018-01-18 Thread Graham Wallis
code will need to be updated. Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44-1962-815356Tie: 7-245356 From: Madhan Neethiraj <mad...@apache.

Re: Review Request 65178: ATLAS-2370: load solr resources on Windows

2018-01-18 Thread Graham Wallis
> remove getClassLoader() method if not used. > > Graham Wallis wrote: > Hi Sarath - Thanks for spotting this - I was going to update the patch > with getClassLoader removed but I see you have committed it as-is. > Are you sure you don't want me to remove the

Review Request 65218: ATLAS-2377: invalid URI format

2018-01-18 Thread Graham Wallis
in successful creation of quick_start content. Thanks, Graham Wallis

Review Request 65178: ATLAS-2370: load solr resources on Windows

2018-01-16 Thread Graham Wallis
(no profiles specified, no skipTests). Previously all LocalSolr related tests were failing; now passing. Thanks, Graham Wallis

Re: Review Request 65623: ATLAS-2438: fix errors found in sitecheck - https://whimsy.apache.org/site/project/atlas

2018-02-13 Thread Graham Wallis
error in the patch - i.e. the part that is color red in the diff - I think this is due to a tab rather than space characters. I know it's minor but it would be good to remove before committing the patch. Thanks again. - Graham Wallis On Feb. 13, 2018, 4:02 a.m., Selvamohan Neethiraj wrote

Re: Server appears to start, but connections fail with 503

2018-02-14 Thread Graham Wallis
to have started, I can see the Atlas console in the browser (@localhost:21000) ### It is possible to now run quick_start... quick_start.py Best regards, Graham Graham Wallis IBM Analytics Emerging Technology Center Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley

Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-03 Thread Graham Wallis
/EntityGraphRetriever.java 448d03bc069869db85cd86e14021a3fa59b57e33 Diff: https://reviews.apache.org/r/68188/diff/1/ Testing --- Tested with saveRelationshipReferenceCopy between entities that do not exist in the Atlas repository. Thanks, Graham Wallis

Review Request 68165: ATLAS-2803 improvements to toString methods

2018-08-02 Thread Graham Wallis
://reviews.apache.org/r/68165/diff/1/ Testing --- Built and tested with OMRS unit and functional tests Thanks, Graham Wallis

Review Request 68063: ATLAS-2787: remove unwanted OMAG files

2018-07-26 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68063/ --- Review request for atlas and Madhan Neethiraj. Repository: atlas Description

Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-16 Thread Graham Wallis
nerated e-mail. To reply, visit: https://reviews.apache.org/r/68188/#review207015 ------- On Aug. 16, 2018, 1:56 p.m., Graham Wallis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/681

Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-16 Thread Graham Wallis
that do not exist in the Atlas repository. Thanks, Graham Wallis

Re: Review Request 68188: ATLAS-2808: Enable Atlas to support entity proxies

2018-08-17 Thread Graham Wallis
/EntityGraphRetriever.java 52c374564 Diff: https://reviews.apache.org/r/68188/diff/3/ Changes: https://reviews.apache.org/r/68188/diff/2-3/ Testing --- Tested with saveRelationshipReferenceCopy between entities that do not exist in the Atlas repository. Thanks, Graham Wallis

Re: Review Request 68287: ATLAS-2807: Re-evaluate classification propagation during entity delete

2018-08-10 Thread Graham Wallis
that you always want the specified behaviour. - Graham Wallis On Aug. 10, 2018, 2:36 a.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 68412: ATLAS-1773: Atlas OMRS Repository Connector

2018-08-17 Thread Graham Wallis
, instances, reference copies and proxies). Thanks, Graham Wallis

Re: Review Request 68412: ATLAS-1773: Atlas OMRS Repository Connector

2018-08-30 Thread Graham Wallis
p.m., Madhan Neethiraj wrote: > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeDefMapper.java > > Lines 190 (patched) > > <https://reviews.apache.org/r/68412/diff/1/?file=2074624#file2074624line190> &g

Re: Review Request 68412: ATLAS-1773: Atlas OMRS Repository Connector

2018-08-30 Thread Graham Wallis
--------- On Aug. 17, 2018, 2:38 p.m., Graham Wallis wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68412/ >

Re: Review Request 68412: ATLAS-1773: Atlas OMRS Repository Connector

2018-09-04 Thread Graham Wallis
23dc0637a Diff: https://reviews.apache.org/r/68412/diff/3/ Changes: https://reviews.apache.org/r/68412/diff/2-3/ Testing --- Unit Testing (approx 80 tests) and Functional Testing of major operations (creation of types, instances, reference copies and proxies). Thanks, Graham Wallis

Re: Review Request 67797: ATLAS-2771: Add option to exclude internal types when using GET all types using getAllTypeDefs()

2018-07-04 Thread Graham Wallis
> On July 2, 2018, 7:30 a.m., Graham Wallis wrote: > > Do we need a similar filter capability on getAllTypes()? > > Madhan Neethiraj wrote: > Graham - this filter applies for getAllTypeDefs() and > getTypeDefHeaders(). There is no getAllTypes() in TypesREST;

Re: Deleting entities and relationships

2018-07-03 Thread Graham Wallis
, Graham Graham Wallis IBM Analytics Internet: graham_wal...@uk.ibm.com IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN Tel: +44 7741 379735 From: Madhan Neethiraj To: Graham Wallis Cc: "dev@atlas.apache.org" Date: 02/07/2018 23:22 Subject:Re

  1   2   3   4   >