Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-04 Thread Pinal Shah
ps://reviews.apache.org/r/72156/#review219751 ------- On Feb. 25, 2020, 7:11 a.m., Pinal Shah wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-05 Thread Pinal Shah
erm1 1) In search Panel(showing all entities) -> term1 shouln't appear 2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear Thanks, Pinal Shah

Re: Review Request 72174: ATLAS-3600 :- Some System Attribute of Entity filter doesn't work

2020-03-02 Thread Pinal Shah
--- Tested all above 4 system attributes manually. Thanks, Pinal Shah

Review Request 72188: ATLAS-3650 : Basic Search: query of typeName doesn't apply when it has many subTypes(like Asset) in combination with attribute filter

2020-03-03 Thread Pinal Shah
t; Now, Entities with typeName Asset and allSubtypes with guid notnull is coming in result Thanks, Pinal Shah

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-03 Thread Pinal Shah
/EntitySearchProcessor.java Line 99 (original), 99 (patched) <https://reviews.apache.org/r/72156/#comment307949> Handled Non entities (without guid) and internal entities - Pinal Shah On Feb. 25, 2020, 7:11 a.m., Pinal Shah

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-04 Thread Pinal Shah
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/#review219751 --- On Feb. 25, 2020, 7:11 a.m., Pinal Shah wrote: > > --- > This is an automatically gener

Review Request 72174: Some System Attribute of Entity filter doesn't work

2020-02-28 Thread Pinal Shah
/ Testing --- Tested all above 4 system attributes manually. Thanks, Pinal Shah

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-05 Thread Pinal Shah
erm1 1) In search Panel(showing all entities) -> term1 shouln't appear 2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear Thanks, Pinal Shah

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-03-05 Thread Pinal Shah
ng all entities) -> term1 shouln't appear 2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear Thanks, Pinal Shah

Re: Review Request 72188: ATLAS-3650 : Basic Search: query of typeName doesn't apply when it has many subTypes(like Asset) in combination with attribute filter

2020-03-05 Thread Pinal Shah
because this patch is dependent on ATLAS-3618. - Pinal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72188/#review219747 ------

Re: Review Request 72174: Some System Attribute of Entity filter doesn't work

2020-03-01 Thread Pinal Shah
, visit: https://reviews.apache.org/r/72174/#review219691 ------- On Feb. 28, 2020, 12:04 p.m., Pinal Shah wrote: > > --- > This is an automatically gener

Re: Review Request 72174: ATLAS-3600 :- Some System Attribute of Entity filter doesn't work

2020-03-01 Thread Pinal Shah
repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java bb1e9f633 Diff: https://reviews.apache.org/r/72174/diff/1/ Testing --- Tested all above 4 system attributes manually. Thanks, Pinal Shah

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-02-24 Thread Pinal Shah
ation1 to term1 1) In search Panel(showing all entities) -> term1 shouln't appear 2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear Thanks, Pinal Shah

Review Request 72060: ATLAS-3601 No LABEL_DELETE event is audited when last label is deleted.

2020-01-30 Thread Pinal Shah
Thanks, Pinal Shah

Contributor Request

2020-01-30 Thread Pinal Shah
Hi Team, I would like to contribute to the Atlas project, Can you please add me as contributor. Thanks, Pinal Shah

Re: Review Request 72060: ATLAS-3601 No LABEL_DELETE event is audited when last label is deleted.

2020-01-31 Thread Pinal Shah
is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72060/#review219442 --- On Jan. 30, 2020, 12:10 p.m., Pinal Shah wrote: > > ---

Review Request 72076: ATLAS-3606 : Hive Hook: Missing HIVE_PROCESS attribute values

2020-02-03 Thread Pinal Shah
is reflected Thanks, Pinal Shah

Re: Review Request 72076: ATLAS-3606 : Hive Hook: Missing HIVE_PROCESS attribute values

2020-02-03 Thread Pinal Shah
operation 5) IMPORT operation 6) EXPORT operation, here owner is N/A tested by changing user in hive and then creating operation, the owner in hive_process is reflected Thanks, Pinal Shah

Re: Review Request 72127: ATLAS-3615 :- Basic Search : Search with _ALL_ENTITY_TYPES and classification doesn't not fetch any entity associated to that classification

2020-02-18 Thread Pinal Shah
ssue2: 1) tested with values _ALL_ENTITY_TYPES + classification + query(SearchByText) -> shows up correct result Thanks, Pinal Shah

Re: Review Request 72127: ATLAS-3615 :- Basic Search : Search with _ALL_ENTITY_TYPES and classification doesn't not fetch any entity associated to that classification

2020-02-20 Thread Pinal Shah
ssue2: 1) tested with values _ALL_ENTITY_TYPES + classification + query(SearchByText) -> shows up correct result Thanks, Pinal Shah

Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-02-21 Thread Pinal Shah
, returns no result 3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result Thanks, Pinal Shah

Review Request 72156: ATLAS-3618 Entities with no guid appears in search result

2020-02-21 Thread Pinal Shah
, filter: typeName begins_with Atlas Thanks, Pinal Shah

Re: Review Request 72127: ATLAS-3615 :- Basic Search : Search with _ALL_ENTITY_TYPES and classification doesn't not fetch any entity associated to that classification

2020-02-13 Thread Pinal Shah
_ENTITY_TYPES + classification -> result fetches from gremlin and shows up correct result For issue2: 1) tested with values _ALL_ENTITY_TYPES + classification + query(SearchByText) -> shows up correct result Thanks, Pinal Shah

Re: Review Request 72300: ATLAS-3696 : [Business Metadata] No option to check/uncheck Business Metadata field in search results

2020-04-07 Thread Pinal Shah
will rename businessMetadata => businessAttributes - Pinal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72300/#review220241 -----

Re: Review Request 72300: ATLAS-3696 : [Business Metadata] No option to check/uncheck Business Metadata field in search results

2020-04-07 Thread Pinal Shah
; > > Use MapUtils.isNotEmpty. sure - Pinal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72300/#review220240 --- On Apri

Re: Review Request 72300: ATLAS-3696 : [Business Metadata] No option to check/uncheck Business Metadata field in search results

2020-04-07 Thread Pinal Shah
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72300/#review220241 --- On April 1, 2020, 10:43 a.m., Pinal Shah wrote: > > -

Review Request 72396: ATLAS-3746 : _NOT_CLASSIFIED doesn't fetch right results

2020-04-21 Thread Pinal Shah
doesn't make sense** 5) classification = _NOT_CLASSIFIED, classificationFilters -> **results will not show up because classification filter on _NOT_CLASSIFIED classification doesn't make sense** Thanks, Pinal Shah

Re: Review Request 72188: ATLAS-3650 : Basic Search: query of typeName doesn't apply when it has many subTypes(like Asset) in combination with attribute filter

2020-03-13 Thread Pinal Shah
ore, all entities with guid notnull including internal Type(AtlasGlossary) where coming in result --> Now, Entities with typeName Asset and allSubtypes with guid notnull is coming in result Thanks, Pinal Shah

Re: Review Request 72188: ATLAS-3650 : Basic Search: query of typeName doesn't apply when it has many subTypes(like Asset) in combination with attribute filter

2020-03-16 Thread Pinal Shah
) Select Asset 2) Select Guid notNull --> Before, all entities with guid notnull including internal Type(AtlasGlossary) where coming in result --> Now, Entities with typeName Asset and allSubtypes with guid notnull is coming in result Thanks, Pinal Shah

Review Request 72300: ATLAS-3696 : [Business Metadata] No option to check/uncheck Business Metadata field in search results

2020-04-01 Thread Pinal Shah
which has business attribute, the response of basic search will include businessMetadata attributes Thanks, Pinal Shah

Re: Review Request 72280: BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

2020-03-30 Thread Pinal Shah
t; > buildTraitPredict() doesn't handle wildcards in the classification-name > > - like classificationName="*PII". Please review. > > Pinal Shah wrote: > Thanks Madhan, > What if i use __classificationNames which String type, instead of > __traitNames wh

Re: Review Request 72280: BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

2020-03-30 Thread Pinal Shah
, Pinal Shah

Re: Review Request 72280: BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

2020-03-30 Thread Pinal Shah
traitNames which is of List type in graphdb. - Pinal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72280/#review220100 ------

Re: Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

2020-03-31 Thread Pinal Shah
tr.getQualifiedName() will not solve purpose. - Pinal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72253/#review220143 -----

Re: Review Request 72280: ATLAS-3703 : BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

2020-03-31 Thread Pinal Shah
are non indexed Thanks, Pinal Shah

Re: Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

2020-03-31 Thread Pinal Shah
Testing --- Manually tested below scenario: 1) add Entity and Entity Filters 2) add classification Thanks, Pinal Shah

Review Request 72280: BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

2020-03-29 Thread Pinal Shah
attributes are non indexed Thanks, Pinal Shah

Re: Review Request 72280: BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

2020-03-30 Thread Pinal Shah
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72280/#review220100 --- On March 30, 2020, 5:50 a.m., Pinal Shah wrote: > >

Re: Review Request 72280: BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

2020-03-30 Thread Pinal Shah
://reviews.apache.org/r/72280/diff/2/ Changes: https://reviews.apache.org/r/72280/diff/1-2/ Testing --- Manually tested all above cases, except case where attributes are non indexed Thanks, Pinal Shah

Re: Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Pinal Shah
/SearchProcessor.java Line 207 (original), 206 (patched) <https://reviews.apache.org/r/72418/#comment308827> I have added delimeter '|' here , as _classificationNames can have multiple tag names - Pinal Shah On April 22, 2020, 6:56 p.m., Pinal Shah

Re: Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Pinal Shah
efix and suffix with '|' to the classificationName - Pinal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72418/#review220437 -----

Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Pinal Shah
(CASE_INSENSITIVE) 'tag_abc_*' '*_abc*' 'tag_*_*' 'tag*test' Thanks, Pinal Shah

Re: Review Request 72489: ATLAS-3788 : BasicSearch: Classification with System attribute(indexed) filters has pagination issue

2020-05-13 Thread Pinal Shah
e41 repository/src/test/java/org/apache/atlas/discovery/BasicSearchClassificationTest.java PRE-CREATION Diff: https://reviews.apache.org/r/72489/diff/2/ Changes: https://reviews.apache.org/r/72489/diff/1-2/ Testing (updated) --- Manually Tested. Will add Precommit Link. Thanks, Pinal Shah

Review Request 72486: ATLAS-3680 : Change 'Status' from Classification System Attributes to EntityStatus

2020-05-08 Thread Pinal Shah
/Constants.java 3fc13056e repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 74c088c0e Diff: https://reviews.apache.org/r/72486/diff/1/ Testing --- Manually tested Thanks, Pinal Shah

Re: Review Request 72486: ATLAS-3680 : Change 'Status' from Classification System Attributes to EntityStatus

2020-05-11 Thread Pinal Shah
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72486/#review220698 --- On May 8, 2020, 11:21 a.m., Pinal Shah wrote: > >

Review Request 72489: ATLAS-3788 : BasicSearch: Classification with System attribute(indexed) filters has pagination issue

2020-05-11 Thread Pinal Shah
ffs - repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 74c088c0e Diff: https://reviews.apache.org/r/72489/diff/1/ Testing --- Manually Tested Thanks, Pinal Shah

Re: Review Request 72486: ATLAS-3780 : Change 'Status' from Classification System Attributes to EntityStatus

2020-05-11 Thread Pinal Shah
://reviews.apache.org/r/72486/diff/1/ Testing --- Manually tested Thanks, Pinal Shah

Re: Review Request 72489: ATLAS-3788 : BasicSearch: Classification with System attribute(indexed) filters has pagination issue

2020-05-13 Thread Pinal Shah
che/atlas/discovery/BasicSearchClassificationTest.java PRE-CREATION Diff: https://reviews.apache.org/r/72489/diff/3/ Changes: https://reviews.apache.org/r/72489/diff/2-3/ Testing --- Manually Tested. Will add Precommit Link. Thanks, Pinal Shah

Re: Review Request 72489: ATLAS-3788 : BasicSearch: Classification with System attribute(indexed) filters has pagination issue

2020-05-14 Thread Pinal Shah
PRE-CREATION Diff: https://reviews.apache.org/r/72489/diff/3/ Testing (updated) --- Manually Tested. Added test cases. Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1894 Thanks, Pinal Shah

Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

2020-03-20 Thread Pinal Shah
ey Diffs - repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ddd3e60d2 Diff: https://reviews.apache.org/r/72253/diff/1/ Testing --- Manually tested below scenario: 1) add Entity and Entity Filters 2) add classification Thanks, Pinal Shah

Re: Review Request 72533: ATLAS-3802 : BasicSearch: filter, attribute with NEQ operator doesn't match attribute having null values

2020-05-20 Thread Pinal Shah
for below scenarios: 1) Non String Attribute -> index query 2) String Attributes -> graph query 3) pipeSeperated Attributes (classificationNames,labels) -> NOT_CONTAINS operator -> graph query 4) businessMetadata attribute Thanks, Pinal Shah

Re: Review Request 72486: ATLAS-3780 : Change 'Status' from Classification System Attributes to EntityStatus

2020-06-08 Thread Pinal Shah
/AtlasClassificationType.java 4d0179c44 intg/src/main/java/org/apache/atlas/type/Constants.java 3fc13056e Diff: https://reviews.apache.org/r/72486/diff/3/ Changes: https://reviews.apache.org/r/72486/diff/2-3/ Testing --- Manually tested Thanks, Pinal Shah

Re: Review Request 72486: ATLAS-3780 : Change 'Status' from Classification System Attributes to EntityStatus

2020-06-08 Thread Pinal Shah
/ Testing --- Manually tested Thanks, Pinal Shah

Review Request 72567: ATLAS-3782 : Support NOT_CONTAINS operator in basic search

2020-06-04 Thread Pinal Shah
Precommit : Thanks, Pinal Shah

Re: Review Request 72567: ATLAS-3782 : Support NOT_CONTAINS operator in basic search

2020-06-04 Thread Pinal Shah
67/diff/1/ Testing (updated) --- Added testcases Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1952 Thanks, Pinal Shah

Review Request 72562: ATLAS-3823 : BasicSearch: Warning for the Unsupported operator.

2020-06-03 Thread Pinal Shah
(processPipeSeperatedSystemAttributes), So it is removed. Diffs - repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 804c69431 Diff: https://reviews.apache.org/r/72562/diff/1/ Testing --- Thanks, Pinal Shah

Re: Review Request 72562: ATLAS-3823 : BasicSearch: Warning for the Unsupported operator.

2020-06-03 Thread Pinal Shah
/PreCommit-ATLAS-Build-Test/1948/console Thanks, Pinal Shah

Re: Review Request 72610: ATLAS-3850 : Regression, Terms are not getting displayed

2020-06-23 Thread Pinal Shah
ain/resources/solr/core-template/solrconfig.xml ef74a0a45 Diff: https://reviews.apache.org/r/72610/diff/3/ Changes: https://reviews.apache.org/r/72610/diff/2-3/ Testing --- Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1971/console Thanks, Pinal Shah

Re: Review Request 72610: ATLAS-3850 : Regression, Terms are not getting displayed

2020-06-23 Thread Pinal Shah
- repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 4a09b08a4 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 757fcb116 test-tools/src/main/resources/solr/core-template/solrconfig.xml ef74a0a45 Diff: https://reviews.apache.org/r/72610/diff/3/ Testing --- Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1971/console Thanks, Pinal Shah

Review Request 72625: ATLAS-3866 : Relationship search API for hive storage desc throws error code 500

2020-06-28 Thread Pinal Shah
://reviews.apache.org/r/72625/diff/1/ Testing --- Manually tested Precommit : Thanks, Pinal Shah

Re: Review Request 72625: ATLAS-3866 : Relationship search API for hive storage desc throws error code 500

2020-06-29 Thread Pinal Shah
Thanks, Pinal Shah

Re: Review Request 72625: ATLAS-3866 : Relationship search API for hive storage desc throws error code 500

2020-06-29 Thread Pinal Shah
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72625/#review221085 --- On June 29, 2020, 10:49 a.m., Pinal Shah wrote: > > -

Review Request 72627: ATLAS-3867 : Relationship search API should have a provision to fetch custom attributes in search results

2020-06-29 Thread Pinal Shah
/apache/atlas/discovery/EntityDiscoveryService.java b2737af01 webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 076284ec4 Diff: https://reviews.apache.org/r/72627/diff/1/ Testing --- Manually tested Precommit : Thanks, Pinal Shah

Review Request 72610: ATLAS-3850 : Regression, Terms are not getting displayed

2020-06-22 Thread Pinal Shah
/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 757fcb116 Diff: https://reviews.apache.org/r/72610/diff/1/ Testing --- Thanks, Pinal Shah

Re: Review Request 72610: ATLAS-3850 : Regression, Terms are not getting displayed

2020-06-22 Thread Pinal Shah
.apache.org/r/72610/diff/1-2/ Testing --- Thanks, Pinal Shah

Re: Review Request 72610: ATLAS-3850 : Regression, Terms are not getting displayed

2020-06-22 Thread Pinal Shah
mmit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1971/console Thanks, Pinal Shah

Re: Review Request 72567: ATLAS-3782 : Support NOT_CONTAINS operator in basic search

2020-06-25 Thread Pinal Shah
ff: https://reviews.apache.org/r/72567/diff/2/ Changes: https://reviews.apache.org/r/72567/diff/1-2/ Testing --- Added testcases Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1952 Thanks, Pinal Shah

Re: Review Request 72567: ATLAS-3782 : Support NOT_CONTAINS operator in basic search

2020-06-25 Thread Pinal Shah
ff: https://reviews.apache.org/r/72567/diff/3/ Changes: https://reviews.apache.org/r/72567/diff/2-3/ Testing --- Added testcases Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1952 Thanks, Pinal Shah

Re: Review Request 72567: ATLAS-3782 : Support NOT_CONTAINS operator in basic search

2020-06-30 Thread Pinal Shah
Test/1952 Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1983 Thanks, Pinal Shah

Re: Review Request 72567: ATLAS-3782 : Support NOT_CONTAINS operator in basic search

2020-06-30 Thread Pinal Shah
org/r/72567/diff/4/ Testing --- Added testcases Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1952 Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1983 Thanks, Pinal Shah

Re: Review Request 72567: ATLAS-3782 : Support NOT_CONTAINS operator in basic search

2020-06-30 Thread Pinal Shah
67/diff/4/ Testing (updated) --- Added testcases Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1999 Thanks, Pinal Shah

Re: Review Request 72651: ATLAS-3880 : BasicSearch: Multiple type/tag: Log invalid and allow searching valid type/tag names

2020-07-08 Thread Pinal Shah
ated) --- Manually tested Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2033 (In progress) Thanks, Pinal Shah

Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-06 Thread Pinal Shah
/SearchPredicateUtil.java 5069d78c8 Diff: https://reviews.apache.org/r/72646/diff/1/ Testing --- Manually tested Precommit : Thanks, Pinal Shah

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-06 Thread Pinal Shah
/org/apache/atlas/util/SearchPredicateUtil.java 5069d78c8 Diff: https://reviews.apache.org/r/72646/diff/1/ Testing (updated) --- Manually tested Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2011 (Failed in Impala build) Thanks, Pinal Shah

Review Request 72669: ATLAS-3888 : BasicSearch: Multiple type/tag: [Regression], Restrict when tag filters and regex in tag

2020-07-10 Thread Pinal Shah
org/apache/atlas/discovery/SearchContext.java dd24a8cc4 Diff: https://reviews.apache.org/r/72669/diff/1/ Testing --- Manually Tested Precommit : Thanks, Pinal Shah

Re: [VOTE] Release Apache Atlas version 2.1.0 - rc3

2020-07-13 Thread Pinal Shah
+1 for Apache Atlas 2.1.0 rc3 release Validated below: - Build successfully with embedded-hbase-solr. - Creating entities and classification. - Basic/Quick search - Creating Labels and search for them. - Creating custom attributes and search for them. Thanks, Pinal Shah On Mon, Jul 13, 2020

Re: Review Request 72627: ATLAS-3867 : Relationship search API should have a provision to fetch custom attributes in search results

2020-06-30 Thread Pinal Shah
://reviews.apache.org/r/72627/diff/1-2/ Testing --- Manually tested Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1994 Thanks, Pinal Shah

Review Request 72651: ATLAS-3880 : BasicSearch: Multiple type/tag: Log invalid and allow searching valid type/tag names

2020-07-07 Thread Pinal Shah
04e82186b webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 140ed9a6e Diff: https://reviews.apache.org/r/72651/diff/1/ Testing --- Manually tested Precommit : Thanks, Pinal Shah

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-29 Thread Pinal Shah
/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4 Diff: https://reviews.apache.org/r/72646/diff/3/ Testing --- Manually tested Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2011 (Failed in Impala build) Thanks, Pinal Shah

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-29 Thread Pinal Shah
) Thanks, Pinal Shah

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-21 Thread Pinal Shah
/EntityDiscoveryService.java Lines 705 (patched) <https://reviews.apache.org/r/72646/#comment310162> I tested it with 5000 edge vertices. Will vertexTotal() method be efficient than this? - Pinal Shah On July 6, 2020, 9:14 a.m., Pinal Shah

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-21 Thread Pinal Shah
eviews.apache.org/r/72646/#review221273 ------- On July 6, 2020, 9:14 a.m., Pinal Shah wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-21 Thread Pinal Shah
it make difference in performance? - Pinal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/#review221273 ---

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-23 Thread Pinal Shah
rtex, > > attributes)); I have added (v != null && v.property(Constants.GUID_PROPERTY_KEY).isPresent()) for the null check Correct, we dont need extra list, will address it - Pinal --- This is an auto

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-04 Thread Pinal Shah
Diff: https://reviews.apache.org/r/72646/diff/5/ Changes: https://reviews.apache.org/r/72646/diff/4-5/ Testing --- Manually tested Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2011 (Failed in Impala build) Thanks, Pinal Shah

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-31 Thread Pinal Shah
/ Testing --- Manually tested Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2011 (Failed in Impala build) Thanks, Pinal Shah

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-04 Thread Pinal Shah
tested Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2084 Thanks, Pinal Shah