Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation

2017-08-17 Thread David Radley
> On Aug. 16, 2017, 5:29 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > > Lines 128 (patched) > > > > > > David, > > > >

Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation

2017-08-16 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61085/#review183074 --- Consider refactoring the method to sue something like: public

Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation

2017-08-16 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61085/#review183059 --- Fix it, then Ship it!

Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation

2017-08-16 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61085/#review183043 ---

Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation

2017-08-09 Thread David Radley
> On July 24, 2017, 7:15 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > > Lines 128 (patched) > > > > > > consider using

Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation

2017-07-24 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61085/#review181253 ---