Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-16 Thread David Radley


> On Feb. 15, 2018, 6:13 p.m., Jerry He wrote:
> > Can we put the omrs module in the top level pom so that it builds the omrs 
> > module?

I agree, this is where it needs to go. We were thinking that we would leave it 
out of the build for now until omrs is more fleshed out.
It is really useful for the community developers to have this code checked in, 
so that can code to it. 
The Atlas connector is once piece of code that is being developed - this will 
allow omrs calls to isue requests to Atlas; I think when we have that, we can 
link it into the build. Personally I have added the line to the pom.xml to 
bring omrs into my local builds.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review197628
---


On Feb. 15, 2018, 7:03 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Feb. 15, 2018, 7:03 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java cc2e430 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
> fafd20c 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
> d34e6f4 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java 
> ce6dae1 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-15 Thread Mandy Chessell

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/
---

(Updated Feb. 15, 2018, 7:03 p.m.)


Review request for atlas, David Radley and Madhan Neethiraj.


Repository: atlas


Description
---

This is a request for code review of the OMRS.  There are still parts of the 
code not written - the aim of the review is to make the connector interfaces 
available so they can be evaluated by teams buinding components against the 
APIs.

There is a patch connected to 
https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
code plus other code that is not ready for review.  The OMRS Connector API 
depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.


Diffs
-

  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java cc2e430 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
fafd20c 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
d34e6f4 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java 
ce6dae1 
  omrs/README.md PRE-CREATION 
  omrs/pom.xml PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveBuilder.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/opentypes/OpenMetadataTypesArchive.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchive.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveInstanceStore.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveProperties.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveType.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveTypeStore.java
 PRE-CREATION 
  

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-15 Thread Jerry He

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review197628
---



Can we put the omrs module in the top level pom so that it builds the omrs 
module?

- Jerry He


On Feb. 15, 2018, 4:49 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Feb. 15, 2018, 4:49 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java cc2e430 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
> fafd20c 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
> d34e6f4 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java 
> ce6dae1 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveBuilder.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/opentypes/OpenMetadataTypesArchive.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-15 Thread David Radley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review197619
---


Ship it!




Ship It!

- David Radley


On Feb. 15, 2018, 12:49 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Feb. 15, 2018, 12:49 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java cc2e430 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
> fafd20c 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
> d34e6f4 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java 
> ce6dae1 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveBuilder.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/opentypes/OpenMetadataTypesArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchive.java
>  

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-15 Thread Mandy Chessell

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/
---

(Updated Feb. 15, 2018, 12:49 p.m.)


Review request for atlas, David Radley and Madhan Neethiraj.


Changes
---

This should be the version we hope to commit to Atlas


Repository: atlas


Description
---

This is a request for code review of the OMRS.  There are still parts of the 
code not written - the aim of the review is to make the connector interfaces 
available so they can be evaluated by teams buinding components against the 
APIs.

There is a patch connected to 
https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
code plus other code that is not ready for review.  The OMRS Connector API 
depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.


Diffs (updated)
-

  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java cc2e430 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
fafd20c 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
d34e6f4 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java 
ce6dae1 
  omrs/README.md PRE-CREATION 
  omrs/pom.xml PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveBuilder.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/opentypes/OpenMetadataTypesArchive.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchive.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveInstanceStore.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveProperties.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveType.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveTypeStore.java
 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/
---

(Updated Feb. 14, 2018, 6:06 p.m.)


Review request for atlas, David Radley and Madhan Neethiraj.


Repository: atlas


Description
---

This is a request for code review of the OMRS.  There are still parts of the 
code not written - the aim of the review is to make the connector interfaces 
available so they can be evaluated by teams buinding components against the 
APIs.

There is a patch connected to 
https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
code plus other code that is not ready for review.  The OMRS Connector API 
depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.


Diffs (updated)
-

  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java cc2e430 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
fafd20c 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
d34e6f4 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java 
ce6dae1 
  omrs/README.md PRE-CREATION 
  omrs/pom.xml PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveBuilder.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/opentypes/OpenMetadataTypesArchive.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchive.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveInstanceStore.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveProperties.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveType.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveTypeStore.java
 PRE-CREATION 
  

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefValidator.java
> > Lines 57 (patched)
> > 
> >
> > List as param for validateTypeDefs?

Using ArrayLists


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
> > Lines 136 (patched)
> > 
> >
> > List as return type?
> 
> Mandy Chessell wrote:
> Needs to be ArrayList as need concrete implementation for ease of use.

Choice of ArrayList is deliberate


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefValidator.java
> > Lines 37 (patched)
> > 
> >
> > List ?

It should be ArrayList


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
> > Lines 668 (patched)
> > 
> >
> > the most generic type for param (ArrayList(. Can you 
> > change to List in this case?
> > Also the same comment for return type.

The OMRS is using ArrayLists consistently


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
> > Lines 136 (patched)
> > 
> >
> > It is best to return the most generic type. Can you return List in this 
> > case?

The OMRS is using ArrayLists consistently


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 10:45 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventExchangeRule.java
> > Lines 33 (patched)
> > 
> >
> > can be List instead of implementation (ArrayList)?

Already commented on this point, above and below


> On Feb. 6, 2018, 10:45 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventExchangeRule.java
> > Lines 60 (patched)
> > 
> >
> > return exchangeRule != OpenMetadataExchangeRule.REGISTRATION_ONLY 
> > directly?

Seems to be the same logic - just a more complicated way of writing it.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196882
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 10:45 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
> > Lines 239 (patched)
> > 
> >
> > it may be faster to call combinedResults.isEmpty() that to look an the 
> > entire list (.size).

The complier will optimize


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196882
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 10:45 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
> > Lines 190 (patched)
> > 
> >
> > it may be faster to call combinedResults.isEmpty() that to look an the 
> > entire list (.size).

The complier will do that for us.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196882
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 10:26 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
> > Lines 111 (patched)
> > 
> >
> > can be List combinedResults = new ArrayList<>(); ?

Deliberately using ArrayLists


> On Feb. 6, 2018, 10:26 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
> > Lines 139 (patched)
> > 
> >
> > it may be faster to call combinedResults.isEmpty() that to look an the 
> > entire list (.size).

The complier will do that for us


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196881
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 10:08 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
> > Lines 71 (patched)
> > 
> >
> > It may be better to use interfaces over concrete types for good 
> > encapsulation and for loose coupling. I suggest to have "private List<>" 
> > instead of "private ArrayList<>".

I have commented on this abover and below


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196879
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 9:43 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java
> > Lines 35 (patched)
> > 
> >
> > It may be better to use interfaces over concrete types for good 
> > encapsulation and for loose coupling. I suggest to have "private 
> > List" instead of "private ArrayList 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 9:29 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java
> > Lines 31 (patched)
> > 
> >
> > It may be better to use interfaces over concrete types for good 
> > encapsulation and for loose coupling. I suggest to have "private 
> > List" instead of "private ArrayList 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 3:45 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/OMRSCohortRegistry.java
> > Lines 1051 (patched)
> > 
> >
> > only one if with && operator?
> 
> Mandy Chessell wrote:
> I don't understand this comment

Worked it out now - the suggested change does not change the logic and it is 
easier to read if it is simple.  Just a different style preference


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196899
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 3:45 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/OMRSCohortRegistry.java
> > Lines 1051 (patched)
> > 
> >
> > only one if with && operator?

I don't understand this comment


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196899
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java
> > Lines 111 (patched)
> > 
> >
> > protectec static instead of "static protected". It's more common to 
> > have the access modifier (public/private...) before the modifier static.
> > also  List as return type.
> 
> Mandy Chessell wrote:
> ok - but I don't think it makes any difference

This line does not exist in the current version .  I think it was removed when 
I restructured the PrimitiveTypeDef


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java
> > Lines 53 (patched)
> > 
> >
> > is it needed ""?

It is not needed, and I have removed it - but I think it is sloppy to not 
initialise variables


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java
> > Lines 35 (patched)
> > 
> >
> > ArrayList -> List?

Its supposed to be ArrayList not List


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java
> > Lines 46 (patched)
> > 
> >
> > ArrayList ->List?

Its supposed to be ArrayList


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java
> > Lines 47 (patched)
> > 
> >
> > ArrayList ->List?

Its supposed to be ArrayList


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatchAction.java
> > Lines 26 (patched)
> > 
> >
> > implements Serializable?

Fixed


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196892
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:41 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java
> > Lines 149 (patched)
> > 
> >
> > is it not needed public access to this method?

Yes - I will fix it in the next patch


> On Feb. 6, 2018, 12:41 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDef.java
> > Lines 31 (patched)
> > 
> >
> > creationTime - why this value?
> > + ArrayList -> List

We need to have every instance of the collection def have the same values - it 
was the current time when I created the file.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196890
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:41 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java
> > Lines 115 (patched)
> > 
> >
> > is it not needed public access to this method?

Yes - I'll fix it in the next patch


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196890
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:41 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java
> > Lines 46 (patched)
> > 
> >
> > super() - not needed in this case (redundant)

It is not breaking anything and means that if the suprt class is changed in the 
future the new function will be invoked


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196890
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java
> > Lines 141 (patched)
> > 
> >
> > !isEmpty()?

Same behaviour ?


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditCode.java 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java
> > Lines 122 (patched)
> > 
> >
> > List?

Using ArraList for reasons described above


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java
> > Lines 72 (patched)
> > 
> >
> > return List (code to the interface?)

Using ArrayList for reasons above


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java
> > Lines 28 (patched)
> > 
> >
> > It may be better to use interfaces over concrete types for good 
> > encapsulation and for loose coupling. I suggest to have "private 
> > List" instead of "private ArrayList 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java
> > Lines 49 (patched)
> > 
> >
> > if (name == null || "".equals(name))?

Same behaviour


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
> > Lines 136 (patched)
> > 
> >
> > List as return type?

Needs to be ArrayList as need concrete implementation for ease of use.


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
> > Lines 148 (patched)
> > 
> >
> > List as return type?

Needs to be ArrayList as need concrete implementation for ease of use.


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
> > Lines 168 (patched)
> > 
> >
> > List as return type?

Needs to be ArrayList as need concrete implementation for ease of use.


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
> > Lines 388 (patched)
> > 
> >
> > List as return type and param for this method?

Needs to be ArrayList as need concrete implementation for ease of use.


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollectionBase.java
> > Lines 1393 (patched)
> > 
> >
> > is it correct the name of this method?

yes - what do you think it should be?


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 3:50 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/OMRSCohortRegistryStoreProviderBase.java
> > Lines 34 (patched)
> > 
> >
> > is it needed?

Implementors of CohortRegistryStore connector providers am want a base class to 
inherit from.


> On Feb. 6, 2018, 3:50 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/file/FileBasedRegistryStoreConnector.java
> > Lines 47 (patched)
> > 
> >
> > private static final variables should be declared before private 
> > variables. I suggest to add after "defaultFilename" the following vars: 
> > OMRSAuditLog auditLog and Logger log.

The variables are ordered by importance.  The logging/audit log are not 
important so at the end - They are at the end for all classes.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196900
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 13, 2018, 11:43 a.m., David Radley wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java
> > Lines 71 (patched)
> > 
> >
> > It would be normal to only expose List here are the return value and 
> > not expose the type of List, so you do not expose the List implementation.
> > The same for the setter.

I am not sure what the assumptions are for the "normal" case.  It make sense if 
the class is providing a service and exporting lists only but that is not the 
case.  However in this case, the change would make the use of the classes very 
awkward because the array list is manipulated and created both by the callers 
and the class itself.  We would be continually casting and have to have a 
"secret" rule that the implementation must be ArrayList to use the class.  I 
don't think that is an improvement.  It is also a big change because if we did 
if for this place we would want to change it for the whole of the OMRS.   We 
have to be sure it works with Spring and Jackson.  All of the examples I have 
been working with use ArrayList.  If you feel strongly about it, raise a Jira 
since this is a big piece of work and we can look into it when we have time.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review197399
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java
> > Lines 44 (patched)
> > 
> >
> > What is the purpose of this attribute?
> 
> Mandy Chessell wrote:
> It defines how many primitives there are

This line does not exist in the current version


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196892
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java
> > Lines 111 (patched)
> > 
> >
> > protectec static instead of "static protected". It's more common to 
> > have the access modifier (public/private...) before the modifier static.
> > also  List as return type.

ok - but I don't think it makes any difference


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196892
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java
> > Lines 44 (patched)
> > 
> >
> > What is the purpose of this attribute?

It defines how many primitives there are


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196892
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-13 Thread David Radley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review197399
---




omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java
Lines 71 (patched)


It would be normal to only expose List here are the return value and not 
expose the type of List, so you do not expose the List implementation.
The same for the setter.


- David Radley


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-06 Thread Daniela Otelea

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196900
---




omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/OMRSCohortRegistryStoreProviderBase.java
Lines 34 (patched)


is it needed?



omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/file/FileBasedRegistryStoreConnector.java
Lines 47 (patched)


private static final variables should be declared before private variables. 
I suggest to add after "defaultFilename" the following vars: OMRSAuditLog 
auditLog and Logger log.


- Daniela Otelea


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-06 Thread Daniela Otelea

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196899
---




omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/OMRSCohortRegistry.java
Lines 1051 (patched)


only one if with && operator?


- Daniela Otelea


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditCode.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditLog.java 
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-06 Thread Daniela Otelea

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196892
---




omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java
Lines 44 (patched)


What is the purpose of this attribute?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java
Lines 111 (patched)


protectec static instead of "static protected". It's more common to have 
the access modifier (public/private...) before the modifier static.
also  List as return type.



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java
Lines 53 (patched)


is it needed ""?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java
Lines 35 (patched)


ArrayList -> List?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java
Lines 46 (patched)


ArrayList ->List?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java
Lines 47 (patched)


ArrayList ->List?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatchAction.java
Lines 26 (patched)


implements Serializable?


- Daniela Otelea


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-06 Thread Daniela Otelea

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196890
---




omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java
Lines 46 (patched)


super() - not needed in this case (redundant)



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java
Lines 115 (patched)


is it not needed public access to this method?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java
Lines 149 (patched)


is it not needed public access to this method?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDef.java
Lines 31 (patched)


creationTime - why this value?
+ ArrayList -> List


- Daniela Otelea


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-06 Thread Daniela Otelea

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---




omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 136 (patched)


It is best to return the most generic type. Can you return List in this 
case?



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 668 (patched)


the most generic type for param (ArrayList(. Can you change 
to List in this case?
Also the same comment for return type.



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefValidator.java
Lines 37 (patched)


List ?



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefValidator.java
Lines 57 (patched)


List as param for validateTypeDefs?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
Lines 136 (patched)


List as return type?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
Lines 148 (patched)


List as return type?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
Lines 168 (patched)


List as return type?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
Lines 388 (patched)


List as return type and param for this method?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollectionBase.java
Lines 1393 (patched)


is it correct the name of this method?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java
Lines 49 (patched)


if (name == null || "".equals(name))?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java
Lines 28 (patched)


It may be better to use interfaces over concrete types for good 
encapsulation and for loose coupling. I suggest to have "private 
List" instead of "private ArrayList

return List (code to the interface?)



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java
Lines 122 (patched)


List?



omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java
Lines 141 (patched)


!isEmpty()?


- Daniela Otelea


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-06 Thread Daniela Otelea

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196882
---




omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
Lines 190 (patched)


it may be faster to call combinedResults.isEmpty() that to look an the 
entire list (.size).



omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
Lines 239 (patched)


it may be faster to call combinedResults.isEmpty() that to look an the 
entire list (.size).



omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventExchangeRule.java
Lines 33 (patched)


can be List instead of implementation (ArrayList)?



omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventExchangeRule.java
Lines 60 (patched)


return exchangeRule != OpenMetadataExchangeRule.REGISTRATION_ONLY directly?


- Daniela Otelea


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-06 Thread Daniela Otelea

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196881
---




omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
Lines 111 (patched)


can be List combinedResults = new ArrayList<>(); ?



omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
Lines 139 (patched)


it may be faster to call combinedResults.isEmpty() that to look an the 
entire list (.size).


- Daniela Otelea


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-06 Thread Daniela Otelea

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196880
---




omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSConnectorProvider.java
Lines 164 (patched)


public boolean equals(Object obj) is missing?


- Daniela Otelea


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditCode.java 
> PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-06 Thread Daniela Otelea

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196879
---




omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
Lines 71 (patched)


It may be better to use interfaces over concrete types for good 
encapsulation and for loose coupling. I suggest to have "private List<>" 
instead of "private ArrayList<>".


- Daniela Otelea


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-06 Thread Daniela Otelea

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196875
---




omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java
Lines 35 (patched)


It may be better to use interfaces over concrete types for good 
encapsulation and for loose coupling. I suggest to have "private 
List" instead of "private ArrayList 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-06 Thread Daniela Otelea

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196874
---




omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java
Lines 31 (patched)


It may be better to use interfaces over concrete types for good 
encapsulation and for loose coupling. I suggest to have "private 
List" instead of "private ArrayList 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-29 Thread Mandy Chessell

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/
---

(Updated Jan. 29, 2018, 9:51 a.m.)


Review request for atlas, David Radley and Madhan Neethiraj.


Repository: atlas


Description
---

This is a request for code review of the OMRS.  There are still parts of the 
code not written - the aim of the review is to make the connector interfaces 
available so they can be evaluated by teams buinding components against the 
APIs.

There is a patch connected to 
https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
code plus other code that is not ready for review.  The OMRS Connector API 
depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.


Diffs
-

  omrs/README.md PRE-CREATION 
  omrs/pom.xml PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditCode.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditLog.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditLogRecordSeverity.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditingComponent.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecord.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecordOriginator.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogReportingComponent.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStoreConnectorBase.java
 PRE-CREATION 
  

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 19, 2018, 10:40 a.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
> > Lines 51 (patched)
> > 
> >
> > missing name here

It now reads ...
/**
 * EnterpriseOMRSMetadataCollection executes the calls to the open metadata 
repositories registered
 * with the OMRSEnterpriseConnectorManager.  The effect is a federated view 
over these open metadata
 * repositories.
 * 
 * EnterpriseOMRSMetadataCollection is part of an 
EnterpriseOMRSRepositoryConnector.  The EnterpriseOMRSRepositoryConnector
 * holds the list of OMRS Connectors, one for each of the metadata 
repositories.  This list may change
 * over time as metadata repositories register and deregister with the 
connected cohorts.
 * The EnterpriseOMRSRepositoryConnector is responsible for keeping the 
list of connectors up-to-date through
 * contact with the OMRSEnterpriseConnectorManager.
 * 
 * 
 * When a request is made to the EnterpriseOMRSMetadataCollection, it calls 
the EnterpriseOMRSRepositoryConnector
 * to request the appropriate list of metadata collection for the request.  
Then the EnterpriseOMRSConnector
 * calls the appropriate remote connectors.
 * 
 * 
 * The first OMRS Connector in the list is the OMRS Repository Connector 
for the "local" repository.
 * The local repository is favoured when new metadata is to be created, 
unless the type of metadata
 * is not supported by the local repository. In which case, the 
EnterpriseOMRSMetadataCollection searches its
 * list looking for the first metadata repository that supports the 
metadata type and stores it there.
 * 
 * 
 * Updates and deletes are routed to the owning (home) repository.  
Searches are made to each repository in turn
 * and the duplicates are removed.  Queries are directed to the local 
repository and then the remote repositories
 * until all of the requested metadata is assembled.
 * 
 */


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195808
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 22, 2018, 2:17 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java
> > Lines 162 (patched)
> > 
> >
> > why do we need to dissconnect here?
> 
> Mandy Chessell wrote:
> The remote connector may be holding network resources that it acquired 
> during its initialization.  The implementation is pluggable so we need to 
> offer the opportunity for it to release anything it has created.  The 
> connector does not know this was a simple test to ensure we have a valid 
> connection/connector.
> 
> Yao Li wrote:
> does this mean: everytime we use the remote connection as a parameter to 
> get Connector, the first time after we getConnector(), we need to execute 
> disconnect(), but after the first time, when we use getConnector(Connection) 
> it is safe to use.

Not quite.  The call to getConnector() returns a new instance of the connector. 
 Each new instance can be used for multiple data and metadata requests.  Then 
when the connector instance is not needed any more, the caller calls its 
disconnect() method.  The connector instance can not be used any more one 
disconnect() returns.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195903
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 3:55 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java
> > Lines 56 (patched)
> > 
> >
> > here what type of realMetadaCollection will be?

It is of type OMRSMetadataCollection - as the definition says.  
OMRSMetadataCollection is an interface implemented as part of a repository 
connector.  So the implementating class used will depend on which repository 
connector is in use.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196353
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 17, 2018, 11:38 a.m., David Radley wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java
> > Lines 48 (patched)
> > 
> >
> > I suggest changing structure to entity here. Structure has echos of the 
> > Atlas structure - which could be misleading.
> 
> Mandy Chessell wrote:
> ok - but structs are no longer part of the model and it seems a bit 
> strange to remove the word from our vocabulary because of a feature that is 
> not supported.

Looking at this, saying "entity" is incorrect because it is a group of entities 
representing an single concept.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195417
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196353
---




omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java
Lines 56 (patched)


here what type of realMetadaCollection will be?


- Yao Li


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditCode.java 
> PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 3:22 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
> > Lines 414 (patched)
> > 
> >
> > Id -> id

I am not sure I agree with this - it is a convention to use a capital I for Id.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196350
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 3:22 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
> > Lines 251 (patched)
> > 
> >
> > if outboundRepositoryEventProcessor == null, it means there is an Event 
> > Mapper, should then call eventMapper.getOMRSRepositoryEventProcessor() to 
> > still process this event? 
> > 
> > Note: getOMRSRepositoryEventProcessor() doesn't exist, I just make it 
> > up and for EventMapper it only has setOMRSRepositoryEventProcessor() 
> > function

No - the event mapper is taking events from an external source


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196350
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196350
---




omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 251 (patched)


if outboundRepositoryEventProcessor == null, it means there is an Event 
Mapper, should then call eventMapper.getOMRSRepositoryEventProcessor() to still 
process this event? 

Note: getOMRSRepositoryEventProcessor() doesn't exist, I just make it up 
and for EventMapper it only has setOMRSRepositoryEventProcessor() function



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 381 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 414 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 447 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 485 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1244 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1367 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1425 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1476 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1533 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1600 (patched)


entity -> relationship



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1601 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1651 (patched)


entity -> relationship



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1652 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1702 (patched)


entity -> relationship



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1703 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1748 (patched)


entity -> relationship



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1749 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1865 (patched)


entity -> relationship



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1866 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1928 (patched)


Id -> id



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
Lines 1995 (patched)

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 1:17 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapper.java
> > Lines 39 (patched)
> > 
> >
> > 1, can you please finish this explanation?
> > 2, here should be TypeDef Helper and Instance Helper

Now says

 * @param repositoryHelper - provides helper methods for building TypeDefs 
and metadata instance such as 
 * entities and relationships.
 *

RepositoryHelper implements both TypeDefHelper and InstanceHelper


> On Jan. 26, 2018, 1:17 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapperBase.java
> > Lines 26 (patched)
> > 
> >
> > of + "OMRSRepositoryEventMapper"

Fixed :)


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196318
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 1:17 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapperProviderBase.java
> > Lines 24 (patched)
> > 
> >
> > here "OMRSRepositoryEventConnector" do you mean OMRSTopicConnector?

No - this should be OMRSRepositoryEventMapper connectors


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196318
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 1:43 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java
> > Lines 28 (patched)
> > 
> >
> > can you add an explanation for this interface?

This is fixed in the latest patch


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196334
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 1:43 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java
> > Lines 95 (patched)
> > 
> >
> > can you finish the java doc for this function?

This is fixed in the latest patch


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196334
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 1:43 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java
> > Lines 97 (patched)
> > 
> >
> > can you finish the java doc for this function?

This is fixed in the latest patch


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196334
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li


> On Jan. 26, 2018, 11:52 a.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java
> > Lines 384 (patched)
> > 
> >
> > should this code put into the 
> > 
> >  if (this.validEntity(sourceName, entity))
> > {
> > 
> > }  
> > ?
> 
> Mandy Chessell wrote:
> No each are doing different tests - it is relating to the rule whether 
> the event should be processed - not whether the entity is valid.  The logic 
> for validEntity() needs to move to the OMRSRepositoryValidator (in 
> org.apache.atlas.omrs.localrepository.repositorycontentmanager) so it can be 
> used in many places
> 
> Yao Li wrote:
> if we move it to OMRSRepositoryValidator, then do we still need seperate 
> OMRSTypeDefValidator and OMRSInstanceValidator?

saw that the OMRSRepositoryValidator implements these two interface.


- Yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196316
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196334
---




omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java
Lines 28 (patched)


can you add an explanation for this interface?



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java
Lines 95 (patched)


can you finish the java doc for this function?



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java
Lines 96 (patched)


can you finish the java doc for this function?



omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java
Lines 97 (patched)


can you finish the java doc for this function?


- Yao Li


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li


> On Jan. 26, 2018, 11:52 a.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java
> > Lines 384 (patched)
> > 
> >
> > should this code put into the 
> > 
> >  if (this.validEntity(sourceName, entity))
> > {
> > 
> > }  
> > ?
> 
> Mandy Chessell wrote:
> No each are doing different tests - it is relating to the rule whether 
> the event should be processed - not whether the entity is valid.  The logic 
> for validEntity() needs to move to the OMRSRepositoryValidator (in 
> org.apache.atlas.omrs.localrepository.repositorycontentmanager) so it can be 
> used in many places

if we move it to OMRSRepositoryValidator, then do we still need seperate 
OMRSTypeDefValidator and OMRSInstanceValidator?


- Yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196316
---


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196318
---




omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapper.java
Lines 39 (patched)


1, can you please finish this explanation?
2, here should be TypeDef Helper and Instance Helper



omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapperBase.java
Lines 26 (patched)


of + "OMRSRepositoryEventMapper"



omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapperProviderBase.java
Lines 24 (patched)


here "OMRSRepositoryEventConnector" do you mean OMRSTopicConnector?


- Yao Li


On Jan. 26, 2018, 1:15 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 26, 2018, 1:15 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/
---

(Updated Jan. 26, 2018, 1:15 p.m.)


Review request for atlas, David Radley and Madhan Neethiraj.


Changes
---

New version of the patch


Repository: atlas


Description
---

This is a request for code review of the OMRS.  There are still parts of the 
code not written - the aim of the review is to make the connector interfaces 
available so they can be evaluated by teams buinding components against the 
APIs.

There is a patch connected to 
https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
code plus other code that is not ready for review.  The OMRS Connector API 
depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.


Diffs
-

  omrs/README.md PRE-CREATION 
  omrs/pom.xml PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditCode.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditLog.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditLogRecordSeverity.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditingComponent.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecord.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecordOriginator.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogReportingComponent.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java 
PRE-CREATION 
  

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 11:52 a.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java
> > Lines 384 (patched)
> > 
> >
> > should this code put into the 
> > 
> >  if (this.validEntity(sourceName, entity))
> > {
> > 
> > }  
> > ?

No each are doing different tests - it is relating to the rule whether the 
event should be processed - not whether the entity is valid.  The logic for 
validEntity() needs to move to the OMRSRepositoryValidator (in 
org.apache.atlas.omrs.localrepository.repositorycontentmanager) so it can be 
used in many places


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196316
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 11:52 a.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java
> > Lines 112 (patched)
> > 
> >
> > i saw you have validTypeDef(), validRelationship(), i guess for all 
> > processNewTypeDef or processNewRelasionship(), you need these valid 
> > functions to check the validation. and for Entity you actully used it aready

Yes - we need to validate everything that comes from an external partner.  
OMRSRepositoryEventManager is a good place to do this since it passes events 
between the different major components.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196316
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 10:30 a.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java
> > Lines 82 (patched)
> > 
> >
> > for severity, should here use class "OMRSAuditLogRecordSeverity"?

It is an interface that will sit behind a REST API.  It will use the string 
name that is defined from OMRSAuditLogSeverity rather than the enum itself.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196310
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 10:30 a.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java
> > Lines 70 (patched)
> > 
> >
> > should retrieve the list based on the "severity"

Yes - fixed


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196310
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditCode.java 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 10:30 a.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecordOriginator.java
> > Lines 20 (patched)
> > 
> >
> > can you add the explaination for this class?

Yes - added


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196310
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell


> On Jan. 26, 2018, 7:38 a.m., Maryna Strelchuk wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
> > Lines 34 (patched)
> > 
> >
> > 2 other sections are missing here: TypeStore and InstanceStore

Agreed - fixed


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196288
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196316
---




omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java
Lines 112 (patched)


i saw you have validTypeDef(), validRelationship(), i guess for all 
processNewTypeDef or processNewRelasionship(), you need these valid functions 
to check the validation. and for Entity you actully used it aready



omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java
Lines 384 (patched)


should this code put into the 

 if (this.validEntity(sourceName, entity))
{

}  
?


- Yao Li


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li


> On Jan. 22, 2018, 2:17 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java
> > Lines 162 (patched)
> > 
> >
> > why do we need to dissconnect here?
> 
> Mandy Chessell wrote:
> The remote connector may be holding network resources that it acquired 
> during its initialization.  The implementation is pluggable so we need to 
> offer the opportunity for it to release anything it has created.  The 
> connector does not know this was a simple test to ensure we have a valid 
> connection/connector.

does this mean: everytime we use the remote connection as a parameter to get 
Connector, the first time after we getConnector(), we need to execute 
disconnect(), but after the first time, when we use getConnector(Connection) it 
is safe to use.


- Yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195903
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  

***UNCHECKED*** Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196310
---




omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecordOriginator.java
Lines 20 (patched)


can you add the explaination for this class?



omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java
Lines 70 (patched)


should retrieve the list based on the "severity"



omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java
Lines 82 (patched)


for severity, should here use class "OMRSAuditLogRecordSeverity"?



omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java
Lines 90 (patched)


should be retrieve the list based on the component's name


- Yao Li


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-25 Thread Maryna Strelchuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196288
---




omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
Lines 34 (patched)


2 other sections are missing here: TypeStore and InstanceStore


- Maryna Strelchuk


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditCode.java 
> PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 17, 2018, 11:38 a.m., David Radley wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSCohortManager.java
> > Lines 45 (patched)
> > 
> >
> > I am woindering if -the dtate is initialised to NEW - is uninitialised 
> > never used / not necessary.
> 
> Mandy Chessell wrote:
> I can remove it

Actually when I remove it I get a compile error so have left it in.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195417
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 19, 2018, 9:27 a.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java
> > Lines 66 (patched)
> > 
> >
> > is it possible to change the code as
> > 
> > OMRSConnection   omrsConnection = new OMRSConnection(connection);
> > 
> > so we dont need a OMRSConnection seperately and still can use the 
> > Connection in the parent class
> 
> Mandy Chessell wrote:
> Are you asking that it becomes a local variable rather than an instance 
> variable?  What if the subclasses want the OMRSConnection object for their 
> own work? 
> Or is there a code bug?
> 
> Yao Li wrote:
> I thought a local variable is engough. but if the subclass want to use 
> OMRSConnection for their own work,i will be confused. because for one 
> OMRSRepositoryConnector I have two Connections, one is Connection, one is 
> OMRSConnection. How do I know what information I should store in which one?
> 
> Mandy Chessell wrote:
> These objects are immutable - the implementer of a sub class should not 
> be storing anything in them.  They should only be reading properties from 
> these objects.  It does not matter which one they use becuase they have the 
> same values in them.  I think it will be a matter of personal taste of the 
> developer.

I have deleted OMRSConnection class from the code and moved the caching of the 
secure properties to ConnectorBase.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195794
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 22, 2018, 2:17 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java
> > Lines 340 (patched)
> > 
> >
> > because connectorConsumerId is unique, if we already find one is 
> > matched, can we immediately "break;" and finish the while loop?

I can put the break in.  In general I don't like breaking out of a loop 
unnecessarily and the list is short so no performance concern.  But that is 
just a style question :)


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195903
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 23, 2018, 1:39 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSInstanceHelper.java
> > Lines 101 (patched)
> > 
> >
> > looks like we can also need
> > 
> > Classfication getNewClassfication() 
> > 
> > function here
> 
> Mandy Chessell wrote:
> I am not sure - there is not much it can do beyond the behaviour of the 
> getSkelClassification.  That is why I did not add it before.  I don't think 
> it would save any code in the caller.  I can add it and if it is used we can 
> keep it or delete it if OMAS developers arn't using it.

I have just extended Classification to include attributes such as CreatedBy 
etc.  So it is now very similar to entities/relationships but without the guid 
and provenance info.  So classification now has both the getSkel method and the 
getNew method.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195998
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 23, 2018, 1:03 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java
> > Lines 222 (patched)
> > 
> >
> > delete "to"

Sentence now reads "Return the event manager that the local repository uses to 
distribute events from the local repository."


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195989
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 19, 2018, 9:27 a.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java
> > Lines 31 (patched)
> > 
> >
> > in ConnectorBase we already have Connection as a property, why do we 
> > need OMRSConnection in here again a special OMRSConnection?
> 
> Mandy Chessell wrote:
> The secure properties are protected in the OCF class.  We need an object 
> to inherit from the connection object to allow the OMRS connectors to access 
> the secure properties.  This variable is protected so that subclasses can 
> pick it up.

I have updated ConnectorBase to copy the secure properties from the Connection 
into a protected variable.  This means I have deleted the OMRSConnection Class.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195794
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 17, 2018, 11:38 a.m., David Radley wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/CohortConnectionStatus.java
> > Lines 29 (patched)
> > 
> >
> > I am not sure what this description means. I am not sure what messages 
> > the components of the cohort need to exchange with the cohort.
> 
> Mandy Chessell wrote:
> Could change it to be "The local components for this cohort are 
> initialized by they have not exchanged messages with other members of the 
> cohort."

There are 3 types of messages - registration events (to exchange connections 
about members in the cohort), typeDef events (to exchange types) and instance 
events (to exchange instances).


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195417
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 17, 2018, 11:38 a.m., David Radley wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java
> > Lines 34 (patched)
> > 
> >
> > I wonder if you could give an example of how an OMAS might call the 
> > OMRS - is it this class that is involved?
> 
> Mandy Chessell wrote:
> It is not appropiate to describe the broader design in the header of a 
> class.  The header should describe the behaviour of

To answer the specific question - an OMAS calls the ORMS through the Enterprise 
OMRS Connector.  It uses the OCF connector broker to create an instance of the 
Enterprise OMRS Connector.  The Enterprise OMRS Connector has a method call 
getMetadataCollection().  MetadataCollection has all of the methods to access 
metadata.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195417
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 19, 2018, 2:54 p.m., David Radley wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/PrimitivePropertyValue.java
> > Lines 102 (patched)
> > 
> >
> > I suggest we use string compares to check that the  class / primitive 
> > type is valid rather than loading a class - which is much more expensive 
> > and the loaded class is then not used.
> 
> Mandy Chessell wrote:
> It is not loading the class - this is a static method on the common Java 
> types - these classes are already loaded.  However I can look at how we do 
> validate the TypeDef.

Looked at this in more detail - the following line uses the testJavaClass 
object that is created in the following line.
ie 

if (!testJavaClass.isInstance(primitiveValue))

So I am not sure what strings we can compare to do the same function.  We are 
testing the class of an attribute passed in on the method.  Now admittedly, 
there is a missing exception in the if body which needs to be added of course 
but I am not sure how to action this particular comment.  Could you provide a 
code sample


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195818
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 22, 2018, 1:07 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSConnectionConsumer.java
> > Lines 25 (patched)
> > 
> >
> > here the explaination should belong to the OMRSConnectorConsumer

Agreed - fixed


> On Jan. 22, 2018, 1:07 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSConnectorConsumer.java
> > Lines 23 (patched)
> > 
> >
> > here the explaination should belong to the OMRSConnectionConsumer

Agreed - fixed


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195896
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 22, 2018, 2:17 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java
> > Lines 122 (patched)
> > 
> >
> > is it possible to change the function name to  
> > setRegisteredLocalConnector? I was confused with the setLocalConnector in 
> > OMRSConnectorConsumer

I am not in favour of the name change because it suggests that the local 
connector "registers" in the same way that remote connectors do.  I would worry 
that a similar name would suggest a similar process involved.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195903
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 23, 2018, 1:39 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSInstanceHelper.java
> > Lines 101 (patched)
> > 
> >
> > looks like we can also need
> > 
> > Classfication getNewClassfication() 
> > 
> > function here

I am not sure - there is not much it can do beyond the behaviour of the 
getSkelClassification.  That is why I did not add it before.  I don't think it 
would save any code in the caller.  I can add it and if it is used we can keep 
it or delete it if OMAS developers arn't using it.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195998
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-24 Thread Mandy Chessell


> On Jan. 23, 2018, noon, Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSConnectorProvider.java
> > Lines 95 (patched)
> > 
> >
> > this function already exists in OCF ConnectorProviderBase, but it is a 
> > private: 
> > 
> > private String  getNewConnectorGUID()
> > {
> > UUID newUUID = UUID.randomUUID();
> > 
> > return newUUID.toString();
> > }
> > 
> > if every connector provider need this, is it possible to change the 
> > function to public?

Most connector providers do not need this as is evident by the fact that only 2 
out of 9 of the OMRS connectors set up their own UUID - and one of them is a 
fake :). Generally if a connector provider does extend ConnectorProviderBase, 
then they are using the ConnectorProviderBase's implementation of getConnector 
which calls the getNewConnectorGUID().  However, it is a good point that a 
subclass may want to use it, so I have switched it to a protected method in 
ConnectorProviderBase and removed it from EnterpriseOMRConnectorProvider.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195986
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell


> On Jan. 22, 2018, 2:17 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java
> > Lines 226 (patched)
> > 
> >
> > what if the metadataCollectionId is not matched with any 
> > registeredRemoteConnector, such as a wrong id, repositoryRegistrationCount 
> > ==0 , then we actually dont have to call removeRemoteConnector().

I believe the behaviour is still correct because we will loop through the 
registered connectors.  A wrong metadata collection Id something that should 
not happen) will just mena we step through the loop and do nothing.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195903
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell


> On Jan. 22, 2018, 2:17 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java
> > Lines 162 (patched)
> > 
> >
> > why do we need to dissconnect here?

The remote connector may be holding network resources that it acquired during 
its initialization.  The implementation is pluggable so we need to offer the 
opportunity for it to release anything it has created.  The connector does not 
know this was a simple test to ensure we have a valid connection/connector.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195903
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell


> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java
> > Line 91 (original), 86 (patched)
> > 
> >
> > based on the comments for OCF, clone/copy consturctor we should check 
> > whether options, externalStandardMappings and validInstanceStatusList are 
> > null
> 
> Mandy Chessell wrote:
> This interface is not designed in the same way as OCF - the copying is 
> not a deep copy because this is an interface used by internal components so 
> it is not so defensive.
> 
> Mandy Chessell wrote:
> Let me give a better explanation.  The metadata collection properties do 
> need to do a deep copy in the same way as the OCF objects.  However, they are 
> not linked to the parentAsst.  This means the cloning can be done in the 
> getter method for the attribute.  This means the test for null before 
> creating the new object can be in the getter method.  It is a simpler design 
> because the problem space is simpler.
> 
> Yao Li wrote:
> but in the getter method, it is simper return, no null check.

Then the getter method needs fixing.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195822
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell


> On Jan. 22, 2018, 2:17 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java
> > Lines 104 (patched)
> > 
> >
> > is it possible to change the name to UnregisteredAllConnectors? i am 
> > confused with the function disconnect() in OCF Connector

It is used as part of the disconnect processing - ie is is called from the 
disconnect() processing in the cohort manager.  Connectors are not the only 
component that are called during diconnect processing.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195903
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell


> On Jan. 23, 2018, noon, Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSConnectorProvider.java
> > Lines 40 (patched)
> > 
> >
> > should here extends OMRSRepositoryConnectorProviderBase?

No - the LocalOMRSRepositoryConnector is a fake connector - a facade - it wraps 
the real local connector and as such implements the repository connector 
interface but it is not pluggable and it can not be created through the 
connector broker (it will throw an exception if tried).  So it is not 
appropiate to extend the base class.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195986
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell


> On Jan. 23, 2018, 1:03 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java
> > Lines 133 (patched)
> > 
> >
> > here the realLocalConnector is OMRSReposirotyConnector, however 
> > disconnect() is not implemented in OMRSReposirotyConnector.

It must be implemented or the code will not compile - so I am puzzled by this 
comment.  The requirement to implement disconnect()
comes from Connector.  

/**
 * Free up any resources held since the connector is no longer needed.
 *
 * @throws ConnectorCheckedException - there is a problem disconnecting the 
connector.
 */
public abstract void disconnect() throws ConnectorCheckedException;


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195989
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell


> On Jan. 23, 2018, 1:03 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java
> > Lines 96 (patched)
> > 
> >
> > should here be 
> > this.localTypeDefManager.setupEventProcessor

It does not matter if we use the parameter or the locally saved copy - they are 
the same value.  The line before makes it so ...


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195989
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell


> On Jan. 23, 2018, 1:03 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSConnectorProvider.java
> > Lines 41 (patched)
> > 
> >
> > is it necessary to have a hashcode for LocalOMRSConnectorProvider?

No need - it is unlikely to be put in a hashmap - typically only create one of 
them and use it to create the local repository.  So in the unlikely event that 
someone needs a hashcode then the default implementation is adequate.  hashCode 
is worth overriding doe property objects.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195989
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell


> On Jan. 23, 2018, 1:03 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java
> > Lines 115 (patched)
> > 
> >
> > should here be 
> > this.repositoryEventManager.set...

The code is correct - there is no setRepositoryEventManager() method.  
OMRSRepositoryEventProcessor is an interface that the repository event manager 
implements.  The event mapper only needs an object that implements the 
processor interface.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195989
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell


> On Jan. 23, 2018, 1:21 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDef.java
> > Line 23 (original), 23 (patched)
> > 
> >
> > attribute can also be Classfication or Entity type?

Neither Classification nor entity types are valid attribute types.  The list is 
actually wrong because I am in the process of removing StructDef.  All 
references to structdef will be removed in the next patch.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195997
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-23 Thread Mandy Chessell


> On Jan. 23, 2018, 1:39 p.m., Yao Li wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatch.java
> > Lines 49 (patched)
> > 
> >
> > if the user wants to user create a TypeDefPatch, 
> > 
> > TypeDefPatch patch=new TypeDefPatch();
> > patch.setXXX()
> > 
> > is it necessary to have a constructor which contains all the variables 
> > as paramethers?

It is not necessary.  The caller can use the set methods.  In general I don't 
like the big constructors because they break encapsulation of the super type.  
They are necessary when an object is immutable.  It is sometimes useful to have 
constructors that show valid combinations.  The patch is a pretty flat object.  
We can add more constructors as and when we need them.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review195998
---


On Jan. 12, 2018, 1:35 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 12, 2018, 1:35 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> 

  1   2   >