Re: Review Request 65951: ATLAS-2487 : UI : Entities relationship changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65951/#review199039 --- Ship it! Ship It! - Madhan Neethiraj On March 12, 2018, 3:38 p.m., keval bhatt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65951/ > --- > > (Updated March 12, 2018, 3:38 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Nixon Rodrigues. > > > Bugs: ATLAS-2487 > https://issues.apache.org/jira/browse/ATLAS-2487 > > > Repository: atlas > > > Description > --- > > The patch contains following changes. > > * Added Relationship tab in entity detail page. > * Moved all tabs to the top. > * Moved Lineage to the top with all other tabs. > > > Diffs > - > > dashboardv2/public/css/bootstrap-sidebar.css fd4f21fb > dashboardv2/public/css/scss/common.scss 3c2dff57 > dashboardv2/public/css/scss/form.scss 694e885a > dashboardv2/public/css/scss/nav.scss 03858901 > dashboardv2/public/css/scss/override.scss 5f86b2d1 > dashboardv2/public/css/scss/relationship.scss PRE-CREATION > dashboardv2/public/css/scss/style.scss 531a727c > dashboardv2/public/css/scss/tab.scss 185a7b15 > dashboardv2/public/css/scss/theme.scss f5d0cd1b > dashboardv2/public/js/templates/common/TableLayout_tmpl.html a1104abb > dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html > b084ba1b > dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 76241db7 > dashboardv2/public/js/templates/graph/RelationshipLayoutView_tmpl.html > PRE-CREATION > dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html > 31300b8b > dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html > 7e0ed72f > dashboardv2/public/js/templates/site/Header.html 4673688f > dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html > 8298bc7c > dashboardv2/public/js/utils/Enums.js 5357fd99 > dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 19ac222b > dashboardv2/public/js/views/graph/LineageLayoutView.js fcf0c398 > dashboardv2/public/js/views/graph/RelationshipLayoutView.js PRE-CREATION > dashboardv2/public/js/views/profile/ProfileTableLayoutView.js 3e654eba > dashboardv2/public/js/views/site/Header.js 7ce18af0 > > > Diff: https://reviews.apache.org/r/65951/diff/5/ > > > Testing > --- > > > Thanks, > > keval bhatt > >
Re: Review Request 65951: ATLAS-2487 : UI : Entities relationship changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65951/ --- (Updated March 12, 2018, 3:38 p.m.) Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues. Bugs: ATLAS-2487 https://issues.apache.org/jira/browse/ATLAS-2487 Repository: atlas Description --- The patch contains following changes. * Added Relationship tab in entity detail page. * Moved all tabs to the top. * Moved Lineage to the top with all other tabs. Diffs (updated) - dashboardv2/public/css/bootstrap-sidebar.css fd4f21fb dashboardv2/public/css/scss/common.scss 3c2dff57 dashboardv2/public/css/scss/form.scss 694e885a dashboardv2/public/css/scss/nav.scss 03858901 dashboardv2/public/css/scss/override.scss 5f86b2d1 dashboardv2/public/css/scss/relationship.scss PRE-CREATION dashboardv2/public/css/scss/style.scss 531a727c dashboardv2/public/css/scss/tab.scss 185a7b15 dashboardv2/public/css/scss/theme.scss f5d0cd1b dashboardv2/public/js/templates/common/TableLayout_tmpl.html a1104abb dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html b084ba1b dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 76241db7 dashboardv2/public/js/templates/graph/RelationshipLayoutView_tmpl.html PRE-CREATION dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html 31300b8b dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 7e0ed72f dashboardv2/public/js/templates/site/Header.html 4673688f dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html 8298bc7c dashboardv2/public/js/utils/Enums.js 5357fd99 dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 19ac222b dashboardv2/public/js/views/graph/LineageLayoutView.js fcf0c398 dashboardv2/public/js/views/graph/RelationshipLayoutView.js PRE-CREATION dashboardv2/public/js/views/profile/ProfileTableLayoutView.js 3e654eba dashboardv2/public/js/views/site/Header.js 7ce18af0 Diff: https://reviews.apache.org/r/65951/diff/5/ Changes: https://reviews.apache.org/r/65951/diff/4-5/ Testing --- Thanks, keval bhatt
Re: Review Request 65951: ATLAS-2487 : UI : Entities relationship changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65951/ --- (Updated March 10, 2018, 4:33 p.m.) Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues. Bugs: ATLAS-2487 https://issues.apache.org/jira/browse/ATLAS-2487 Repository: atlas Description (updated) --- The patch contains following changes. * Added Relationship tab in entity detail page. * Moved all tabs to the top. * Moved Lineage to the top with all other tabs. Diffs (updated) - dashboardv2/public/css/bootstrap-sidebar.css fd4f21fb dashboardv2/public/css/scss/common.scss 3c2dff57 dashboardv2/public/css/scss/form.scss 694e885a dashboardv2/public/css/scss/nav.scss 03858901 dashboardv2/public/css/scss/override.scss 5f86b2d1 dashboardv2/public/css/scss/relationship.scss PRE-CREATION dashboardv2/public/css/scss/style.scss 531a727c dashboardv2/public/css/scss/tab.scss 185a7b15 dashboardv2/public/css/scss/theme.scss f5d0cd1b dashboardv2/public/js/templates/common/TableLayout_tmpl.html a1104abb dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html b084ba1b dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 76241db7 dashboardv2/public/js/templates/graph/RelationshipLayoutView_tmpl.html PRE-CREATION dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html 31300b8b dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 7e0ed72f dashboardv2/public/js/templates/site/Header.html 4673688f dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html 8298bc7c dashboardv2/public/js/utils/Enums.js 5357fd99 dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 19ac222b dashboardv2/public/js/views/graph/LineageLayoutView.js fcf0c398 dashboardv2/public/js/views/graph/RelationshipLayoutView.js PRE-CREATION dashboardv2/public/js/views/profile/ProfileTableLayoutView.js 3e654eba dashboardv2/public/js/views/site/Header.js 7ce18af0 Diff: https://reviews.apache.org/r/65951/diff/3/ Changes: https://reviews.apache.org/r/65951/diff/2-3/ Testing --- Thanks, keval bhatt
Re: Review Request 65951: ATLAS-2487 : UI : Entities relationship changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65951/ --- (Updated March 7, 2018, 3:22 p.m.) Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues. Bugs: ATLAS-2487 https://issues.apache.org/jira/browse/ATLAS-2487 Repository: atlas Description --- The patch contains following changes. * Relationship tab in entity detail page. * Moved all tabs to the top. * Moved Lineage to the top with all other tabs. Diffs (updated) - dashboardv2/public/css/scss/relationship.scss PRE-CREATION dashboardv2/public/css/scss/style.scss 531a727c dashboardv2/public/css/scss/tab.scss 185a7b15 dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html b084ba1b dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 76241db7 dashboardv2/public/js/templates/graph/RelationshipLayoutView_tmpl.html PRE-CREATION dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html 31300b8b dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html 8298bc7c dashboardv2/public/js/utils/Enums.js 5357fd99 dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 19ac222b dashboardv2/public/js/views/graph/RelationshipLayoutView.js PRE-CREATION Diff: https://reviews.apache.org/r/65951/diff/2/ Changes: https://reviews.apache.org/r/65951/diff/1-2/ Testing --- Thanks, keval bhatt