Re: Review Request 66507: ATLAS-2545 Update Storm hook to use V2 notifications

[Ruchi Solani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66507/
---

(Updated April 10, 2018, 9:03 a.m.)


Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-2545
https://issues.apache.org/jira/browse/ATLAS-2545


Repository: atlas


Description
---

Atlas server was enhanced to process notifications that use V2 data structures 
In 0.8.2 release (ATLAS-2421). HBase hook was updated to replace use of V1 data 
structures in notifications with V2 types. This Jira is to track similar update 
of Storm.


Diffs (updated)
-

  addons/storm-bridge/pom.xml 3446dcb7e 
  
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
 110ec521f 
  pom.xml 1934abf84 


Diff: https://reviews.apache.org/r/66507/diff/2/

Changes: https://reviews.apache.org/r/66507/diff/1-2/


Testing
---

Done with Sanity Test


Thanks,

Ruchi Solani

Re: Review Request 66507: ATLAS-2545 Update Storm hook to use V2 notifications

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66507/#review200750
---




addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
Line 91 (original), 87 (patched)


dependentEntities should be added as referredEntities in 'entity', line 
#100 below.



addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
Line 100 (original), 96 (patched)


nodes should be set to List and not List.



addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
Line 157 (original), 159 (patched)


'inputs' should be set to List and not List.



addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
Line 178 (original), 180 (patched)


'outputs' should be set to List and not List.



addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
Line 275 (original), 277 (patched)


ATTRIBUTE_DB should be set to AtlasObjectId and not AtlasEntity.


- Madhan Neethiraj


On April 9, 2018, 12:03 p.m., Ruchi Solani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66507/
> ---
> 
> (Updated April 9, 2018, 12:03 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2545
> https://issues.apache.org/jira/browse/ATLAS-2545
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas server was enhanced to process notifications that use V2 data 
> structures In 0.8.2 release (ATLAS-2421). HBase hook was updated to replace 
> use of V1 data structures in notifications with V2 types. This Jira is to 
> track similar update of Storm.
> 
> 
> Diffs
> -
> 
>   addons/storm-bridge/pom.xml 3446dcb 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
>  110ec52 
>   pom.xml 4d2ab73 
> 
> 
> Diff: https://reviews.apache.org/r/66507/diff/1/
> 
> 
> Testing
> ---
> 
> Done with Sanity Test
> 
> 
> Thanks,
> 
> Ruchi Solani
> 
>