----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66523/#review201033 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On April 10, 2018, 9:20 a.m., pratik pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66523/ > ----------------------------------------------------------- > > (Updated April 10, 2018, 9:20 a.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues. > > > Bugs: ATLAS-2543 > https://issues.apache.org/jira/browse/ATLAS-2543 > > > Repository: atlas > > > Description > ------- > > 1. Create a tag and associate the tag to an entity and provide 2 validity > periods. > 2.Edit the same tag associated to the entity and remove any validity period. > 3.Update button is not enabled. > > For other updates like adding new validity period, editing propagate flag , > editing tag attribute values , Update button is enabled. > > > Diffs > ----- > > dashboardv2/public/js/views/tag/AddTimezoneItemView.js ea2e9dc > > > Diff: https://reviews.apache.org/r/66523/diff/1/ > > > Testing > ------- > > Done one round of sanity testing. > > > Thanks, > > pratik pandey > >
