Re: Review Request 66907: ATLAS-2579 : UI : Block Propagation at classification level in edit propagation flow.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66907/#review202357 --- Ship it! Ship It! - Madhan Neethiraj On May 3, 2018, 3:05 p.m., keval bhatt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66907/ > --- > > (Updated May 3, 2018, 3:05 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2579 > https://issues.apache.org/jira/browse/ATLAS-2579 > > > Repository: atlas > > > Description > --- > > Show ONE_TO_TWO and NONE option and remove other options in Block > Propagation popup UI > > > Diffs > - > > dashboardv2/public/js/views/graph/PropagationPropertyModal.js bb7d1d73e > > > Diff: https://reviews.apache.org/r/66907/diff/2/ > > > Testing > --- > > Done one round of sanity test > > > Thanks, > > keval bhatt > >
Re: Review Request 66907: ATLAS-2579 : UI : Block Propagation at classification level in edit propagation flow.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66907/ --- (Updated May 3, 2018, 3:05 p.m.) Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian. Changes --- block tag checkbox issue handled Bugs: ATLAS-2579 https://issues.apache.org/jira/browse/ATLAS-2579 Repository: atlas Description --- Show ONE_TO_TWO and NONE option and remove other options in Block Propagation popup UI Diffs (updated) - dashboardv2/public/js/views/graph/PropagationPropertyModal.js bb7d1d73e Diff: https://reviews.apache.org/r/66907/diff/2/ Changes: https://reviews.apache.org/r/66907/diff/1-2/ Testing --- Done one round of sanity test Thanks, keval bhatt
Re: Review Request 66907: ATLAS-2579 : UI : Block Propagation at classification level in edit propagation flow.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66907/#review202296 --- Ship it! Ship It! - Sarath Subramanian On May 2, 2018, 7:23 a.m., keval bhatt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66907/ > --- > > (Updated May 2, 2018, 7:23 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2579 > https://issues.apache.org/jira/browse/ATLAS-2579 > > > Repository: atlas > > > Description > --- > > Show ONE_TO_TWO and NONE option and remove other options in Block > Propagation popup UI > > > Diffs > - > > > dashboardv2/public/js/templates/graph/PropagationPropertyModalView_tmpl.html > 1d008a944 > dashboardv2/public/js/utils/UrlLinks.js 2e5eefe12 > dashboardv2/public/js/views/graph/PropagationPropertyModal.js 0791eea92 > > > Diff: https://reviews.apache.org/r/66907/diff/1/ > > > Testing > --- > > Done one round of sanity test > > > Thanks, > > keval bhatt > >
Re: Review Request 66907: ATLAS-2579 : UI : Block Propagation at classification level in edit propagation flow.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66907/#review202294 --- The changes looks good Keval. I still see the update issue when you select all classifications in Block Propagatation Table, but only one blocked propagated classification is updated. - Sarath Subramanian On May 2, 2018, 7:23 a.m., keval bhatt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66907/ > --- > > (Updated May 2, 2018, 7:23 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2579 > https://issues.apache.org/jira/browse/ATLAS-2579 > > > Repository: atlas > > > Description > --- > > Show ONE_TO_TWO and NONE option and remove other options in Block > Propagation popup UI > > > Diffs > - > > > dashboardv2/public/js/templates/graph/PropagationPropertyModalView_tmpl.html > 1d008a944 > dashboardv2/public/js/utils/UrlLinks.js 2e5eefe12 > dashboardv2/public/js/views/graph/PropagationPropertyModal.js 0791eea92 > > > Diff: https://reviews.apache.org/r/66907/diff/1/ > > > Testing > --- > > Done one round of sanity test > > > Thanks, > > keval bhatt > >
