Re: Review Request 70019: ATLAS-3051: on container entity-delete, contained entities in composition relationship should be deleted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70019/#review212979 --- Ship it! Ship It! - Sarath Subramanian On Feb. 20, 2019, 8:27 a.m., madhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70019/ > --- > > (Updated Feb. 20, 2019, 8:27 a.m.) > > > Review request for atlas, Ashutosh Mestry, keval bhatt, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-3051 > https://issues.apache.org/jira/browse/ATLAS-3051 > > > Repository: atlas > > > Description > --- > > - when a container attribute in COMPOSITION relationship is added to > AtlasEntityType, ownedRef constrinat is added, so that existing behaviour of > ownedRef attribute will be extended to these relationship attributes as well > - added validation for contained entities in COMPOSITION relationship, to > require container is set i.e. mandatory attribute > > > Diffs > - > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > a4d6bedfb > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 0d63325da > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > 264c4fc30 > > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java > 92b8fafdb > > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java > d1da4e0ac > > repository/src/main/java/org/apache/atlas/repository/ogm/profiles/AtlasSavedSearchDTO.java > 68a874402 > > repository/src/main/java/org/apache/atlas/repository/ogm/profiles/AtlasUserProfileDTO.java > 620b14825 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > b2bd896b8 > > > Diff: https://reviews.apache.org/r/70019/diff/2/ > > > Testing > --- > > - verified that container entity delete causes its contained entities to be > deleted > - verified that entity-create requires container value be set for contined > entities > - pre-commit tests run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/928/ > > > Thanks, > > madhan > >
Re: Review Request 70019: ATLAS-3051: on container entity-delete, contained entities in composition relationship should be deleted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70019/ --- (Updated Feb. 20, 2019, 4:27 p.m.) Review request for atlas, Ashutosh Mestry, keval bhatt, Nixon Rodrigues, and Sarath Subramanian. Changes --- fix to address unit-test failures Bugs: ATLAS-3051 https://issues.apache.org/jira/browse/ATLAS-3051 Repository: atlas Description --- - when a container attribute in COMPOSITION relationship is added to AtlasEntityType, ownedRef constrinat is added, so that existing behaviour of ownedRef attribute will be extended to these relationship attributes as well - added validation for contained entities in COMPOSITION relationship, to require container is set i.e. mandatory attribute Diffs (updated) - intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java a4d6bedfb intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 0d63325da intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 264c4fc30 repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java 92b8fafdb repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java d1da4e0ac repository/src/main/java/org/apache/atlas/repository/ogm/profiles/AtlasSavedSearchDTO.java 68a874402 repository/src/main/java/org/apache/atlas/repository/ogm/profiles/AtlasUserProfileDTO.java 620b14825 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java b2bd896b8 Diff: https://reviews.apache.org/r/70019/diff/2/ Changes: https://reviews.apache.org/r/70019/diff/1-2/ Testing (updated) --- - verified that container entity delete causes its contained entities to be deleted - verified that entity-create requires container value be set for contined entities - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/928/ Thanks, madhan
