Re: Review Request 70650: ATLAS-3193: Import to Existing with Rename Import Transforms

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70650/#review215310
---


Ship it!




Ship It!

- Sarath Subramanian


On May 16, 2019, 5:17 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70650/
> ---
> 
> (Updated May 16, 2019, 5:17 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3193
> https://issues.apache.org/jira/browse/ATLAS-3193
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> - Removed the approach of handling _ExportRequest_.
> - New: Approach now handles _AtlasSchemaViolation_ and updates GUIDs after 
> matching _uniqueAttributes_.
> - Update: _GraphTransaction_ updated to conditionally log rollback exception.
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/annotation/GraphTransaction.java 
> 712016620 
>   repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 
> d0db58aa5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  bf90df19a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
>  82b408db4 
> 
> 
> Diff: https://reviews.apache.org/r/70650/diff/3/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> Existing tests.
> 
> **Functional tests**
> 
> Existing suite.
> 
> **PC Build**
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1105/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 70650: ATLAS-3193: Import to Existing with Rename Import Transforms

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70650/
---

(Updated May 17, 2019, 12:17 a.m.)


Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
---

Updates include: Addressed review comments.


Bugs: ATLAS-3193
https://issues.apache.org/jira/browse/ATLAS-3193


Repository: atlas


Description
---

**Approach**
- Removed the approach of handling _ExportRequest_.
- New: Approach now handles _AtlasSchemaViolation_ and updates GUIDs after 
matching _uniqueAttributes_.
- Update: _GraphTransaction_ updated to conditionally log rollback exception.


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/annotation/GraphTransaction.java 
712016620 
  repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 
d0db58aa5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 bf90df19a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
 82b408db4 


Diff: https://reviews.apache.org/r/70650/diff/3/

Changes: https://reviews.apache.org/r/70650/diff/2-3/


Testing
---

**Unit tests**
Existing tests.

**Functional tests**

Existing suite.

**PC Build**
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1105/


Thanks,

Ashutosh Mestry

Re: Review Request 70650: ATLAS-3193: Import to Existing with Rename Import Transforms

[Ashutosh Mestry via Review Board]

> On May 16, 2019, 11:32 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
> > Line 114 (original), 113 (patched)
> > 
> >
> > log exception details inside catch line# 113; this won't be logged 
> > since logRollback is false

This is upto the last known catcher to deal with the exception. In this case, 
it is ImportService who logs it and throws it back over the wire.


> On May 16, 2019, 11:32 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
> > Line 119 (original), 119 (patched)
> > 
> >
> > conside adding more details in the debug message.

The exception has a all the details about what field was attempted to be 
modified for what entity. Only thing missing is the value that was attempted to 
be written.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70650/#review215308
---


On May 16, 2019, 4:16 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70650/
> ---
> 
> (Updated May 16, 2019, 4:16 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3193
> https://issues.apache.org/jira/browse/ATLAS-3193
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> - Removed the approach of handling _ExportRequest_.
> - New: Approach now handles _AtlasSchemaViolation_ and updates GUIDs after 
> matching _uniqueAttributes_.
> - Update: _GraphTransaction_ updated to conditionally log rollback exception.
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/annotation/GraphTransaction.java 
> 712016620 
>   repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 
> d0db58aa5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  bf90df19a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
>  82b408db4 
> 
> 
> Diff: https://reviews.apache.org/r/70650/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> Existing tests.
> 
> **Functional tests**
> 
> Existing suite.
> 
> **PC Build**
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1105/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 70650: ATLAS-3193: Import to Existing with Rename Import Transforms

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70650/#review215308
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
Line 101 (original), 96 (patched)


consider looping twice using index/iterator instead of enum values; this 
enum values are not used elsewhere.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
Line 114 (original), 113 (patched)


log exception details inside catch line# 113; this won't be logged since 
logRollback is false



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
Line 119 (original), 119 (patched)


conside adding more details in the debug message.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
Lines 125 (patched)


Guid udpate failed => Guid update failed


- Sarath Subramanian


On May 15, 2019, 9:16 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70650/
> ---
> 
> (Updated May 15, 2019, 9:16 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3193
> https://issues.apache.org/jira/browse/ATLAS-3193
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> - Removed the approach of handling _ExportRequest_.
> - New: Approach now handles _AtlasSchemaViolation_ and updates GUIDs after 
> matching _uniqueAttributes_.
> - Update: _GraphTransaction_ updated to conditionally log rollback exception.
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/annotation/GraphTransaction.java 
> 712016620 
>   repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 
> d0db58aa5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  bf90df19a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
>  82b408db4 
> 
> 
> Diff: https://reviews.apache.org/r/70650/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> Existing tests.
> 
> **Functional tests**
> 
> Existing suite.
> 
> **PC Build**
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1105/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 70650: ATLAS-3193: Import to Existing with Rename Import Transforms

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70650/
---

(Updated May 16, 2019, 4:16 a.m.)


Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
---

Updates include: Refactoring for clarity.


Bugs: ATLAS-3193
https://issues.apache.org/jira/browse/ATLAS-3193


Repository: atlas


Description
---

**Approach**
- Removed the approach of handling _ExportRequest_.
- New: Approach now handles _AtlasSchemaViolation_ and updates GUIDs after 
matching _uniqueAttributes_.
- Update: _GraphTransaction_ updated to conditionally log rollback exception.


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/annotation/GraphTransaction.java 
712016620 
  repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 
d0db58aa5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 bf90df19a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
 82b408db4 


Diff: https://reviews.apache.org/r/70650/diff/2/

Changes: https://reviews.apache.org/r/70650/diff/1-2/


Testing
---

**Unit tests**
Existing tests.

**Functional tests**

Existing suite.

**PC Build**
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1105/


Thanks,

Ashutosh Mestry