Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review219727 --- Ship it! Ship It! - Sarath Subramanian On March 2, 2020,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated March 2, 2020, 9:47 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated March 2, 2020, 9:42 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review219725 --- Ship it! Fix it. - Ashutosh Mestry On Feb. 26, 2020, 9:21

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review219723 --- repository/src/test/java/org/apache/atlas/TestModules.java Line

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Feb. 26, 2020, 9:21 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Feb. 25, 2020, 10:14 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Jan. 28, 2020, 12:43 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

> On Jan. 22, 2020, 10:09 p.m., Sarath Subramanian wrote: > > addons/models/-Area0/0010-base_model.json > > Lines 4 (patched) > > > > > > if this enum is used only for aud consider renaming to > >

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

> On Jan. 22, 2020, 10:09 p.m., Sarath Subramanian wrote: > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > > Lines 495 (patched) > > > > > > why return type is ArrayNode.class? can we not

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review219365 --- addons/models/-Area0/0010-base_model.json Lines 4 (patched)

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Dec. 11, 2019, 1:17 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Dec. 10, 2019, 8:12 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Dec. 10, 2019, 8:08 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Dec. 10, 2019, 7:46 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218943 ---

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Dec. 5, 2019, 2:49 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

> On Dec. 5, 2019, 12:10 a.m., Sarath Subramanian wrote: > > intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java > > Lines 124 (patched) > > > > > > define equals() and hashCode() method as well.

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

> On Dec. 5, 2019, 12:39 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > > Lines 1057 (patched) > > > > > > This will cause 'DELETED'

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218929 --- addons/models/-Area0/0010-base_model.json Lines 458

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218927 ---

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Dec. 4, 2019, 9:57 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

> On Dec. 1, 2019, 4:37 p.m., Madhan Neethiraj wrote: > > addons/models/-Area0/0010-base_model.json > > Lines 5 (patched) > > > > > > "Audit Operation defines the operations we support for admin audit" => > >

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Dec. 4, 2019, 9:47 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

> On Dec. 1, 2019, 4:37 p.m., Madhan Neethiraj wrote: > > addons/models/-Area0/0010-base_model.json > > Lines 4 (patched) > > > > > > atlas_operation => atlas_admin_operation I think as you initially suggested to

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

> On Nov. 27, 2019, 12:39 a.m., Madhan Neethiraj wrote: > > addons/models/-Area0/0010-base_model.json > > Lines 442 (patched) > > > > > > Consider renaming 'clientHost' to 'clientId' - given this field is used

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

- Sidharth --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218808 --- On Nov. 30, 2019, 7:44 p.m., Sidharth Mishra wrote:

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218865 --- addons/models/-Area0/0010-base_model.json Lines 4 (patched)

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Nov. 30, 2019, 7:44 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

> On Nov. 25, 2019, 5:05 a.m., Madhan Neethiraj wrote: > > addons/models/-Area0/0010-base_model.json > > Lines 397 (patched) > > > > > > - I suggest adding attribute 'serverName', that will be set to > >

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218808 --- addons/models/-Area0/0010-base_model.json Lines 442

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Nov. 26, 2019, 9:11 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218785 --- addons/models/-Area0/0010-base_model.json Lines 4 (patched)

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Nov. 21, 2019, 8:39 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/ --- (Updated Nov. 20, 2019, 12:23 a.m.) Review request for atlas, Ashutosh Mestry,