Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-13 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72440/#review220753
---


Ship it!




Ship It!

- Madhan Neethiraj


On May 13, 2020, 10:51 p.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72440/
> ---
> 
> (Updated May 13, 2020, 10:51 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> No way to sort results by specified attribute while freetext search is 
> enabled. In our case we would like to enforce ordering by introducing custom 
> attribute definition e.g. popularity score from 
> https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json
> 
> 
> Reference to jira https://issues.apache.org/jira/browse/ATLAS-3758
> Patched applied against master branch.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  fb12244ed 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  9850d8ecf 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 11eb7ca49 
>   
> repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java
>  PRE-CREATION 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml 9264f99d4 
> 
> 
> Diff: https://reviews.apache.org/r/72440/diff/2/
> 
> 
> Testing
> ---
> 
> Patch was applied on our dev env with custom entity definitions and 
> successfully verified if order is applied as specified in the search query.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>



Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-13 Thread Damian Warszawski


> On May 7, 2020, 12:21 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
> > Lines 995 (patched)
> > 
> >
> > entityType could be null when called from FreeTextSearchProcessor. 
> > Please review and update to handle this condition.

Good point, additional check added.


- Damian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72440/#review220666
---


On May 13, 2020, 10:51 p.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72440/
> ---
> 
> (Updated May 13, 2020, 10:51 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> No way to sort results by specified attribute while freetext search is 
> enabled. In our case we would like to enforce ordering by introducing custom 
> attribute definition e.g. popularity score from 
> https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json
> 
> 
> Reference to jira https://issues.apache.org/jira/browse/ATLAS-3758
> Patched applied against master branch.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  fb12244ed 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  9850d8ecf 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 11eb7ca49 
>   
> repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java
>  PRE-CREATION 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml 9264f99d4 
> 
> 
> Diff: https://reviews.apache.org/r/72440/diff/2/
> 
> 
> Testing
> ---
> 
> Patch was applied on our dev env with custom entity definitions and 
> successfully verified if order is applied as specified in the search query.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>



Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-13 Thread Damian Warszawski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72440/
---

(Updated May 13, 2020, 10:51 p.m.)


Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
and Sarath Subramanian.


Changes
---

add unit tests for freetext search processor


Repository: atlas


Description
---

No way to sort results by specified attribute while freetext search is enabled. 
In our case we would like to enforce ordering by introducing custom attribute 
definition e.g. popularity score from 
https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json


Reference to jira https://issues.apache.org/jira/browse/ATLAS-3758
Patched applied against master branch.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
fb12244ed 
  
repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
 9850d8ecf 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
11eb7ca49 
  
repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java
 PRE-CREATION 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 9264f99d4 


Diff: https://reviews.apache.org/r/72440/diff/2/

Changes: https://reviews.apache.org/r/72440/diff/1-2/


Testing
---

Patch was applied on our dev env with custom entity definitions and 
successfully verified if order is applied as specified in the search query.


Thanks,

Damian Warszawski



Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-13 Thread Damian Warszawski


> On May 6, 2020, 6:57 a.m., Bolke de Bruin wrote:
> > Can you please update the tests?
> 
> Sarath Subramanian wrote:
> +1

introduced unit tests for FreetextSearchProcessor


- Damian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72440/#review220648
---


On May 13, 2020, 10:51 p.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72440/
> ---
> 
> (Updated May 13, 2020, 10:51 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> No way to sort results by specified attribute while freetext search is 
> enabled. In our case we would like to enforce ordering by introducing custom 
> attribute definition e.g. popularity score from 
> https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json
> 
> 
> Reference to jira https://issues.apache.org/jira/browse/ATLAS-3758
> Patched applied against master branch.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  fb12244ed 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  9850d8ecf 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 11eb7ca49 
>   
> repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java
>  PRE-CREATION 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml 9264f99d4 
> 
> 
> Diff: https://reviews.apache.org/r/72440/diff/2/
> 
> 
> Testing
> ---
> 
> Patch was applied on our dev env with custom entity definitions and 
> successfully verified if order is applied as specified in the search query.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>



Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-06 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72440/#review220666
---




repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Lines 995 (patched)


entityType could be null when called from FreeTextSearchProcessor. Please 
review and update to handle this condition.


- Madhan Neethiraj


On April 29, 2020, 10:26 a.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72440/
> ---
> 
> (Updated April 29, 2020, 10:26 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> No way to sort results by specified attribute while freetext search is 
> enabled. In our case we would like to enforce ordering by introducing custom 
> attribute definition e.g. popularity score from 
> https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json
> 
> 
> Reference to jira https://issues.apache.org/jira/browse/ATLAS-3758
> Patched applied against master branch.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  1a7bf6b16 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  92b5eb4d2 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 11eb7ca49 
> 
> 
> Diff: https://reviews.apache.org/r/72440/diff/1/
> 
> 
> Testing
> ---
> 
> Patch was applied on our dev env with custom entity definitions and 
> successfully verified if order is applied as specified in the search query.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>



Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-05-06 Thread Bolke de Bruin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72440/#review220648
---



Can you please update the tests?

- Bolke de Bruin


On April 29, 2020, 10:26 a.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72440/
> ---
> 
> (Updated April 29, 2020, 10:26 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> No way to sort results by specified attribute while freetext search is 
> enabled. In our case we would like to enforce ordering by introducing custom 
> attribute definition e.g. popularity score from 
> https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json
> 
> 
> Reference to jira https://issues.apache.org/jira/browse/ATLAS-3758
> Patched applied against master branch.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  1a7bf6b16 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  92b5eb4d2 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 11eb7ca49 
> 
> 
> Diff: https://reviews.apache.org/r/72440/diff/1/
> 
> 
> Testing
> ---
> 
> Patch was applied on our dev env with custom entity definitions and 
> successfully verified if order is applied as specified in the search query.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>



Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-04-29 Thread Damian Warszawski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72440/
---

(Updated April 29, 2020, 10:26 a.m.)


Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
and Sarath Subramanian.


Changes
---

added reference to jira


Repository: atlas


Description (updated)
---

No way to sort results by specified attribute while freetext search is enabled. 
In our case we would like to enforce ordering by introducing custom attribute 
definition e.g. popularity score from 
https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json


Reference to jira https://issues.apache.org/jira/browse/ATLAS-3758
Patched applied against master branch.


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
1a7bf6b16 
  
repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
 92b5eb4d2 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
11eb7ca49 


Diff: https://reviews.apache.org/r/72440/diff/1/


Testing
---

Patch was applied on our dev env with custom entity definitions and 
successfully verified if order is applied as specified in the search query.


Thanks,

Damian Warszawski



Re: Review Request 72440: Support sort params for FreeTextSearchProcessor

2020-04-28 Thread Damian Warszawski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72440/
---

(Updated April 28, 2020, 8:59 p.m.)


Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
and Sarath Subramanian.


Repository: atlas


Description
---

No way to sort results by specified attribute while freetext search is enabled. 
In our case we would like to enforce ordering by introducing custom attribute 
definition e.g. popularity score from 
https://github.com/dwarszawski/amundsen-atlas-types/blob/master/amundsenatlastypes/schema/01_2_table_schema.json


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
1a7bf6b16 
  
repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
 92b5eb4d2 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
11eb7ca49 


Diff: https://reviews.apache.org/r/72440/diff/1/


Testing
---

Patch was applied on our dev env with custom entity definitions and 
successfully verified if order is applied as specified in the search query.


Thanks,

Damian Warszawski