Re: Review Request 72627: ATLAS-3867 : Relationship search API should have a provision to fetch custom attributes in search results

2020-07-03 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72627/#review221120
---


Ship it!




Ship It!

- Madhan Neethiraj


On July 1, 2020, 5:26 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72627/
> ---
> 
> (Updated July 1, 2020, 5:26 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3867
> https://issues.apache.org/jira/browse/ATLAS-3867
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Issue:** Attributes in search result of Relationship api are minimal.
> 
> **WorkAround:** Relationship api request should have provision to specify 
> attributes to be present in search result.
> 
> **Example Request:** 
> /v2/search/relationship?guid=ac9e04cc-f927-4334-af08-c83bc3733f5b=columns=name=ASCENDING=dcProfiledData
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  e64c31522 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4169e14ef 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 076284ec4 
> 
> 
> Diff: https://reviews.apache.org/r/72627/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested
> Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1994
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>



Re: Review Request 72627: ATLAS-3867 : Relationship search API should have a provision to fetch custom attributes in search results

2020-06-30 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72627/#review221106
---


Ship it!




Ship It!

- Sarath Subramanian


On June 30, 2020, 10:26 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72627/
> ---
> 
> (Updated June 30, 2020, 10:26 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3867
> https://issues.apache.org/jira/browse/ATLAS-3867
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Issue:** Attributes in search result of Relationship api are minimal.
> 
> **WorkAround:** Relationship api request should have provision to specify 
> attributes to be present in search result.
> 
> **Example Request:** 
> /v2/search/relationship?guid=ac9e04cc-f927-4334-af08-c83bc3733f5b=columns=name=ASCENDING=dcProfiledData
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  e64c31522 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4169e14ef 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 076284ec4 
> 
> 
> Diff: https://reviews.apache.org/r/72627/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested
> Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1994
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>



Re: Review Request 72627: ATLAS-3867 : Relationship search API should have a provision to fetch custom attributes in search results

2020-06-30 Thread Pinal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72627/
---

(Updated July 1, 2020, 5:26 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

rebase patch


Bugs: ATLAS-3867
https://issues.apache.org/jira/browse/ATLAS-3867


Repository: atlas


Description
---

**Issue:** Attributes in search result of Relationship api are minimal.

**WorkAround:** Relationship api request should have provision to specify 
attributes to be present in search result.

**Example Request:** 
/v2/search/relationship?guid=ac9e04cc-f927-4334-af08-c83bc3733f5b=columns=name=ASCENDING=dcProfiledData


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 
e64c31522 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
4169e14ef 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 076284ec4 


Diff: https://reviews.apache.org/r/72627/diff/2/

Changes: https://reviews.apache.org/r/72627/diff/1-2/


Testing
---

Manually tested
Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1994


Thanks,

Pinal Shah