Re: Review Request 72630: ATLAS-3868: [Regression] removing a term-association doesn't remove classifications propagated from the term

2020-06-30 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72630/#review221096
---


Ship it!




Ship It!

- Madhan Neethiraj


On June 30, 2020, 5:52 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72630/
> ---
> 
> (Updated June 30, 2020, 5:52 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nikhil Bonte, Nixon Rodrigues, Pinal Shah, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3868
> https://issues.apache.org/jira/browse/ATLAS-3868
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Issue:
> ==
> removing a term-association doesn't remove classifications propagated from 
> the term
> 
> Cause:
> ==
> Regression caused by https://issues.apache.org/jira/browse/ATLAS-3863
> 
> Solution:
> =
> Re-evaluate tag propagation only when relationship (edge) is force deleted or 
> for internal types.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
>  72dd632f4 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
>  59e7cf864 
> 
> 
> Diff: https://reviews.apache.org/r/72630/diff/2/
> 
> 
> Testing
> ---
> 
> Manually validated - term dissassociation removes all propagated 
> classifications
> 
> Precommit:
> ==
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1998/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>



Re: Review Request 72630: ATLAS-3868: [Regression] removing a term-association doesn't remove classifications propagated from the term

2020-06-29 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72630/
---

(Updated June 29, 2020, 10:52 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nikhil Bonte, Nixon Rodrigues, Pinal Shah, and Sidharth Mishra.


Changes
---

moved logic to evaluate removeTagPropagation logic inside hard/soft delete 
handler.


Bugs: ATLAS-3868
https://issues.apache.org/jira/browse/ATLAS-3868


Repository: atlas


Description
---

Issue:
==
removing a term-association doesn't remove classifications propagated from the 
term

Cause:
==
Regression caused by https://issues.apache.org/jira/browse/ATLAS-3863

Solution:
=
Re-evaluate tag propagation only when relationship (edge) is force deleted or 
for internal types.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
 72dd632f4 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
 59e7cf864 


Diff: https://reviews.apache.org/r/72630/diff/2/

Changes: https://reviews.apache.org/r/72630/diff/1-2/


Testing
---

Manually validated - term dissassociation removes all propagated classifications

Precommit:
==
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1996/


Thanks,

Sarath Subramanian



Re: Review Request 72630: ATLAS-3868: [Regression] removing a term-association doesn't remove classifications propagated from the term

2020-06-29 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72630/#review221094
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Lines 159 (patched)


Shouldn't removeTagPropagation() be called from inside deleteEdge(edge, 
isForceDelete) implemenation? deleteEdge(edge, isForceDelete) seems to be 
called from multiple places; please review if tag-propagation needs to be 
re-evaluated in these contexts.


- Madhan Neethiraj


On June 29, 2020, 10:28 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72630/
> ---
> 
> (Updated June 29, 2020, 10:28 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nikhil Bonte, Nixon Rodrigues, Pinal Shah, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3868
> https://issues.apache.org/jira/browse/ATLAS-3868
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Issue:
> ==
> removing a term-association doesn't remove classifications propagated from 
> the term
> 
> Cause:
> ==
> Regression caused by https://issues.apache.org/jira/browse/ATLAS-3863
> 
> Solution:
> =
> Re-evaluate tag propagation only when relationship (edge) is force deleted or 
> for internal types.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  717310daf 
> 
> 
> Diff: https://reviews.apache.org/r/72630/diff/1/
> 
> 
> Testing
> ---
> 
> Manually validated - term dissassociation removes all propagated 
> classifications
> 
> Precommit:
> ==
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1996/
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>