Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-31 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221439 --- Ship it! Ship It! - Madhan Neethiraj On July 31, 2020, 3:57

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-31 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 31, 2020, 3:57 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-31 Thread Ashutosh Mestry via Review Board
> On July 30, 2020, 11:58 p.m., Sarath Subramanian wrote: > > good memory improvement fix! Thanks! - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221431

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-30 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221431 --- Fix it, then Ship it! good memory improvement fix!

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-30 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221430 --- Fix it, then Ship it!

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-30 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 30, 2020, 10:58 p.m.) Review request for atlas, Madhan

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-30 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221422 --- intg/src/main/java/org/apache/atlas/utils/FixedBufferList.java

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-30 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 30, 2020, 5:55 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-29 Thread Ashutosh Mestry via Review Board
> On July 23, 2020, 9:16 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java > > Lines 409 (patched) > > > > > > should we reset/clear these

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-29 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221413 --- What is the impact on the memory usage improvement, after

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-29 Thread Ashutosh Mestry via Review Board
> On July 24, 2020, 7:14 a.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/utils/FixedBufferList.java > > Lines 67 (patched) > > > > > > incrementCapacityBy is already an instance member, line #29

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 29, 2020, 6:23 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-24 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221351 --- intg/src/main/java/org/apache/atlas/utils/FixedBufferList.java

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 24, 2020, 5:18 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-23 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221337 ---

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-23 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221333 --- intg/src/main/java/org/apache/atlas/utils/FixedBufferList.java

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 23, 2020, 6:48 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-23 Thread Ashutosh Mestry via Review Board
> On July 23, 2020, 5:59 p.m., Sarath Subramanian wrote: > > intg/src/main/java/org/apache/atlas/utils/FixedBufferList.java > > Lines 33 (patched) > > > > > > ArrayList => List I would prefer to keep it buffer since

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-23 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221322 --- intg/src/main/java/org/apache/atlas/utils/FixedBufferList.java

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-22 Thread Nikhil Bonte
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221317 --- Ship it! Ship It! - Nikhil Bonte On July 22, 2020, 4:16

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 22, 2020, 4:16 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-20 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 20, 2020, 11:46 p.m.) Review request for atlas, Madhan

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-13 Thread Ashutosh Mestry via Review Board
> On July 10, 2020, 8:11 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/utils/FixedBufferList.java > > Lines 38 (patched) > > > > > > 'bufferElementClass' can be derived from the generic, as

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 13, 2020, 7:45 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-10 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221193 --- intg/src/main/java/org/apache/atlas/utils/FixedBufferList.java

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-10 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221179 ---

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 10, 2020, 4:43 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-10 Thread Nikhil Bonte
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221192 --- intg/src/main/java/org/apache/atlas/utils/FixedBufferList.java

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 9, 2020, 6:17 p.m.) Review request for atlas, Madhan Neethiraj,