Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-30 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221432 --- Ship it! Ship It! - Sarath Subramanian On July 30, 2020,

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-30 Thread Damian Warszawski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/ --- (Updated July 30, 2020, 10:23 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-29 Thread Damian Warszawski
It appears that by setting consistency to lock, there is different field mapping in freetext handler. I am working to fix that. On Wed, 29 Jul 2020 at 22:31, Madhan Neethiraj wrote: > Damian, > > A number of tests fail with this patch - see below. Can you please run > 'mvn clean package' and

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-29 Thread Madhan Neethiraj
Damian, A number of tests fail with this patch - see below. Can you please run 'mvn clean package' and investigate these failures? Thanks, Madhan Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 105.055 sec <<< FAILURE! - in

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-29 Thread Damian Warszawski
> On July 28, 2020, 10:55 p.m., Madhan Neethiraj wrote: > > Ship It! Can I ask you to merge it? I don't think I have permissions to merge it to master. - Damian --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-28 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221401 --- Ship it! Ship It! - Madhan Neethiraj On July 25, 2020, 8:53

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-25 Thread Damian Warszawski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/ --- (Updated July 25, 2020, 8:53 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221368 ---

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Ashutosh Mestry via Review Board
> On July 23, 2020, 9:28 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java > > Line 39 (original), 39 (patched) > > > > > > We will need to

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Ashutosh Mestry via Review Board
> On July 23, 2020, 4:52 a.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java > > Lines 44 (patched) > > > > > > I suggest use AtlasConfiguration

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Damian Warszawski
> On July 23, 2020, 4:52 a.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java > > Lines 44 (patched) > > > > > > I suggest use AtlasConfiguration

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Damian Warszawski
> On July 23, 2020, 9:28 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java > > Line 39 (original), 39 (patched) > > > > > > We will need to

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Damian Warszawski
> On July 23, 2020, 4:52 a.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java > > Lines 44 (patched) > > > > > > I suggest use AtlasConfiguration

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Damian Warszawski
> On July 21, 2020, 9:06 p.m., Madhan Neethiraj wrote: > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java > > Lines 260 (patched) > > > > > > Consistency lock

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Damian Warszawski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/ --- (Updated July 24, 2020, 8:23 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221338 ---

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221323 ---

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-22 Thread Ashutosh Mestry via Review Board
> On July 21, 2020, 8:38 p.m., Ashutosh Mestry wrote: > > Here's what I have tried so far: > > - Concurrent entity creation using my own test rig. This creates entities > > concurrently but it does not allow for entity with same qualifiedName to be > > created by different workers. > > -

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-22 Thread Ashutosh Mestry via Review Board
> On July 22, 2020, 4:30 p.m., Ashutosh Mestry wrote: > > I attempted to create same entity (entity with same qualifiedName) from > > multiple requests. > > > > I did this experiment: > > - Created an entity payload. > > - Used bulk entity CURL calls from 5 different requests. > > > >

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221314 --- I attempted to create same entity (entity with same

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-21 Thread Madhan Neethiraj
> On July 21, 2020, 8:38 p.m., Ashutosh Mestry wrote: > > Here's what I have tried so far: > > - Concurrent entity creation using my own test rig. This creates entities > > concurrently but it does not allow for entity with same qualifiedName to be > > created by different workers. > > -

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-21 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221297 ---

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-21 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221296 --- Here's what I have tried so far: - Concurrent entity creation