Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-08-12 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221556 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 4, 2020, 4:27

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-08-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221539 --- The sample-app fails to run with the following error: [ERROR]

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-08-04 Thread Jyoti Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- (Updated Aug. 4, 2020, 4:27 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-08-04 Thread Jyoti Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- (Updated Aug. 4, 2020, 4:05 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-27 Thread Jyoti Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- (Updated July 27, 2020, 8:06 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-27 Thread Jyoti Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- (Updated July 27, 2020, 7:57 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-27 Thread Jyoti Singh
> On July 26, 2020, 8:15 p.m., Madhan Neethiraj wrote: > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java > > Lines 94 (patched) > > > > > > getAllTypeDef() implies

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-26 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221372 --- atlas-examples/pom.xml Lines 1 (patched)

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-24 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221369 --- Ship it! Ship It! - Sidharth Mishra On July 23, 2020, 6:10

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-23 Thread Jyoti Singh
> On July 22, 2020, 7:24 p.m., Sidharth Mishra wrote: > > atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java > > Lines 63 (patched) > > > > > > char[] is always preferred over String - check >

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-23 Thread Jyoti Singh
> On July 22, 2020, 7:24 p.m., Sidharth Mishra wrote: > > atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java > > Lines 140 (patched) > > > > > > Please use Console.readPassword instead Not

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-23 Thread Jyoti Singh
> On July 22, 2020, 7:24 p.m., Sidharth Mishra wrote: > > atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java > > Lines 86 (patched) > > > > > > Instead of commenting like typedef then entity

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-23 Thread Jyoti Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- (Updated July 23, 2020, 6:10 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-22 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221321 ---

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-22 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221306 ---

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-21 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221300 ---

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-21 Thread Jyoti Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/ --- (Updated July 21, 2020, 4:24 p.m.) Review request for atlas, Ashutosh Mestry,